From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.3 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_PASS,URIBL_BLOCKED,USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2F673C433F4 for ; Fri, 21 Sep 2018 06:29:52 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id E2C9721522 for ; Fri, 21 Sep 2018 06:29:51 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org E2C9721522 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=suse.de Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2389354AbeIUMRN (ORCPT ); Fri, 21 Sep 2018 08:17:13 -0400 Received: from mx2.suse.de ([195.135.220.15]:45800 "EHLO mx1.suse.de" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S2389220AbeIUMRN (ORCPT ); Fri, 21 Sep 2018 08:17:13 -0400 X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.220.254]) by mx1.suse.de (Postfix) with ESMTP id B61FCB093; Fri, 21 Sep 2018 06:29:48 +0000 (UTC) Date: Fri, 21 Sep 2018 08:29:47 +0200 From: Johannes Thumshirn To: Bart Van Assche Cc: "Martin K . Petersen" , Linux Kernel Mailinglist , Linux SCSI Mailinglist , Hannes Reinecke , Christoph Hellwig Subject: Re: [PATCH] scsi: sd: don't crash the host on invalid commands Message-ID: <20180921062947.GA4913@linux-x5ow.site> References: <20180920071907.10102-1-jthumshirn@suse.de> <1537467499.224533.21.camel@acm.org> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <1537467499.224533.21.camel@acm.org> User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Sep 20, 2018 at 11:18:19AM -0700, Bart Van Assche wrote: > On Thu, 2018-09-20 at 09:19 +0200, Johannes Thumshirn wrote: > > Have you considered to use WARN_ON_ONCE() instead of WARN_ON(1)? Otherwise > this patch looks good to me. Indeed I did and then forgot to 'git commit --amend' it befroe sending it out. I'll do so now. Johannes -- Johannes Thumshirn Storage jthumshirn@suse.de +49 911 74053 689 SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg GF: Felix Imendörffer, Jane Smithard, Graham Norton HRB 21284 (AG Nürnberg) Key fingerprint = EC38 9CAB C2C4 F25D 8600 D0D0 0393 969D 2D76 0850