From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_PASS,URIBL_DBL_ABUSE_MALW, USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 106BBECE560 for ; Fri, 21 Sep 2018 21:18:04 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id AB3902156E for ; Fri, 21 Sep 2018 21:18:03 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org AB3902156E Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=ucw.cz Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2391531AbeIVDIl (ORCPT ); Fri, 21 Sep 2018 23:08:41 -0400 Received: from atrey.karlin.mff.cuni.cz ([195.113.26.193]:59259 "EHLO atrey.karlin.mff.cuni.cz" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2391243AbeIVDIl (ORCPT ); Fri, 21 Sep 2018 23:08:41 -0400 Received: by atrey.karlin.mff.cuni.cz (Postfix, from userid 512) id 9ABA880743; Fri, 21 Sep 2018 23:17:59 +0200 (CEST) Date: Fri, 21 Sep 2018 23:17:58 +0200 From: Pavel Machek To: Jacek Anaszewski Cc: Baolin Wang , rteysseyre@gmail.com, Bjorn Andersson , Mark Brown , Linus Walleij , Linux LED Subsystem , LKML Subject: Re: [PATCH v12 1/2] leds: core: Introduce LED pattern trigger Message-ID: <20180921211758.GC18062@amd> References: <67ebebf02edd6d8ee42a13b139733e9cc680ea86.1536631975.git.baolin.wang@linaro.org> <324778a9-a32c-ae6e-337a-39845f214bfc@gmail.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="NU0Ex4SbNnrxsi6C" Content-Disposition: inline In-Reply-To: <324778a9-a32c-ae6e-337a-39845f214bfc@gmail.com> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --NU0Ex4SbNnrxsi6C Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Fri 2018-09-21 22:59:40, Jacek Anaszewski wrote: > Hi Baolin, >=20 > On 09/21/2018 05:31 AM, Baolin Wang wrote: > > Hi Jacek and Pavel, > >=20 > > On 11 September 2018 at 10:47, Baolin Wang wro= te: > >> This patch adds one new led trigger that LED device can configure > >> the software or hardware pattern and trigger it. > >> > >> Consumers can write 'pattern' file to enable the software pattern > >> which alters the brightness for the specified duration with one > >> software timer. > >> > >> Moreover consumers can write 'hw_pattern' file to enable the hardware > >> pattern for some LED controllers which can autonomously control > >> brightness over time, according to some preprogrammed hardware > >> patterns. > >> > >> Signed-off-by: Raphael Teysseyre > >> Signed-off-by: Baolin Wang > > Do you have any comments for the v12 patch set? Thanks. >=20 > We will probably have to remove hw_pattern from ledtrig-pattern > since we are unable to come up with generic interface for it. > Unless thread [0] will end up with some brilliant ideas. So far > we're waiting for Pavel's reply. >=20 > [0] https://lkml.org/lkml/2018/9/13/1216 To paint a picture: brightness rise hold lower hold down ^ XXXXXXXXXXXXXXX | X XX | X XX | X XXXXXXXXXXXXXXXXXXXXXXXXXX +-------------------------------------------------------> time This is what Baolin's hardware can do, right? This is also what pattern trigger can do, right? So all we need to do is match the two interfaces, so that hw_pattern returns -EINVAL on patterns hardware can not actually do. I believe I described code to do that in [0] above. Best regards, Pavel --=20 (english) http://www.livejournal.com/~pavelmachek (cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blo= g.html --NU0Ex4SbNnrxsi6C Content-Type: application/pgp-signature; name="signature.asc" Content-Description: Digital signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iEYEARECAAYFAlulYAYACgkQMOfwapXb+vIJRgCffOmvia1hPAQGZz0N+KNpi2lm yuIAoKxzd78UcCCS+x133y+Fr+jNrBjt =O2R8 -----END PGP SIGNATURE----- --NU0Ex4SbNnrxsi6C--