From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.8 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 16463ECE560 for ; Sat, 22 Sep 2018 15:21:09 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id A6F462150E for ; Sat, 22 Sep 2018 15:21:08 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=kernel.org header.i=@kernel.org header.b="LVVFW4Kl" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org A6F462150E Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728977AbeIVVO7 (ORCPT ); Sat, 22 Sep 2018 17:14:59 -0400 Received: from mail.kernel.org ([198.145.29.99]:34364 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728327AbeIVVO6 (ORCPT ); Sat, 22 Sep 2018 17:14:58 -0400 Received: from archlinux (cpc91196-cmbg18-2-0-cust659.5-4.cable.virginm.net [81.96.234.148]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 57691214C1; Sat, 22 Sep 2018 15:21:00 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1537629662; bh=EF9NDCG+EJUgn5yVrlUArrIPHvSy/tup89ca3BTkEiA=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=LVVFW4Klw+ojF52b3H8M1izoRK7JdsLYYmPAwkoUu7jP/lQ3RcS73luBEJKtllsYC fIM0Md0N+ogB1ELegWCC55Z2byV3y1de+Us1tft9dUyQrUz2c83kn9ehwgPMipfOYL jjYS9vm68Azxwej/349BA95jspC3nOz+bpp95VHE= Date: Sat, 22 Sep 2018 16:20:57 +0100 From: Jonathan Cameron To: Tomasz Duszynski Cc: r yang , Hartmut Knaack , Lars-Peter Clausen , Peter Meerwald-Stadler , Rob Herring , Mark Rutland , linux-iio@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 2/2] iio: light: bh1750: Add device tree support Message-ID: <20180922162057.0924ede8@archlinux> In-Reply-To: <20180921153420.GA11850@arch> References: <387c145949692c0318f90d98426be95c82ea2e58.1537033044.git.decatf@gmail.com> <20180919192238.GA19391@arch> <20180921013721.GA4268@r> <20180921153420.GA11850@arch> X-Mailer: Claws Mail 3.17.1 (GTK+ 2.24.32; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, 21 Sep 2018 17:34:21 +0200 Tomasz Duszynski wrote: > On Thu, Sep 20, 2018 at 09:37:21PM -0400, r yang wrote: > > On Wed, Sep 19, 2018 at 09:22:39PM +0200, Tomasz Duszynski wrote: > > > Comments inline. > > > > > > On Sat, Sep 15, 2018 at 01:42:14PM -0400, ryang wrote: > > > > Add device tree support for ROHM BH1750 series ambient light sensors. > > > > > > > > Signed-off-by: ryang > > > > --- > > > > drivers/iio/light/bh1750.c | 10 ++++++++++ > > > > 1 file changed, 10 insertions(+) > > > > > > > > diff --git a/drivers/iio/light/bh1750.c b/drivers/iio/light/bh1750.c > > > > index a814828e69f5..50b599abb383 100644 > > > > --- a/drivers/iio/light/bh1750.c > > > > +++ b/drivers/iio/light/bh1750.c > > > > @@ -315,9 +315,19 @@ static const struct i2c_device_id bh1750_id[] = { > > > > }; > > > > MODULE_DEVICE_TABLE(i2c, bh1750_id); > > > > > > > > +static const struct of_device_id bh1750_of_match[] = { > > > > + { .compatible = "rohm,bh1710", }, > > > > + { .compatible = "rohm,bh1715", }, > > > > + { .compatible = "rohm,bh1721", }, > > > > + { .compatible = "rohm,bh1750", }, > > > > + { .compatible = "rohm,bh1751", }, > > > > + { } > > > > +}; > > > > + > > > > > > Hmm, I believe this should be exported additionally using > > > MODULE_DEVICE_TABLE(of, bh1750_of_match). Otherwise module loading > > > will not work as expected. > > > > > > Moreover, we can do without DT and if you want to avoid > > > warning about unused variables you may consider enclosing everything > > > with: > > > > > > #ifdef CONFIG_OF > > > ... > > > #endif Don't do that. There is a significant oddity now around this in that it is possible to use a magic ACPI device ID to probe via a devicetree binding (without CONFIG_OF). It's seriously odd, but to allow that to work we need to not protect things with #ifdef CONFIG_OF. (and this particular bit of fun strikes me as crazy too, but it's what we have!) https://www.kernel.org/doc/Documentation/acpi/enumeration.txt (towards the bottom) Having MODULE_DEVICE_TABLE is a good addition. > > > > The reason for this DT patch is because I've ported the Samsung Galaxy > > Tab 10.1 to the mainline kernel. The device is working on the Tegra > > platform with the right DTS file. Some peripherals on this device have > > existing drivers such as this one which only need the DT bindings for > > it be usuable. > > > > Adding support for DT is fine. Just pointed a figner at two things > that attracted my attention. > > > > > > > > static struct i2c_driver bh1750_driver = { > > > > .driver = { > > > > .name = "bh1750", > > > > + .of_match_table = of_match_ptr(bh1750_of_match), > > > > .pm = BH1750_PM_OPS, > > > > > > I've recently simplified setting pm ops so this would not apply to > > > iio/togreg cleanly. > > > > > > > Does this mean I should wait until that is merged before submitting a V2 > > patch? > > > > No need to wait. I guess you should rebase your work on iio/togreg > branch and post v2. That would be perfect as you are rerolling anyway. Let's me be lazy and not do the merge ;) Thanks, Jonathan > > > > > }, > > > > .probe = bh1750_probe, > > > > -- > > > > 2.17.1 > > > >