From: Eduardo Valentin <edubezval@gmail.com>
To: Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>
Cc: Zhang Rui <rui.zhang@intel.com>, Eric Anholt <eric@anholt.net>,
Stefan Wahren <stefan.wahren@i2se.com>,
Markus Mayer <mmayer@broadcom.com>,
bcm-kernel-feedback-list@broadcom.com,
Heiko Stuebner <heiko@sntech.de>,
Thierry Reding <thierry.reding@gmail.com>,
Jonathan Hunter <jonathanh@nvidia.com>,
Keerthy <j-keerthy@ti.com>,
Masahiro Yamada <yamada.masahiro@socionext.com>,
Jun Nie <jun.nie@linaro.org>, Baoyou Xie <baoyou.xie@linaro.org>,
Shawn Guo <shawnguo@kernel.org>,
linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 01/17] thermal: add thermal_zone_device_toggle() helper
Date: Mon, 24 Sep 2018 09:46:53 -0700 [thread overview]
Message-ID: <20180924164651.GC4988@localhost.localdomain> (raw)
In-Reply-To: <20180917093401eucas1p1f1e0de762a88b1327ba229971996e5da~VJjFwrEK11702417024eucas1p1m@eucas1p1.samsung.com>
On Mon, Sep 17, 2018 at 11:33:59AM +0200, Bartlomiej Zolnierkiewicz wrote:
>
> On 09/14/2018 01:40 PM, Bartlomiej Zolnierkiewicz wrote:
>
> [...]
>
> >>> --- a/include/linux/thermal.h
> >>> +++ b/include/linux/thermal.h
> >>> @@ -467,6 +467,7 @@ struct thermal_cooling_device *
> >>> int thermal_zone_get_temp(struct thermal_zone_device *tz, int *temp);
> >>> int thermal_zone_get_slope(struct thermal_zone_device *tz);
> >>> int thermal_zone_get_offset(struct thermal_zone_device *tz);
> >>> +int thermal_zone_device_toggle(struct thermal_zone_device *tz, bool on);
> >>>
> >>
> >> You missed the #else section of the #if IS_ENABLED(CONFIG_THERMAL),
> >> didn't you?
> >
> > No, this function shouldn't be used outside of CONFIG_THERMAL.
>
> Please disregard my previous comment. I see now that the CONFIG_THERMAL=n
> stub is needed and I will add it in the next patch revision.
Thanks Bartolomiej for keeping this up.
>
> Best regards,
> --
> Bartlomiej Zolnierkiewicz
> Samsung R&D Institute Poland
> Samsung Electronics
next prev parent reply other threads:[~2018-09-24 16:47 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CGME20180410124240epcas2p25c8979583c41f147ac34c49faf30aa14@epcas2p2.samsung.com>
2018-04-10 12:41 ` [PATCH 00/17] thermal: enable/check sensor after its setup is finished Bartlomiej Zolnierkiewicz
2018-04-10 12:41 ` [PATCH 01/17] thermal: add thermal_zone_device_toggle() helper Bartlomiej Zolnierkiewicz
2018-09-10 17:16 ` Eduardo Valentin
2018-09-14 11:40 ` Bartlomiej Zolnierkiewicz
[not found] ` <0495124b-9ae8-3b4b-5f0c-208d2e06e5a5@samsung.com>
2018-09-17 9:33 ` Bartlomiej Zolnierkiewicz
2018-09-24 16:46 ` Eduardo Valentin [this message]
2018-04-10 12:41 ` [PATCH 02/17] thermal: separate sensor registration and enable Bartlomiej Zolnierkiewicz
2018-04-10 12:41 ` [PATCH 03/17] thermal: add thermal_zone_device_check() helper Bartlomiej Zolnierkiewicz
2018-04-10 12:41 ` [PATCH 04/17] thermal: do sensor checking explicitly in drivers Bartlomiej Zolnierkiewicz
2018-04-10 12:41 ` [PATCH 05/17] thermal: bcm2835: enable/check sensor after its setup is finished Bartlomiej Zolnierkiewicz
2018-04-10 12:42 ` [PATCH 06/17] thermal: brcmstb: " Bartlomiej Zolnierkiewicz
2018-04-10 12:42 ` [PATCH 07/17] thermal: hisi_thermal: " Bartlomiej Zolnierkiewicz
2018-04-10 12:42 ` [PATCH 08/17] thermal: qcom: tsens: " Bartlomiej Zolnierkiewicz
2018-04-10 12:42 ` [PATCH 09/17] thermal: qoriq: " Bartlomiej Zolnierkiewicz
2018-04-10 12:42 ` [PATCH 10/17] thermal: rcar_gen3_thermal: " Bartlomiej Zolnierkiewicz
2018-04-10 12:42 ` [PATCH 11/17] thermal: rockchip_thermal: " Bartlomiej Zolnierkiewicz
2018-04-10 12:42 ` [PATCH 12/17] thermal: exynos: " Bartlomiej Zolnierkiewicz
2018-04-10 12:42 ` [PATCH 13/17] thermal: tegra: " Bartlomiej Zolnierkiewicz
2018-04-10 12:42 ` [PATCH 14/17] thermal: ti-soc-thermal: " Bartlomiej Zolnierkiewicz
2018-04-10 12:42 ` [PATCH 15/17] thermal: uniphier: " Bartlomiej Zolnierkiewicz
2018-04-10 12:42 ` [PATCH 16/17] thermal: zx2967: " Bartlomiej Zolnierkiewicz
2018-04-10 12:42 ` [PATCH 17/17] thermal: warn on attempts to read temperature on disabled sensors Bartlomiej Zolnierkiewicz
2018-04-18 22:26 ` [PATCH 00/17] thermal: enable/check sensor after its setup is finished Stefan Wahren
2018-06-29 16:15 ` Bartlomiej Zolnierkiewicz
2018-09-07 9:10 ` Amit Kucheria
2018-09-10 17:37 ` Eduardo Valentin
2018-09-14 13:17 ` Bartlomiej Zolnierkiewicz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180924164651.GC4988@localhost.localdomain \
--to=edubezval@gmail.com \
--cc=b.zolnierkie@samsung.com \
--cc=baoyou.xie@linaro.org \
--cc=bcm-kernel-feedback-list@broadcom.com \
--cc=eric@anholt.net \
--cc=heiko@sntech.de \
--cc=j-keerthy@ti.com \
--cc=jonathanh@nvidia.com \
--cc=jun.nie@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=mmayer@broadcom.com \
--cc=rui.zhang@intel.com \
--cc=shawnguo@kernel.org \
--cc=stefan.wahren@i2se.com \
--cc=thierry.reding@gmail.com \
--cc=yamada.masahiro@socionext.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox