From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3109BC43382 for ; Tue, 25 Sep 2018 09:58:40 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id DBDA220C0A for ; Tue, 25 Sep 2018 09:58:39 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org DBDA220C0A Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=bootlin.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728374AbeIYQFY (ORCPT ); Tue, 25 Sep 2018 12:05:24 -0400 Received: from mail.bootlin.com ([62.4.15.54]:36614 "EHLO mail.bootlin.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726201AbeIYQFX (ORCPT ); Tue, 25 Sep 2018 12:05:23 -0400 Received: by mail.bootlin.com (Postfix, from userid 110) id 5631F20731; Tue, 25 Sep 2018 11:58:35 +0200 (CEST) Received: from bbrezillon (AAubervilliers-681-1-42-80.w90-88.abo.wanadoo.fr [90.88.160.80]) by mail.bootlin.com (Postfix) with ESMTPSA id 8CED7203DA; Tue, 25 Sep 2018 11:58:24 +0200 (CEST) Date: Tue, 25 Sep 2018 11:58:23 +0200 From: Boris Brezillon To: Geert Uytterhoeven Cc: Mark Brown , David Woodhouse , Brian Norris , Marek Vasut , Richard Weinberger , linux-spi@vger.kernel.org, linux-mtd@lists.infradead.org, linux-renesas-soc@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] spi: spi-mem: Fix inverted logic in op sanity check Message-ID: <20180925115823.3dd07cda@bbrezillon> In-Reply-To: <20180925094655.11438-1-geert+renesas@glider.be> References: <20180925094655.11438-1-geert+renesas@glider.be> X-Mailer: Claws Mail 3.15.0-dirty (GTK+ 2.24.31; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 25 Sep 2018 11:46:55 +0200 Geert Uytterhoeven wrote: > On r8a7791/koelsch: > > m25p80 spi0.0: error -22 reading 9f > m25p80: probe of spi0.0 failed with error -22 > > Apparently the logic in spi_mem_check_op() is wrong, rejecting the > spi-mem operation if any buswidth is valid, instead of invalid. > > Fixes: 380583227c0c7f52 ("spi: spi-mem: Add extra sanity checks on the op param") > Signed-off-by: Geert Uytterhoeven Reviewed-by: Boris Brezillon Sorry for the mess :-/, and thanks for reporting/fixing it. > --- > drivers/spi/spi-mem.c | 8 ++++---- > 1 file changed, 4 insertions(+), 4 deletions(-) > > diff --git a/drivers/spi/spi-mem.c b/drivers/spi/spi-mem.c > index cc3d425aae56c634..62a7b80801d22098 100644 > --- a/drivers/spi/spi-mem.c > +++ b/drivers/spi/spi-mem.c > @@ -169,10 +169,10 @@ static int spi_mem_check_op(const struct spi_mem_op *op) > (op->data.nbytes && !op->data.buswidth)) > return -EINVAL; > > - if (spi_mem_buswidth_is_valid(op->cmd.buswidth) || > - spi_mem_buswidth_is_valid(op->addr.buswidth) || > - spi_mem_buswidth_is_valid(op->dummy.buswidth) || > - spi_mem_buswidth_is_valid(op->data.buswidth)) > + if (!spi_mem_buswidth_is_valid(op->cmd.buswidth) || > + !spi_mem_buswidth_is_valid(op->addr.buswidth) || > + !spi_mem_buswidth_is_valid(op->dummy.buswidth) || > + !spi_mem_buswidth_is_valid(op->data.buswidth)) > return -EINVAL; > > return 0;