Re: [GIT PULL] Char/Misc driver fixes for 4.19-rc6

gregkh
2018-09-25T15:56:45Z

On Tue, Sep 25, 2018 at 05:31:03PM +0200, Arnd Bergmann wrote:
> On Tue, Sep 25, 2018 at 4:54 PM Greg KH <gregkh@linuxfoundation.org> wrote:
> >
> > On Tue, Sep 25, 2018 at 04:23:44PM +0200, Greg KH wrote:
> > > [Yes, the oddity of sending a pull request to myself is not lost on me...]
> >
> > And, I totally messed this up. Ugh, what kind of idiot does something
> > like this! It's not like I haven't been doing this for years! I should
> > know better...
>
> Ah, I was wondering about that. I even found the char-misc-4.19-rc6 tag,
> but it didn't add up. If you want the signoff chain to make more sense,
> you can add my
>
> Reviewed-by: Arnd Bergmann <arnd@arndb.de>
>
> when you pull in your own tag. The resource handling in
> drivers/hwtracing/intel_th/core.c does look a bit odd, which
> confused me for a bit, but that was already the case before
> the patches.

Thanks for the review. Yeah, that code is "odd" but then again, all of
the hwtracing code is strange :)

I've already pulled this tag into Linus's tree, I though I would be
passive-aggressive and not tell myself that it was done...

thanks,

greg "this is strange" k-h