From: Greg KH <gregkh@linuxfoundation.org>
To: Tong Zhang <ztong@vt.edu>
Cc: tglx@linutronix.de, akpm@linux-foundation.org,
linux@dominikbrodowski.net, gorcunov@openvz.org,
ebiederm@xmission.com, keescook@chromium.org,
Dave.Martin@arm.com, wolffhardt.schwabe@fau.de,
yang.shi@linux.alibaba.com, linux-kernel@vger.kernel.org,
wenbo.s@samsung.com
Subject: Re: different capability from different namespace required for prctl_set_mm_exe_file
Date: Tue, 25 Sep 2018 19:37:45 +0200 [thread overview]
Message-ID: <20180925173745.GA20508@kroah.com> (raw)
In-Reply-To: <990D0DB4-35C7-4B7B-A938-2B984CD97E78@vt.edu>
On Tue, Sep 25, 2018 at 01:26:55PM -0400, Tong Zhang wrote:
> Kernel Version: 4.18.5
>
> Problem Description:
>
> We discovered inconsistent check when using prctl_set_mm_exe_file(), which is used to setup exe file link.
>
> It is required to have capable(CAP_SYS_RESOURCE) in prctl_set_mm().
> while ns_capable(CAP_SYS_ADMIN) in prctl_set_mm_map().
>
> There are two differences:
> 1)requiring capability from: user namespace, init namespace.
> 2)capability bit required is different
Can you submit a patch showing what you think is the correct fix here?
thanks,
greg k-h
next prev parent reply other threads:[~2018-09-25 17:37 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-09-25 17:26 different capability from different namespace required for prctl_set_mm_exe_file Tong Zhang
2018-09-25 17:37 ` Greg KH [this message]
2018-09-25 18:34 ` Cyrill Gorcunov
2018-09-25 18:40 ` Greg KH
2018-09-25 18:54 ` Cyrill Gorcunov
2018-09-25 23:37 ` TongZhang
2018-09-26 6:59 ` Cyrill Gorcunov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180925173745.GA20508@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=Dave.Martin@arm.com \
--cc=akpm@linux-foundation.org \
--cc=ebiederm@xmission.com \
--cc=gorcunov@openvz.org \
--cc=keescook@chromium.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@dominikbrodowski.net \
--cc=tglx@linutronix.de \
--cc=wenbo.s@samsung.com \
--cc=wolffhardt.schwabe@fau.de \
--cc=yang.shi@linux.alibaba.com \
--cc=ztong@vt.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox