From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.3 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_PASS,USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 90E4DC43382 for ; Tue, 25 Sep 2018 17:37:51 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 4A23320676 for ; Tue, 25 Sep 2018 17:37:51 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 4A23320676 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=linuxfoundation.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727112AbeIYXqW (ORCPT ); Tue, 25 Sep 2018 19:46:22 -0400 Received: from mail.linuxfoundation.org ([140.211.169.12]:49646 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726163AbeIYXqW (ORCPT ); Tue, 25 Sep 2018 19:46:22 -0400 Received: from localhost (ip-213-127-77-73.ip.prioritytelecom.net [213.127.77.73]) by mail.linuxfoundation.org (Postfix) with ESMTPSA id C9F52FA2; Tue, 25 Sep 2018 17:37:47 +0000 (UTC) Date: Tue, 25 Sep 2018 19:37:45 +0200 From: Greg KH To: Tong Zhang Cc: tglx@linutronix.de, akpm@linux-foundation.org, linux@dominikbrodowski.net, gorcunov@openvz.org, ebiederm@xmission.com, keescook@chromium.org, Dave.Martin@arm.com, wolffhardt.schwabe@fau.de, yang.shi@linux.alibaba.com, linux-kernel@vger.kernel.org, wenbo.s@samsung.com Subject: Re: different capability from different namespace required for prctl_set_mm_exe_file Message-ID: <20180925173745.GA20508@kroah.com> References: <990D0DB4-35C7-4B7B-A938-2B984CD97E78@vt.edu> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <990D0DB4-35C7-4B7B-A938-2B984CD97E78@vt.edu> User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Sep 25, 2018 at 01:26:55PM -0400, Tong Zhang wrote: > Kernel Version: 4.18.5 > > Problem Description: > > We discovered inconsistent check when using prctl_set_mm_exe_file(), which is used to setup exe file link. > > It is required to have capable(CAP_SYS_RESOURCE) in prctl_set_mm(). > while ns_capable(CAP_SYS_ADMIN) in prctl_set_mm_map(). > > There are two differences: > 1)requiring capability from: user namespace, init namespace. > 2)capability bit required is different Can you submit a patch showing what you think is the correct fix here? thanks, greg k-h