Re: [PATCH v5 1/2] dt-bindings: hwmon: Add ina3221 documentation

Nicolin Chen
2018-09-27T18:40:01Z

On Thu, Sep 27, 2018 at 12:44:13PM -0500, Rob Herring wrote:
> > +2) child nodes
> > + Required properties:
> > + - reg: Must be 0, 1 or 2, corresponding to IN1, IN2 or IN3 port of INA3221
> > +
> > + Optional properties:
> > + - label: Name of the input source
> > + - shunt-resistor-micro-ohms: Shunt resistor value in micro-Ohm
> > + - status: Should be "disabled" if no input source
>
> Don't need to explicitly list status.

Will remove in v6.

> > +
> > + Example:
> > +
> > + input@0 {
> > + reg = <0x0>;
> > + status = "disabled";
> > + };
> > + input@1 {
> > + reg = <0x1>;
> > + shunt-resistor-micro-ohms = <5000>;
> > + };
> > + input@2 {
> > + reg = <0x2>;
> > + label = "VDD_5V";
> > + shunt-resistor-micro-ohms = <5000>;
> > + };
>
> Please combine the examples into one complete example.

Will merge them in v6.

Thank you
Nicolin