From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.3 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_PASS,USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2A7DEC43382 for ; Wed, 26 Sep 2018 13:18:53 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id E301D20842 for ; Wed, 26 Sep 2018 13:18:52 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org E301D20842 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=suse.de Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728508AbeIZTbp (ORCPT ); Wed, 26 Sep 2018 15:31:45 -0400 Received: from mx2.suse.de ([195.135.220.15]:57702 "EHLO mx1.suse.de" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1726768AbeIZTbp (ORCPT ); Wed, 26 Sep 2018 15:31:45 -0400 X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay1.suse.de (unknown [195.135.220.254]) by mx1.suse.de (Postfix) with ESMTP id 239C9AD6D; Wed, 26 Sep 2018 13:18:49 +0000 (UTC) Date: Wed, 26 Sep 2018 15:18:56 +0200 From: Borislav Petkov To: "Lendacky, Thomas" Cc: Baoquan He , Kairui Song , "Singh, Brijesh" , "x86@kernel.org" , "kexec@lists.infradead.org" , "linux-kernel@vger.kernel.org" , "mingo@redhat.com" , "hpa@zytor.com" , "tglx@linutronix.de" , "dyoung@redhat.com" Subject: Re: [PATCH] x86/boot: Fix kexec booting failure after SEV early boot support Message-ID: <20180926131856.GD6920@zn.tnic> References: <20180925111020.23834-1-kasong@redhat.com> <6e15796e-31e9-2dc6-4a31-5c1b01554b45@amd.com> <20180925172608.GB15464@zn.tnic> <20180926073252.GC2555@MiWiFi-R3L-srv> <20180926112208.GE2555@MiWiFi-R3L-srv> <3b41fee3-e2f6-2e36-d2ca-1074c5f62bb8@amd.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <3b41fee3-e2f6-2e36-d2ca-1074c5f62bb8@amd.com> User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Sep 26, 2018 at 01:01:00PM +0000, Lendacky, Thomas wrote: > No concern from me. The original version of the patch did not cache the > value, that was added based on the patch series feedback. So, if there > is no concern about executing some extra CPUID/RDMSR instructions, then > it would certainly simplify the code quite a bit. Yeah, I think it was me who suggested to cache it but having simpler code greatly outweighs the minute caching win. -- Regards/Gruss, Boris. SUSE Linux GmbH, GF: Felix Imendörffer, Jane Smithard, Graham Norton, HRB 21284 (AG Nürnberg)