From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 05083C43382 for ; Wed, 26 Sep 2018 13:58:30 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id B1928208E4 for ; Wed, 26 Sep 2018 13:58:29 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=kdab.com header.i=@kdab.com header.b="tz6WAN3H" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org B1928208E4 Authentication-Results: mail.kernel.org; dmarc=fail (p=quarantine dis=none) header.from=kdab.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727794AbeIZULc (ORCPT ); Wed, 26 Sep 2018 16:11:32 -0400 Received: from mail.kdab.com ([176.9.126.58]:32809 "EHLO mail.kdab.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726937AbeIZULb (ORCPT ); Wed, 26 Sep 2018 16:11:31 -0400 Authentication-Results: mail.kdab.com (amavisd-new); dkim=pass (1024-bit key) reason="pass (just generated, assumed good)" header.d=kdab.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kdab.com; h= content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:date:subject:subject:from:from; s=dkim; t= 1537969948; x=1538833949; bh=t0RSj1dZ3Vpus0qZrJ98PkU62Z/n/7Ee9CI cI4Ablbw=; b=tz6WAN3Hm7/v0cjj3nGM/ph1zjnWWDg7QNmEYfc5ExRbenTj4Ha EkUWTq2k7KlMb1AfCXOWyD2lPqRDg7UbtHioXEGKUTvf0ybUcoqtW9QslioOd0tM b40xpTYeZEAIFBc+ZWZX+hdPL3KSzi3IBpZX5XXBkapQu1cYj7wbTmwQ= X-Virus-Scanned: amavisd-new at kdab.com From: Milian Wolff To: acme@kernel.org, jolsa@kernel.org, yao.jin@linux.intel.com, namhyung@kernel.org Cc: Linux-kernel@vger.kernel.org, linux-perf-users@vger.kernel.org, Milian Wolff Subject: [PATCH 3/3] perf report: don't crash on invalid inline debug information Date: Wed, 26 Sep 2018 15:52:07 +0200 Message-Id: <20180926135207.30263-3-milian.wolff@kdab.com> In-Reply-To: <20180926135207.30263-1-milian.wolff@kdab.com> References: <20180926135207.30263-1-milian.wolff@kdab.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org When the function name for an inline frame is invalid, we must not try to demangle this symbol, otherwise we crash with: #0 0x0000555555895c01 in bfd_demangle () #1 0x0000555555823262 in demangle_sym (dso=3D0x555555d92b90, elf_name=3D= 0x0, kmodule=3D0) at util/symbol-elf.c:215 #2 dso__demangle_sym (dso=3Ddso@entry=3D0x555555d92b90, kmodule=3D, kmodule@entry=3D0, elf_name=3Delf_name@entry=3D0x0) at util/sy= mbol-elf.c:400 #3 0x00005555557fef4b in new_inline_sym (funcname=3D0x0, base_sym=3D0x55= 5555d92b90, dso=3D0x555555d92b90) at util/srcline.c:89 #4 inline_list__append_dso_a2l (dso=3Ddso@entry=3D0x555555c7bb00, node=3D= node@entry=3D0x555555e31810, sym=3Dsym@entry=3D0x555555d92b90) at util/sr= cline.c:264 #5 0x00005555557ff27f in addr2line (dso_name=3Ddso_name@entry=3D0x555555= d92430 "/home/milian/.debug/.build-id/f7/186d14bb94f3c6161c010926da66033d= 24fce5/elf", addr=3Daddr@entry=3D2888, file=3Dfile@entry=3D0x0, line=3Dline@entry=3D0x0, dso=3Ddso@entry=3D0x555555c7bb00, unwind_inl= ines=3Dunwind_inlines@entry=3Dtrue, node=3D0x555555e31810, sym=3D0x555555= d92b90) at util/srcline.c:313 #6 0x00005555557ffe7c in addr2inlines (sym=3D0x555555d92b90, dso=3D0x555= 555c7bb00, addr=3D2888, dso_name=3D0x555555d92430 "/home/milian/.debug/.b= uild-id/f7/186d14bb94f3c6161c010926da66033d24fce5/elf") at util/srcline.c:358 So instead handle the case where we get invalid function names for inlined frames and use a fallback '??' function name instead. While this crash was originally reported by Hadrien for rust code, I can now also reproduce it with trivial C++ code. Indeed, it seems like libbfd fails to interpret the debug information for the inline frame symbol name: $ addr2line -e /home/milian/.debug/.build-id/f7/186d14bb94f3c6161c010926d= a66033d24fce5/elf -if b48 main /usr/include/c++/8.2.1/complex:610 ?? /usr/include/c++/8.2.1/complex:618 ?? /usr/include/c++/8.2.1/complex:675 ?? /usr/include/c++/8.2.1/complex:685 main /home/milian/projects/kdab/rnd/hotspot/tests/test-clients/cpp-inlining/ma= in.cpp:39 I've reported this bug upstream and also attached a patch there which should fix this issue: https://sourceware.org/bugzilla/show_bug.cgi?id=3D23715 Signed-off-by: Milian Wolff Cc: Arnaldo Carvalho de Melo Reported-by: Hadrien Grasland --- tools/perf/util/srcline.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/tools/perf/util/srcline.c b/tools/perf/util/srcline.c index 09d6746e6ec8..e767c4a9d4d2 100644 --- a/tools/perf/util/srcline.c +++ b/tools/perf/util/srcline.c @@ -85,6 +85,9 @@ static struct symbol *new_inline_sym(struct dso *dso, struct symbol *inline_sym; char *demangled =3D NULL; =20 + if (!funcname) + funcname =3D "??"; + if (dso) { demangled =3D dso__demangle_sym(dso, 0, funcname); if (demangled) --=20 2.19.0