From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_PASS,URIBL_BLOCKED,USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B5F76C43382 for ; Wed, 26 Sep 2018 15:01:50 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 78C1321508 for ; Wed, 26 Sep 2018 15:01:50 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 78C1321508 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=atomide.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727854AbeIZVPK (ORCPT ); Wed, 26 Sep 2018 17:15:10 -0400 Received: from muru.com ([72.249.23.125]:57324 "EHLO muru.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727132AbeIZVPK (ORCPT ); Wed, 26 Sep 2018 17:15:10 -0400 Received: from atomide.com (localhost [127.0.0.1]) by muru.com (Postfix) with ESMTPS id 8B0808120; Wed, 26 Sep 2018 15:06:09 +0000 (UTC) Date: Wed, 26 Sep 2018 08:01:45 -0700 From: Tony Lindgren To: Dan Murphy Cc: robh+dt@kernel.org, jacek.anaszewski@gmail.com, pavel@ucw.cz, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, lee.jones@linaro.org, linux-omap@vger.kernel.org, linux-leds@vger.kernel.org, Milo Kim , Sebastian Reichel Subject: Re: [RFC PATCH 1/9] leds: add TI LMU backlight driver Message-ID: <20180926150145.GS5662@atomide.com> References: <20180926130921.12329-1-dmurphy@ti.com> <20180926130921.12329-2-dmurphy@ti.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20180926130921.12329-2-dmurphy@ti.com> User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org * Dan Murphy [180926 13:14]: > --- /dev/null > +++ b/drivers/leds/ti-lmu-led-common.c > +static int ti_lmu_common_enable(struct ti_lmu_bank *lmu_bank, bool enable) > +{ > + struct regmap *regmap = lmu_bank->regmap; > + unsigned long enable_time = lmu_bank->enable_usec; > + u8 reg = lmu_bank->enable_reg; > + u8 mask = BIT(lmu_bank->bank_id); > + u8 val = (enable == true) ? mask : 0; > + int ret; > + > + return 0; Hmm this early return probably needs to be left out on real hardawre? > + if (!reg) > + return -EINVAL; > + > + ret = regmap_update_bits(regmap, reg, mask, val); > + if (ret) > + return ret; > + > + if (enable_time > 0) > + usleep_range(enable_time, enable_time + 100); > + > + return 0; > +} Regards, Tony