From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id DF0EDC43382 for ; Wed, 26 Sep 2018 13:23:46 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id A05D0214C5 for ; Wed, 26 Sep 2018 13:23:46 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org A05D0214C5 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=bootlin.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729034AbeIZTgk convert rfc822-to-8bit (ORCPT ); Wed, 26 Sep 2018 15:36:40 -0400 Received: from mail.bootlin.com ([62.4.15.54]:46935 "EHLO mail.bootlin.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727045AbeIZTgj (ORCPT ); Wed, 26 Sep 2018 15:36:39 -0400 Received: by mail.bootlin.com (Postfix, from userid 110) id 4A0F520720; Wed, 26 Sep 2018 15:23:40 +0200 (CEST) Received: from xps13 (AAubervilliers-681-1-42-80.w90-88.abo.wanadoo.fr [90.88.160.80]) by mail.bootlin.com (Postfix) with ESMTPSA id 06E31206DE; Wed, 26 Sep 2018 15:23:40 +0200 (CEST) Date: Wed, 26 Sep 2018 15:23:40 +0200 From: Miquel Raynal To: Arnd Bergmann Cc: Boris Brezillon , linux-mtd@lists.infradead.org, Aaro Koskinen , Tony Lindgren , Alexander Sverdlin , linux-omap@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 1/2] ARM: omap1: add nand_chip declaration Message-ID: <20180926152340.332b36e4@xps13> In-Reply-To: <20180926130458.2406549-1-arnd@arndb.de> References: <20180926130458.2406549-1-arnd@arndb.de> Organization: Bootlin X-Mailer: Claws Mail 3.16.0 (GTK+ 2.24.32; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8BIT Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Arnd, Thanks for the fix, sorry for breaking the build. Arnd Bergmann wrote on Wed, 26 Sep 2018 15:04:38 +0200: > Recent MTD changes caused a minor build regression on OMAP1: > > In file included from arch/arm/mach-omap1/devices.c:31: > arch/arm/mach-omap1/common.h:85:39: error: 'struct nand_chip' declared inside parameter list will not be visible outside of this definition or declaration [-Werror] > > Fixes: 1002aed789bc ("mtd: rawnand: plat_nand: Pass a nand_chip object to all platform_nand_ctrl hooks") > Signed-off-by: Arnd Bergmann > --- > arch/arm/mach-omap1/common.h | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/arch/arm/mach-omap1/common.h b/arch/arm/mach-omap1/common.h > index 11b87a4c84d4..82f2c065040a 100644 > --- a/arch/arm/mach-omap1/common.h > +++ b/arch/arm/mach-omap1/common.h > @@ -82,6 +82,7 @@ void omap1_restart(enum reboot_mode, const char *); > > extern void __init omap_check_revision(void); > > +struct nand_chip; > extern void omap1_nand_cmd_ctl(struct nand_chip *this, int cmd, > unsigned int ctrl); > Currently I see "#include " at the top of this file. That's where the "struct mtd_info" that has been replaced by a "struct nand_chip" was declared. The nand_chip object is declared in . I think you can remove this include (unneeded anymore for what I see). Then, either you keep the nand_chip forward declaration, or replace the mtd.h include into the rawnand.h one? Thanks, Miquèl