From: John Whitmore <johnfwhitmore@gmail.com>
To: linux-kernel@vger.kernel.org
Cc: devel@driverdev.osuosl.org, gregkh@linuxfoundation.org,
John Whitmore <johnfwhitmore@gmail.com>
Subject: [PATCH 00/13] staging:rtl8192u: Style & memory leak fix
Date: Wed, 26 Sep 2018 20:16:51 +0100 [thread overview]
Message-ID: <20180926191704.16322-1-johnfwhitmore@gmail.com> (raw)
Back again. I previously went through the struct ht_capability_ele
renaming member variables as being unused. At the time I wasn't
100% sure that the structure wasn't memory mapped, or used by
external callers to the module, through function pointers or exported
symbols. Having had a more detailed look over the code I'm happy
that these member variables are not used and have removed them from
the code.
The last patch is a potential memory leak, which only happens if two
memory allocations succeed and the third allocation fails. So it's
probably never going to happen, but fixed it anyhow.
I've tried to find this device, or a datasheet on it, so that I
could actually make sure it still worked but that's not been possible.
Apparently it's a discontinued device, but that possibly makes it a
safer sandbox to start messing with.
John Whitmore (13):
staging:rtl8192u: Remove HTHalfMcsToDataRate() - Style
staging:rtl8192u: Make HTMcsToDataRate static - Style
staging:rtl8192u: Remove definition of HTSetConnectBwMode - Style
staging:rtl8192u: Move HTSetConnectBwModeCallback() - Style
staging:rtl8192u: Remove AdvCoding and GreenField - Style
staging:rtl8192u: Remove TxSTBC and RxSTBC - Style
staging:rtl8192u: Remove DelayBA, PSMP and Rsvd1 - Style
staging:rtl8192u: Remove LSigTxopProtect - Style
staging:rtl8192u: Remove Rsvd2 - Style
staging:rtl8192u: Remove ExtHTCapInfo - Style
staging:rtl8192u: Remove TxBFCap - Style
staging:rtl8192u: Remove ASCap - Style
staging:rtl8192u: Remove potential memory leak
.../staging/rtl8192u/ieee80211/ieee80211.h | 3 -
.../rtl8192u/ieee80211/ieee80211_module.c | 5 +
.../staging/rtl8192u/ieee80211/rtl819x_HT.h | 20 +--
.../rtl8192u/ieee80211/rtl819x_HTProc.c | 123 ++++--------------
4 files changed, 30 insertions(+), 121 deletions(-)
--
2.18.0
next reply other threads:[~2018-09-26 19:17 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-09-26 19:16 John Whitmore [this message]
2018-09-26 19:16 ` [PATCH 01/13] staging:rtl8192u: Remove HTHalfMcsToDataRate() - Style John Whitmore
2018-09-26 19:16 ` [PATCH 02/13] staging:rtl8192u: Make HTMcsToDataRate static " John Whitmore
2018-09-26 19:16 ` [PATCH 03/13] staging:rtl8192u: Remove definition of HTSetConnectBwMode " John Whitmore
2018-09-26 19:16 ` [PATCH 04/13] staging:rtl8192u: Move HTSetConnectBwModeCallback() " John Whitmore
2018-09-26 19:16 ` [PATCH 05/13] staging:rtl8192u: Remove AdvCoding and GreenField " John Whitmore
2018-09-28 12:35 ` Greg KH
2018-09-28 22:38 ` John Whitmore
2018-09-28 14:31 ` Dan Carpenter
2018-09-28 22:32 ` John Whitmore
2018-09-26 19:16 ` [PATCH 06/13] staging:rtl8192u: Remove TxSTBC and RxSTBC " John Whitmore
2018-09-28 12:36 ` Greg KH
2018-09-28 14:32 ` Dan Carpenter
2018-09-26 19:16 ` [PATCH 07/13] staging:rtl8192u: Remove DelayBA, PSMP and Rsvd1 " John Whitmore
2018-09-28 14:33 ` Dan Carpenter
2018-09-26 19:16 ` [PATCH 08/13] staging:rtl8192u: Remove LSigTxopProtect " John Whitmore
2018-09-26 19:17 ` [PATCH 09/13] staging:rtl8192u: Remove Rsvd2 " John Whitmore
2018-09-26 19:17 ` [PATCH 10/13] staging:rtl8192u: Remove ExtHTCapInfo " John Whitmore
2018-09-26 19:17 ` [PATCH 11/13] staging:rtl8192u: Remove TxBFCap " John Whitmore
2018-09-26 19:17 ` [PATCH 12/13] staging:rtl8192u: Remove ASCap " John Whitmore
2018-09-26 19:17 ` [PATCH 13/13] staging:rtl8192u: Remove potential memory leak John Whitmore
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180926191704.16322-1-johnfwhitmore@gmail.com \
--to=johnfwhitmore@gmail.com \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox