Re: [PATCH V5 23/30] dt-bindings: interrupt-controller: C-SKY SMP intc

Rob Herring
2018-09-27T16:50:49Z

On Tue, Sep 25, 2018 at 07:39:26AM +0800, Guo Ren wrote:
> - Dt-bindings doc about C-SKY Multi-processors interrupt controller.
>
> Signed-off-by: Guo Ren <ren_guo@c-sky.com>
> ---
> .../bindings/interrupt-controller/csky,mpintc.txt | 40 ++++++++++++++++++++++
> 1 file changed, 40 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/interrupt-controller/csky,mpintc.txt
>
> diff --git a/Documentation/devicetree/bindings/interrupt-controller/csky,mpintc.txt b/Documentation/devicetree/bindings/interrupt-controller/csky,mpintc.txt
> new file mode 100644
> index 0000000..9cdad74
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/interrupt-controller/csky,mpintc.txt
> @@ -0,0 +1,40 @@
> +===========================================
> +C-SKY Multi-processors Interrupt Controller
> +===========================================
> +
> +C-SKY Multi-processors Interrupt Controller is designed for ck807/ck810/ck860
> +SMP soc, and it also could be used in non-SMP system.
> +
> +Interrupt number definition:
> +
> + 0-15 : software irq, and we use 15 as our IPI_IRQ.
> + 16-31 : private irq, and we use 16 as the co-processor timer.
> + 31-1024: common irq for soc ip.
> +
> +=============================
> +intc node bindings definition
> +=============================
> +
> + Description: Describes SMP interrupt controller
> +
> + PROPERTIES
> +
> + - compatible
> + Usage: required
> + Value type: <string>
> + Definition: must be "csky,mpintc"

Only 1 version?

This is fine for a fallback, but you should have an SoC specific
compatible too in case there are any SoC specific errata/quirks.

> + - interrupt-cells

Should be: #interrupt-cells

> + Usage: required
> + Value type: <u32>
> + Definition: must be <1>
> + - interrupt-controller:
> + Usage: required
> +
> +Examples:
> +---------
> +
> + intc: interrupt-controller {
> + compatible = "csky,mpintc";
> + #interrupt-cells = <1>;
> + interrupt-controller;
> + };
> --
> 2.7.4
>