Re: [PATCH v4 12/20] iommu/tegra: gart: Integrate with Memory Controller driver

Thierry Reding
2018-09-25T10:02:07Z

[-- Attachment #1: Type: text/plain, Size: 1412 bytes --]

On Mon, Sep 24, 2018 at 09:22:59PM +0300, Dmitry Osipenko wrote:
> On 9/24/18 1:23 PM, Thierry Reding wrote:
> > On Mon, Sep 24, 2018 at 03:41:45AM +0300, Dmitry Osipenko wrote:
> >> The device-tree binding has been changed. There is no separate GART device
> >> anymore, it is squashed into the Memory Controller. Integrate GART module
> >> with the MC in a way it is done for the SMMU of Tegra30+.
> >>
> >> Signed-off-by: Dmitry Osipenko <digetx@gmail.com>
> >> ---
> >> drivers/iommu/Kconfig | 1 +
> >> drivers/iommu/tegra-gart.c | 98 ++++++++++----------------------------
> >> drivers/memory/tegra/mc.c | 41 ++++++++++++++++
> >> include/soc/tegra/mc.h | 27 +++++++++++
> >> 4 files changed, 93 insertions(+), 74 deletions(-)
> >
> > I think this could technically have been two patches, but since they'd
> > have a compile-time dependency either way they need to be applied in the
> > correct order, so some coordination between IOMMU and Tegra trees is
> > going to have to happen anyway and might as well just stick this into a
> > single patch.
>
> I assume that Joerg will take the whole series once it's ready (no?),
> hence your ACK will be needed here and in other patches.

Yeah, either Joerg takes them all with my Acked-by's or provides his for
the IOMMU bits and I take the batch through the Tegra tree. I don't have
a strong preference.

Thierry

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]