Re: [PATCH v4 16/20] iommu/tegra: gart: Don't use managed resources

Dmitry Osipenko
2018-09-24T18:57:16Z

On 9/24/18 1:52 PM, Thierry Reding wrote:
> On Mon, Sep 24, 2018 at 03:41:49AM +0300, Dmitry Osipenko wrote:
>> GART is a part of the Memory Controller driver that is always built-in,
>> hence there is no benefit from the use of managed resources.
>>
>> Signed-off-by: Dmitry Osipenko <digetx@gmail.com>
>> ---
>> drivers/iommu/tegra-gart.c | 12 +++++++-----
>> 1 file changed, 7 insertions(+), 5 deletions(-)
>
> One benefit would be cleanup on probe error. Also, we may eventually
> want to make even the memory controller driver buildable as a module.

Please, let's keep that patch as is and re-introduce devm once it will
become really relevant.