From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.1 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_PASS,USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id EBEB5C43382 for ; Fri, 28 Sep 2018 07:36:51 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 9DA9321746 for ; Fri, 28 Sep 2018 07:36:51 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="EZPsVZn/" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 9DA9321746 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729069AbeI1N7O (ORCPT ); Fri, 28 Sep 2018 09:59:14 -0400 Received: from mail-pg1-f193.google.com ([209.85.215.193]:45357 "EHLO mail-pg1-f193.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728804AbeI1N7O (ORCPT ); Fri, 28 Sep 2018 09:59:14 -0400 Received: by mail-pg1-f193.google.com with SMTP id t70-v6so3803231pgd.12 for ; Fri, 28 Sep 2018 00:36:49 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=Gp9w4xk/2ygmlptLb2U7Qz1G6agxATgiTwcn39pl2bU=; b=EZPsVZn/7B97VY4+iBRc1vV5dVtI5XE5oZOh6wyJHqWc7v7kUIKh9S7IrZHjK7fO4m TpCL9JXC5YsKtW9K1oBv0KdJ0Lvt0YUQMs1ZfFdADoltqIDtaWwFdbtiPRWs6DkifMhR v5f525cbUth2OSa8tyk2Twpcrcgh5C5mbhPL/TY1Oc2Sm6c9eFYJ5LPCa2mGvqUDd/J+ 9c3vlgjEc3KldywuE9xy+rbZMOIblAXpaUr7kk8twdbZJkzSXTEBm/eprA6+QJlcRYRb JpTCHHjXdgj82YLeR2d5Kc7b2MlaoRs+6NEmMhAgn8LZMMtHi9MF/DHsLRfDy3h9Lmt9 5Mqg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=Gp9w4xk/2ygmlptLb2U7Qz1G6agxATgiTwcn39pl2bU=; b=Sy8h6qqRsrUtvCyUZ7ob+TrnyCFAgAOJib5dLzlaEc2uUkrcb487i/ib4grVLjGS11 6fwiKfinmTCTMSsRdv3D0xBYTdLcUAxP1bkr6DcUFq3T/6ZKRASpAf3SvHSDmXVQChEp Z2bYrkQvoMz8Bua6xRcUzd7M0Fr3Bj4zZCHi/E/bzoG2DheCNt3lxZm/4bsbcqPQvU55 P1Zna6tgAPssiXg3+JpcqJkE0SCzz23biDDDRacZ+Zt8e/tdYQwRjAeJu7D9XXhftjMy y0zgxp6u6aMovli1zFDeNzeMpuT7/qe/teN6sctwbD9xRWwfRwuV0Xt/Ny8DhRuIEwq6 qO3Q== X-Gm-Message-State: ABuFfoiJI/9zLBiYLMY1YwBGcXGhPocRiYZG32RUJIYDxhqLew/2vrXT lDYNHt1nxWFSVAfetf1Cd5U= X-Google-Smtp-Source: ACcGV62+VdDM9CUaIi059ADWyhsSUpuICN6OMHFGmcJLbuYGCID1p1k0I34ACBYu9O2pmkfDyJGm+Q== X-Received: by 2002:a63:5a54:: with SMTP id k20-v6mr13988257pgm.297.1538120208808; Fri, 28 Sep 2018 00:36:48 -0700 (PDT) Received: from localhost ([110.70.14.151]) by smtp.gmail.com with ESMTPSA id o62-v6sm6297069pfb.0.2018.09.28.00.36.46 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Fri, 28 Sep 2018 00:36:47 -0700 (PDT) Date: Fri, 28 Sep 2018 16:36:44 +0900 From: Sergey Senozhatsky To: Petr Mladek Cc: Sergey Senozhatsky , Sergey Senozhatsky , Steven Rostedt , linux-kernel@vger.kernel.org Subject: Re: [PATCH] printk: CON_PRINTBUFFER console registration is a bit racy Message-ID: <20180928073644.GB1160@jagdpanzerIV> References: <20180914023428.814-1-sergey.senozhatsky@gmail.com> <20180914085934.m2bgixltdzpfh62o@pathway.suse.cz> <20180914111953.GA20572@tigerII.localdomain> <20180926113715.6llme2vmvynzuoa3@pathway.suse.cz> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20180926113715.6llme2vmvynzuoa3@pathway.suse.cz> User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On (09/26/18 13:37), Petr Mladek wrote: > /* > * Set exclusive_console still with disabled interrupts to > * reduce race window with eventual console_flush_on_panic() > * that ignores console_lock. > */ Looks good to me. > I am not against the change. It makes some sense and it does > not break anything. It is just not obvious OK. Thanks. Will send v2. -ss