From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.2 required=3.0 tests=DATE_IN_PAST_03_06, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_PASS,USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 781D8C43382 for ; Fri, 28 Sep 2018 16:20:00 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 1EA4020676 for ; Fri, 28 Sep 2018 16:20:00 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 1EA4020676 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=linuxfoundation.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729499AbeI1Wo1 (ORCPT ); Fri, 28 Sep 2018 18:44:27 -0400 Received: from mail.linuxfoundation.org ([140.211.169.12]:58094 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726121AbeI1Wo1 (ORCPT ); Fri, 28 Sep 2018 18:44:27 -0400 Received: from localhost (unknown [88.128.83.59]) by mail.linuxfoundation.org (Postfix) with ESMTPSA id 64F30D85; Fri, 28 Sep 2018 16:19:54 +0000 (UTC) Date: Fri, 28 Sep 2018 14:30:25 +0200 From: Greg Kroah-Hartman To: Nishad Kamdar Cc: Joe Perches , devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org, NeilBrown , Christian =?iso-8859-1?Q?L=FCtke-Stetzkamp?= , Dan Carpenter , John Crispin Subject: Re: [PATCH v3] staging: mt7621-mmc: Remove #if 0 blocks and fix macros in sd.c Message-ID: <20180928123025.GA26516@kroah.com> References: <20180927154053.GA3526@nishad> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20180927154053.GA3526@nishad> User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Sep 27, 2018 at 09:10:57PM +0530, Nishad Kamdar wrote: > This patch removes #if 0 code blocks and usages of the > functions defined in the #if 0 code block. It removes > the macro msdc_irq_restore() and replaces its usage > with call to the function called in the macro definition. > Issue found by checkpatch. When you have to start listing all of the different things your patch does, that's a huge hint it needs to be broken up into smaller pieces. Please make this a patch series, only doing on "logical" change at a time. You are doing too many different things here all at once. thanks greg k-h