* [PATCH] drivers: irqchip: pdc: setup all edge interrupts as rising edge at GIC
@ 2018-09-27 17:18 Lina Iyer
2018-09-27 18:04 ` Evan Green
2018-09-28 10:40 ` Marc Zyngier
0 siblings, 2 replies; 4+ messages in thread
From: Lina Iyer @ 2018-09-27 17:18 UTC (permalink / raw)
To: evgreen, marc.zyngier
Cc: bjorn.andersson, rplsssn, linux-kernel, linux-arm-msm, rnayak,
andy.gross, sboyd, dianders, Lina Iyer
The PDC irqchp can convert a falling edge or level low interrupt to a
rising edge or level high interrupt at the GIC. We just need to setup
the GIC correctly. Set up the interrupt type for the IRQ_TYPE_EDGE_BOTH
as IRQ_TYPE_EDGE_RISING at the GIC.
Reported-by: Evan Green <evgreen@chromium.org>
Signed-off-by: Lina Iyer <ilina@codeaurora.org>
---
drivers/irqchip/qcom-pdc.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/irqchip/qcom-pdc.c b/drivers/irqchip/qcom-pdc.c
index b1b47a40a278..faa7d61b9d6c 100644
--- a/drivers/irqchip/qcom-pdc.c
+++ b/drivers/irqchip/qcom-pdc.c
@@ -124,6 +124,7 @@ static int qcom_pdc_gic_set_type(struct irq_data *d, unsigned int type)
break;
case IRQ_TYPE_EDGE_BOTH:
pdc_type = PDC_EDGE_DUAL;
+ type = IRQ_TYPE_EDGE_RISING;
break;
case IRQ_TYPE_LEVEL_HIGH:
pdc_type = PDC_LEVEL_HIGH;
--
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum,
a Linux Foundation Collaborative Project
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] drivers: irqchip: pdc: setup all edge interrupts as rising edge at GIC
2018-09-27 17:18 [PATCH] drivers: irqchip: pdc: setup all edge interrupts as rising edge at GIC Lina Iyer
@ 2018-09-27 18:04 ` Evan Green
2018-09-28 10:40 ` Marc Zyngier
1 sibling, 0 replies; 4+ messages in thread
From: Evan Green @ 2018-09-27 18:04 UTC (permalink / raw)
To: Lina Iyer
Cc: marc.zyngier, Bjorn Andersson, rplsssn, linux-kernel,
linux-arm-msm, Rajendra Nayak, Andy Gross, sboyd, Doug Anderson
On Thu, Sep 27, 2018 at 10:18 AM Lina Iyer <ilina@codeaurora.org> wrote:
>
> The PDC irqchp can convert a falling edge or level low interrupt to a
> rising edge or level high interrupt at the GIC. We just need to setup
> the GIC correctly. Set up the interrupt type for the IRQ_TYPE_EDGE_BOTH
> as IRQ_TYPE_EDGE_RISING at the GIC.
>
> Reported-by: Evan Green <evgreen@chromium.org>
> Signed-off-by: Lina Iyer <ilina@codeaurora.org>
> ---
> drivers/irqchip/qcom-pdc.c | 1 +
> 1 file changed, 1 insertion(+)
>
Reviewed-by: Evan Green <evgreen@chromium.org>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] drivers: irqchip: pdc: setup all edge interrupts as rising edge at GIC
2018-09-27 17:18 [PATCH] drivers: irqchip: pdc: setup all edge interrupts as rising edge at GIC Lina Iyer
2018-09-27 18:04 ` Evan Green
@ 2018-09-28 10:40 ` Marc Zyngier
2018-09-28 14:57 ` Lina Iyer
1 sibling, 1 reply; 4+ messages in thread
From: Marc Zyngier @ 2018-09-28 10:40 UTC (permalink / raw)
To: Lina Iyer, evgreen
Cc: bjorn.andersson, rplsssn, linux-kernel, linux-arm-msm, rnayak,
andy.gross, sboyd, dianders
On 27/09/18 18:18, Lina Iyer wrote:
> The PDC irqchp can convert a falling edge or level low interrupt to a
> rising edge or level high interrupt at the GIC. We just need to setup
> the GIC correctly. Set up the interrupt type for the IRQ_TYPE_EDGE_BOTH
> as IRQ_TYPE_EDGE_RISING at the GIC.
>
> Reported-by: Evan Green <evgreen@chromium.org>
> Signed-off-by: Lina Iyer <ilina@codeaurora.org>
> ---
> drivers/irqchip/qcom-pdc.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/irqchip/qcom-pdc.c b/drivers/irqchip/qcom-pdc.c
> index b1b47a40a278..faa7d61b9d6c 100644
> --- a/drivers/irqchip/qcom-pdc.c
> +++ b/drivers/irqchip/qcom-pdc.c
> @@ -124,6 +124,7 @@ static int qcom_pdc_gic_set_type(struct irq_data *d, unsigned int type)
> break;
> case IRQ_TYPE_EDGE_BOTH:
> pdc_type = PDC_EDGE_DUAL;
> + type = IRQ_TYPE_EDGE_RISING;
> break;
> case IRQ_TYPE_LEVEL_HIGH:
> pdc_type = PDC_LEVEL_HIGH;
>
Queued for 4.20, with
Fixes: f55c73aef890 ("irqchip/pdc: Add PDC interrupt controller for QCOM
SoCs")
added. Please consider providing these tags in the future.
Thanks,
M.
--
Jazz is not dead. It just smells funny...
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH] drivers: irqchip: pdc: setup all edge interrupts as rising edge at GIC
2018-09-28 10:40 ` Marc Zyngier
@ 2018-09-28 14:57 ` Lina Iyer
0 siblings, 0 replies; 4+ messages in thread
From: Lina Iyer @ 2018-09-28 14:57 UTC (permalink / raw)
To: Marc Zyngier
Cc: evgreen, bjorn.andersson, rplsssn, linux-kernel, linux-arm-msm,
rnayak, andy.gross, sboyd, dianders
On Fri, Sep 28 2018 at 04:40 -0600, Marc Zyngier wrote:
>On 27/09/18 18:18, Lina Iyer wrote:
>>The PDC irqchp can convert a falling edge or level low interrupt to a
>>rising edge or level high interrupt at the GIC. We just need to setup
>>the GIC correctly. Set up the interrupt type for the IRQ_TYPE_EDGE_BOTH
>>as IRQ_TYPE_EDGE_RISING at the GIC.
>>
>>Reported-by: Evan Green <evgreen@chromium.org>
>>Signed-off-by: Lina Iyer <ilina@codeaurora.org>
>>---
>> drivers/irqchip/qcom-pdc.c | 1 +
>> 1 file changed, 1 insertion(+)
>>
>>diff --git a/drivers/irqchip/qcom-pdc.c b/drivers/irqchip/qcom-pdc.c
>>index b1b47a40a278..faa7d61b9d6c 100644
>>--- a/drivers/irqchip/qcom-pdc.c
>>+++ b/drivers/irqchip/qcom-pdc.c
>>@@ -124,6 +124,7 @@ static int qcom_pdc_gic_set_type(struct irq_data *d, unsigned int type)
>> break;
>> case IRQ_TYPE_EDGE_BOTH:
>> pdc_type = PDC_EDGE_DUAL;
>>+ type = IRQ_TYPE_EDGE_RISING;
>> break;
>> case IRQ_TYPE_LEVEL_HIGH:
>> pdc_type = PDC_LEVEL_HIGH;
>>
>
>Queued for 4.20, with
>
>Fixes: f55c73aef890 ("irqchip/pdc: Add PDC interrupt controller for
>QCOM SoCs")
>
>added. Please consider providing these tags in the future.
Thanks Marc. Will do.
-- Lina
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2018-09-28 14:57 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2018-09-27 17:18 [PATCH] drivers: irqchip: pdc: setup all edge interrupts as rising edge at GIC Lina Iyer
2018-09-27 18:04 ` Evan Green
2018-09-28 10:40 ` Marc Zyngier
2018-09-28 14:57 ` Lina Iyer
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox