From: Nishad Kamdar <nishadkamdar@gmail.com>
To: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: NeilBrown <neil@brown.name>, "Joe Perches" <joe@perches.com>,
devel@driverdev.osuosl.org,
"Christian Lütke-Stetzkamp" <christian@lkamp.de>,
linux-kernel@vger.kernel.org, "John Crispin" <blogic@openwrt.org>,
"Dan Carpenter" <dan.carpenter@oracle.com>
Subject: Re: [PATCH v3] staging: mt7621-mmc: Remove #if 0 blocks and fix macros in sd.c
Date: Sat, 29 Sep 2018 19:02:43 +0530 [thread overview]
Message-ID: <20180929031708.GA4120@nishad> (raw)
In-Reply-To: <20180928123025.GA26516@kroah.com>
On Fri, Sep 28, 2018 at 02:30:25PM +0200, Greg Kroah-Hartman wrote:
> On Thu, Sep 27, 2018 at 09:10:57PM +0530, Nishad Kamdar wrote:
> > This patch removes #if 0 code blocks and usages of the
> > functions defined in the #if 0 code block. It removes
> > the macro msdc_irq_restore() and replaces its usage
> > with call to the function called in the macro definition.
> > Issue found by checkpatch.
>
> When you have to start listing all of the different things your patch
> does, that's a huge hint it needs to be broken up into smaller pieces.
>
> Please make this a patch series, only doing on "logical" change at a
> time. You are doing too many different things here all at once.
>
> thanks
>
> greg k-h
Ok I'll do that.
thanks for the review.
regards,
nishad
prev parent reply other threads:[~2018-09-29 13:32 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-09-27 15:40 [PATCH v3] staging: mt7621-mmc: Remove #if 0 blocks and fix macros in sd.c Nishad Kamdar
2018-09-28 12:30 ` Greg Kroah-Hartman
2018-09-29 13:32 ` Nishad Kamdar [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180929031708.GA4120@nishad \
--to=nishadkamdar@gmail.com \
--cc=blogic@openwrt.org \
--cc=christian@lkamp.de \
--cc=dan.carpenter@oracle.com \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@linuxfoundation.org \
--cc=joe@perches.com \
--cc=linux-kernel@vger.kernel.org \
--cc=neil@brown.name \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox