From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.1 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_PASS,USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id EF7B4C43143 for ; Mon, 1 Oct 2018 07:57:09 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id B232D2083C for ; Mon, 1 Oct 2018 07:57:09 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=ffwll.ch header.i=@ffwll.ch header.b="g/KQ1cHx" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org B232D2083C Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=ffwll.ch Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728916AbeJAOdf (ORCPT ); Mon, 1 Oct 2018 10:33:35 -0400 Received: from mail-ed1-f68.google.com ([209.85.208.68]:36668 "EHLO mail-ed1-f68.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728593AbeJAOde (ORCPT ); Mon, 1 Oct 2018 10:33:34 -0400 Received: by mail-ed1-f68.google.com with SMTP id f4-v6so13302322edq.3 for ; Mon, 01 Oct 2018 00:57:05 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ffwll.ch; s=google; h=sender:date:from:to:cc:subject:message-id:mail-followup-to :references:mime-version:content-disposition:in-reply-to:user-agent; bh=0EOCEfWM1hghz/pIrzuHE/X1qiT0VXb8KGWngxiycJc=; b=g/KQ1cHxNivR5ZWPM7I6JUa1qxxJUIGSrnv4hPlK1pBaBnzFnYlURpecX5dBble4Lx aqcxA660OdNOB+x1drsT/vdmObsARxbY1Lx+QnVgLax4yoRH6E1K5dAQN76uRto21OnY aPbiosddnklUgeOF6jCcW3myuL12YXKmEPEmY= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:date:from:to:cc:subject:message-id :mail-followup-to:references:mime-version:content-disposition :in-reply-to:user-agent; bh=0EOCEfWM1hghz/pIrzuHE/X1qiT0VXb8KGWngxiycJc=; b=BdBnQcaGN0nKP2DXcmgDWwbcsb2FN8EhhC3noKM0QlL7ux6+hDUazShavMwFRphgRB 98tOC3o//8fVx7N5Olhzq2oynlte5aX+CHHlJH44Np7w4zLjrzdo/rEhP0ReMzsovFTd wHMUhh9f7vmYdy0I8r1PJ5I0TDm7wpAmvnI44ajVk8kCeOQ9JcyHmu+Z7MDszkxNiB0m QkqnQL/lu+RHjxHdNPtiOBJ/OkQoNITyIyl5C+IaSTGskEFXQ79/tjsHF/PPrXZzkBCK yDaMiLx0xIfnmKZVqUS6WboC/qHsAf6SvMQOPNsiqLR3tStx88olnyw+sCx4sbrIbdkc ctwQ== X-Gm-Message-State: ABuFfoicfkGizZCOT7IBeI2ETNReOUXicZWn8HMYKvW5jB/l05UUd6cM qPnOtfacTbUS1skOnck+x+8MJ+FnIxe/AQ== X-Google-Smtp-Source: ACcGV60IurSusARTjO9Lez908WbukkBCLTndh1sPVC14SQUZArpQRAuFLz6WzwLk0+bXkchfsiaoEw== X-Received: by 2002:aa7:d707:: with SMTP id t7-v6mr16791955edq.250.1538380625231; Mon, 01 Oct 2018 00:57:05 -0700 (PDT) Received: from phenom.ffwll.local ([2a02:168:569e:0:3106:d637:d723:e855]) by smtp.gmail.com with ESMTPSA id d13-v6sm1753208eda.51.2018.10.01.00.57.04 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Mon, 01 Oct 2018 00:57:04 -0700 (PDT) Date: Mon, 1 Oct 2018 09:57:02 +0200 From: Daniel Vetter To: Stefan Agner Cc: alison.wang@nxp.com, airlied@linux.ie, Madhur Verma , dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, Hemanshu Srivastava , Satendra Singh Thakur Subject: Re: [PATCH 2/2] drm/fsl-dcu: use drm_display_mode_to_videomode to calculate timing parameters Message-ID: <20181001075702.GS11082@phenom.ffwll.local> Mail-Followup-To: Stefan Agner , alison.wang@nxp.com, airlied@linux.ie, Madhur Verma , dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, Hemanshu Srivastava , Satendra Singh Thakur References: <20180926204150.29829-1-stefan@agner.ch> <20180926204150.29829-2-stefan@agner.ch> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20180926204150.29829-2-stefan@agner.ch> X-Operating-System: Linux phenom 4.14.0-1-amd64 User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Sep 26, 2018 at 10:41:50PM +0200, Stefan Agner wrote: > From: Satendra Singh Thakur > > Use the drm_display_mode_to_videomode function to calculate front/ > back porches and sync length. > > Cc: Madhur Verma > Cc: Hemanshu Srivastava > Signed-off-by: Satendra Singh Thakur > Signed-off-by: Stefan Agner I think if lots of people want this (iirc yours not the only driver that wants front/back-porch) we should extend the computed crtc_* fields with this. Kinda silly we force people to go through v4l videomode in drm drivers. But then, this gets the job done, so maybe an idea for todo.rst? On both patches: Acked-by: Daniel Vetter > --- > drivers/gpu/drm/fsl-dcu/fsl_dcu_drm_crtc.c | 32 ++++++++++------------ > 1 file changed, 14 insertions(+), 18 deletions(-) > > diff --git a/drivers/gpu/drm/fsl-dcu/fsl_dcu_drm_crtc.c b/drivers/gpu/drm/fsl-dcu/fsl_dcu_drm_crtc.c > index 05d1c9977395..18afc94e4dff 100644 > --- a/drivers/gpu/drm/fsl-dcu/fsl_dcu_drm_crtc.c > +++ b/drivers/gpu/drm/fsl-dcu/fsl_dcu_drm_crtc.c > @@ -17,6 +17,7 @@ > #include > #include > #include > +#include