From: Daniel Vetter <daniel@ffwll.ch>
To: Eugeniy Paltsev <Eugeniy.Paltsev@synopsys.com>
Cc: dri-devel@lists.freedesktop.org,
"David Airlie" <airlied@linux.ie>,
"Alexey Brodkin" <alexey.brodkin@synopsys.com>,
linux-kernel@vger.kernel.org, stable@vger.kernel.org,
"Stéphane Marchesin" <marcheu@chromium.org>,
linux-snps-arc@lists.infradead.org, "Sean Paul" <sean@poorly.run>
Subject: Re: [PATCH] DRM: UDL: get rid of useless vblank initialization
Date: Mon, 1 Oct 2018 10:14:08 +0200 [thread overview]
Message-ID: <20181001081408.GV11082@phenom.ffwll.local> (raw)
In-Reply-To: <20180928144126.21598-1-Eugeniy.Paltsev@synopsys.com>
On Fri, Sep 28, 2018 at 05:41:26PM +0300, Eugeniy Paltsev wrote:
> UDL doesn't support vblank functionality so we don't need to
> initialize vblank here (we are able to send page flip
> completion events even without vblank initialization)
>
> Moreover current drm_vblank_init call with num_crtcs > 0 causes
> sending DRM_EVENT_FLIP_COMPLETE event with zero timestamp every
> time. This breaks userspace apps (for example weston) which
> relies on timestamp value.
>
> Cc: stable@vger.kernel.org
> Signed-off-by: Eugeniy Paltsev <Eugeniy.Paltsev@synopsys.com>
Reviewed-by: Daniel Vetter <daniel.vetter@ffwll.ch>
> ---
> drivers/gpu/drm/udl/udl_main.c | 7 +------
> 1 file changed, 1 insertion(+), 6 deletions(-)
>
> diff --git a/drivers/gpu/drm/udl/udl_main.c b/drivers/gpu/drm/udl/udl_main.c
> index f455f095a146..1b014d92855b 100644
> --- a/drivers/gpu/drm/udl/udl_main.c
> +++ b/drivers/gpu/drm/udl/udl_main.c
> @@ -350,15 +350,10 @@ int udl_driver_load(struct drm_device *dev, unsigned long flags)
> if (ret)
> goto err;
>
> - ret = drm_vblank_init(dev, 1);
> - if (ret)
> - goto err_fb;
> -
> drm_kms_helper_poll_init(dev);
>
> return 0;
> -err_fb:
> - udl_fbdev_cleanup(dev);
> +
> err:
> if (udl->urbs.count)
> udl_free_urb_list(dev);
> --
> 2.14.4
>
> _______________________________________________
> dri-devel mailing list
> dri-devel@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/dri-devel
--
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch
next prev parent reply other threads:[~2018-10-01 8:14 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-09-28 14:41 [PATCH] DRM: UDL: get rid of useless vblank initialization Eugeniy Paltsev
2018-10-01 8:14 ` Daniel Vetter [this message]
2018-10-23 11:01 ` Eugeniy Paltsev
2018-10-23 13:42 ` Daniel Vetter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181001081408.GV11082@phenom.ffwll.local \
--to=daniel@ffwll.ch \
--cc=Eugeniy.Paltsev@synopsys.com \
--cc=airlied@linux.ie \
--cc=alexey.brodkin@synopsys.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-snps-arc@lists.infradead.org \
--cc=marcheu@chromium.org \
--cc=sean@poorly.run \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox