From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_PASS,URIBL_BLOCKED,USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E029AC43143 for ; Mon, 1 Oct 2018 16:14:27 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 98A932089A for ; Mon, 1 Oct 2018 16:14:27 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 98A932089A Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linux.intel.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726217AbeJAWw6 (ORCPT ); Mon, 1 Oct 2018 18:52:58 -0400 Received: from mga03.intel.com ([134.134.136.65]:14288 "EHLO mga03.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725777AbeJAWw5 (ORCPT ); Mon, 1 Oct 2018 18:52:57 -0400 X-Amp-Result: UNSCANNABLE X-Amp-File-Uploaded: False Received: from fmsmga003.fm.intel.com ([10.253.24.29]) by orsmga103.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 01 Oct 2018 09:14:24 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.54,328,1534834800"; d="scan'208";a="84843705" Received: from smile.fi.intel.com (HELO smile) ([10.237.72.86]) by FMSMGA003.fm.intel.com with ESMTP; 01 Oct 2018 09:09:03 -0700 Received: from andy by smile with local (Exim 4.91) (envelope-from ) id 1g70kn-0005AM-Qz; Mon, 01 Oct 2018 19:09:01 +0300 Date: Mon, 1 Oct 2018 19:09:01 +0300 From: Andy Shevchenko To: Bartosz Golaszewski Cc: Greg Kroah-Hartman , "Rafael J . Wysocki" , Jassi Brar , Thierry Reding , Jonathan Hunter , Arnd Bergmann , Geert Uytterhoeven , Rasmus Villemoes , linux-kernel@vger.kernel.org, linux-tegra@vger.kernel.org, linux-arch@vger.kernel.org, linux-mm@kvack.org Subject: Re: [PATCH v6 0/4] devres: provide and use devm_kstrdup_const() Message-ID: <20181001160901.GY15943@smile.fi.intel.com> References: <20180930202615.12951-1-brgl@bgdev.pl> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20180930202615.12951-1-brgl@bgdev.pl> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sun, Sep 30, 2018 at 10:26:11PM +0200, Bartosz Golaszewski wrote: > This series implements devm_kstrdup_const() together with some > prerequisite changes and uses it in tegra-hsp driver. Thanks! For the first three, Reviewed-by: Andy Shevchenko > > v1 -> v2: > - fixed the changelog in the patch implementing devm_kstrdup_const() > - fixed the kernel doc > - moved is_kernel_rodata() to asm-generic/sections.h > - fixed constness > > v2 -> v3: > - rebased on top of 4.19-rc5 as there were some conflicts in the > pmc-atom driver > - collected Reviewed-by tags > > v3 -> v4: > - Andy NAK'ed patch 4/4 so I added a different example > - collected more tags > > v4 -> v5: > - instead of providing devm_kfree_const(), make devm_kfree() check if > given pointer is not in .rodata and act accordingly > > v5 -> v6: > - fixed the commit message in patch 2/4 (s/devm_kfree_const/devm_kfree/) > - collected even more tags > > Bartosz Golaszewski (4): > devres: constify p in devm_kfree() > mm: move is_kernel_rodata() to asm-generic/sections.h > devres: provide devm_kstrdup_const() > mailbox: tegra-hsp: use devm_kstrdup_const() > > drivers/base/devres.c | 36 +++++++++++++++++++++++++++-- > drivers/mailbox/tegra-hsp.c | 41 ++++++++-------------------------- > include/asm-generic/sections.h | 14 ++++++++++++ > include/linux/device.h | 4 +++- > mm/util.c | 7 ------ > 5 files changed, 60 insertions(+), 42 deletions(-) > > -- > 2.18.0 > -- With Best Regards, Andy Shevchenko