From: Tony Lindgren <tony@atomide.com>
To: Guenter Roeck <linux@roeck-us.net>
Cc: Phil Edworthy <phil.edworthy@renesas.com>,
Greg KH <gregkh@linuxfoundation.org>,
linux-kernel@vger.kernel.org,
Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Subject: Re: [PATCH] serial: 8250_dw: Fix runtime PM handling
Date: Mon, 1 Oct 2018 10:23:57 -0700 [thread overview]
Message-ID: <20181001172356.GX5662@atomide.com> (raw)
In-Reply-To: <20180928224056.GA10486@roeck-us.net>
* Guenter Roeck <linux@roeck-us.net> [180928 22:45]:
> On Thu, May 10, 2018 at 03:13:56PM +0100, Phil Edworthy wrote:
> > When using kgdb, you get an abort when accessing the UART registers.
> > This is because the driver has already entered runtime PM and so turned
> > off the bus clock needed to access the registers.
> >
> > To fix this, set the capability indicating Runtime PM is active while idle.
> >
>
> With this patch applied, I get the already reported traceback [1].
> Obviously neither the promised revert [2] nor the presumed fix [3] made it
> into the mainline Kernel.
>
> Greg, can you please revert this patch ? If people don't care enough
> to fix the problem, we should at least not have to suffer the consequences.
Yes please revert until things are fixed.
FYI, what Andy and I discussed earlier is that we can disable
runtime PM for serial layer by taking a PM runtime use count
on the serial driver if there is an active console but we need
a way to attach/detach kernel serial consoel via /sys to prevent
regressions with PM.
So how do we attach/detach kernel serial console? We don't seem
to have a way to attach/detach a kernel console to a UART via
/sys do we? Or am I again 10 years behind or something?
We have /sys/class/vtconsole to bind and unbind a frame
buffer console though.
Andy, do you have your updated patches available somewhere?
Regards,
Tony
> [1] https://www.spinics.net/lists/linux-serial/msg30379.html
> [2] https://www.spinics.net/lists/linux-serial/msg30380.html
> [3] https://www.spinics.net/lists/linux-serial/msg30757.html
next prev parent reply other threads:[~2018-10-01 17:24 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-09-28 22:40 [PATCH] serial: 8250_dw: Fix runtime PM handling Guenter Roeck
2018-10-01 17:23 ` Tony Lindgren [this message]
-- strict thread matches above, loose matches on Subject: below --
2018-05-10 14:13 Phil Edworthy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181001172356.GX5662@atomide.com \
--to=tony@atomide.com \
--cc=andriy.shevchenko@linux.intel.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=phil.edworthy@renesas.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox