public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: "Luck, Tony" <tony.luck@intel.com>
To: Borislav Petkov <bp@alien8.de>
Cc: Mauro Carvalho Chehab <mchehab+samsung@kernel.org>,
	Russ Anderson <rja@hpe.com>, Greg KH <gregkh@linuxfoundation.org>,
	Justin Ernst <justin.ernst@hpe.com>,
	russ.anderson@hpe.com, Mauro Carvalho Chehab <mchehab@kernel.org>,
	linux-edac@vger.kernel.org, linux-kernel@vger.kernel.org,
	Aristeu Rozanski Filho <arozansk@redhat.com>
Subject: [PATCH] EDAC: Don't add devices under /sys/bus/edac
Date: Mon, 1 Oct 2018 15:43:13 -0700	[thread overview]
Message-ID: <20181001224313.GA9487@agluck-desk> (raw)
In-Reply-To: <20181001124754.GD7269@zn.tnic>

Nobody(*) uses them.  Dropping this will allow us to make the total
number of memory controllers configurable (as we won't have to
worry about duplicated device names under this directory).

(*) https://marc.info/?l=linux-edac&m=153809709903987&w=2

Signed-off-by: Tony Luck <tony.luck@intel.com>
---

Boris: Apply this, then your earlier patch to get rid of the
hard coded limit on the number of memory controllers:
  https://marc.info/?l=linux-edac&m=153797567628947&w=2
the combination works on my 4 socket machine. Perhaps HPE
can test on their superdome.

 drivers/edac/edac_mc_sysfs.c | 3 ---
 1 file changed, 3 deletions(-)

diff --git a/drivers/edac/edac_mc_sysfs.c b/drivers/edac/edac_mc_sysfs.c
index 20374b8248f0..4c1bee59c2e6 100644
--- a/drivers/edac/edac_mc_sysfs.c
+++ b/drivers/edac/edac_mc_sysfs.c
@@ -405,7 +405,6 @@ static int edac_create_csrow_object(struct mem_ctl_info *mci,
 				    struct csrow_info *csrow, int index)
 {
 	csrow->dev.type = &csrow_attr_type;
-	csrow->dev.bus = mci->bus;
 	csrow->dev.groups = csrow_dev_groups;
 	device_initialize(&csrow->dev);
 	csrow->dev.parent = &mci->dev;
@@ -636,7 +635,6 @@ static int edac_create_dimm_object(struct mem_ctl_info *mci,
 	dimm->mci = mci;
 
 	dimm->dev.type = &dimm_attr_type;
-	dimm->dev.bus = mci->bus;
 	device_initialize(&dimm->dev);
 
 	dimm->dev.parent = &mci->dev;
@@ -940,7 +938,6 @@ int edac_create_sysfs_mci_device(struct mem_ctl_info *mci,
 	device_initialize(&mci->dev);
 
 	mci->dev.parent = mci_pdev;
-	mci->dev.bus = mci->bus;
 	mci->dev.groups = groups;
 	dev_set_name(&mci->dev, "mc%d", mci->mc_idx);
 	dev_set_drvdata(&mci->dev, mci);
-- 
2.17.1


  reply	other threads:[~2018-10-01 22:43 UTC|newest]

Thread overview: 28+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-09-25 14:34 [PATCH] Raise maximum number of memory controllers Justin Ernst
2018-09-25 15:26 ` Borislav Petkov
2018-09-25 17:50   ` Luck, Tony
2018-09-25 18:07     ` Borislav Petkov
2018-09-26  9:35       ` Borislav Petkov
2018-09-26 15:27         ` Borislav Petkov
2018-09-26 16:03           ` Mauro Carvalho Chehab
2018-09-26 16:17             ` Borislav Petkov
2018-09-26 17:39               ` Mauro Carvalho Chehab
2018-09-26 18:10               ` Luck, Tony
2018-09-26 18:23                 ` Russ Anderson
2018-09-26 23:02                   ` Luck, Tony
2018-09-27  4:52                     ` Borislav Petkov
2018-09-27 21:44                       ` Luck, Tony
2018-09-27 22:03                         ` Borislav Petkov
2018-09-28  1:10                           ` Mauro Carvalho Chehab
2018-10-01 12:47                             ` Borislav Petkov
2018-10-01 22:43                               ` Luck, Tony [this message]
2018-10-02  1:22                                 ` [PATCH] EDAC: Don't add devices under /sys/bus/edac Mauro Carvalho Chehab
2018-10-02 15:51                                   ` Ernst, Justin
2018-10-02 16:26                                     ` Borislav Petkov
2018-11-06 14:45                                       ` Borislav Petkov
2018-11-13 19:09                                         ` Ernst, Justin
2018-11-13 19:15                                           ` Borislav Petkov
2018-09-26  7:55 ` [PATCH] Raise maximum number of memory controllers Zhuo, Qiuxu
2018-09-26 13:53   ` Russ Anderson
2018-09-26 16:13 ` Aristeu Rozanski
2018-09-27  5:56 ` Borislav Petkov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20181001224313.GA9487@agluck-desk \
    --to=tony.luck@intel.com \
    --cc=arozansk@redhat.com \
    --cc=bp@alien8.de \
    --cc=gregkh@linuxfoundation.org \
    --cc=justin.ernst@hpe.com \
    --cc=linux-edac@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mchehab+samsung@kernel.org \
    --cc=mchehab@kernel.org \
    --cc=rja@hpe.com \
    --cc=russ.anderson@hpe.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox