From: Charles Keepax <ckeepax@opensource.cirrus.com>
To: Richard Fitzgerald <rf@opensource.cirrus.com>
Cc: <lee.jones@linaro.org>, <patches@opensource.cirrus.com>,
<linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v2 1/2] mfd: madera: Increase wait time for silicon reset
Date: Tue, 2 Oct 2018 11:55:48 +0100 [thread overview]
Message-ID: <20181002105548.GR1653@imbe.wolfsonmicro.main> (raw)
In-Reply-To: <20181002104134.29003-1-rf@opensource.cirrus.com>
On Tue, Oct 02, 2018 at 11:41:33AM +0100, Richard Fitzgerald wrote:
> Based on latest silicon validation, we should allow at least
> 2 milliseconds after DCVDD enable or hard reset before trying
> to communicate with the silicon.
>
> Previously the delay was done as a side-effect of
> madera_disable_hard_reset(). As we also need this delay when
> enabling DCVDD (with or without hard reset) it is better for it
> to be obvious where it happens in every power-up sequence rather
> than hidden within another call in some cases. So it has been
> moved out into a separate function call.
>
> Signed-off-by: Richard Fitzgerald <rf@opensource.cirrus.com>
> ---
Reviewed-by: Charles Keepax <ckeepax@opensource.cirrus.com>
Thanks,
Charles
prev parent reply other threads:[~2018-10-02 10:55 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-10-02 10:41 [PATCH v2 1/2] mfd: madera: Increase wait time for silicon reset Richard Fitzgerald
2018-10-02 10:41 ` [PATCH v2 2/2] mfd: madera: Wait for BOOT_DONE before reading device ID Richard Fitzgerald
2018-10-02 10:56 ` Charles Keepax
2018-10-02 10:55 ` Charles Keepax [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181002105548.GR1653@imbe.wolfsonmicro.main \
--to=ckeepax@opensource.cirrus.com \
--cc=lee.jones@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=patches@opensource.cirrus.com \
--cc=rf@opensource.cirrus.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox