Re: [GIT PULL] parisc fixes for kernel v4.19

Greg Kroah-Hartman
2018-10-03T18:16:15Z

Adding Arnd as he wrote the patch in question here...

On Wed, Oct 03, 2018 at 04:47:30PM +0200, Helge Deller wrote:
> On 03.10.2018 00:24, Greg Kroah-Hartman wrote:
> > On Tue, Oct 02, 2018 at 11:46:11PM +0200, Helge Deller wrote:
> >> Hi Greg,
> >>
> >> On 02.10.2018 23:16, Greg Kroah-Hartman wrote:
> >>> On Tue, Oct 02, 2018 at 11:02:13PM +0200, Helge Deller wrote:
> >>>> please pull a last set of fixes for the parisc architecture for kernel 4.19 from:
> >>>>
> >>>> git://git.kernel.org/pub/scm/linux/kernel/git/deller/parisc-linux.git parisc-4.19-3
> >>>>
> >>>> The major change is for parisc64 to use a 64-bit suseconds_t type to
> >>>> match what glibc expects for 64-bit userspace. It's an ABI change, but
> >>>> since we don't have a 64-bit userspace on parisc yet, it won't introduce
> >>>> a breakage.
> >>>
> >>> Isn't it a bit "late" in the release cycle for such a change? Why not
> >>> do this on the -rc1 release?
> >>
> >> I've tagged it for stable release.
> >> So, it can go in now, or just wait until -rc1 and go in later.
> >
> > Why is a major API change a viable stable change?
>
> Of course it's not.
> Esp. not if an API has been used already.
> IMHO, this case is really different though...
>
> > What bugfix does it provide?
>
> It fixes that code in stable kernels which would return wrong
> time values *if* someone would create a libc for 64-bit parisc
> and would run it with those "stable" kernels.
> Fixing it now has no side-effects, the change is a trivial
> 2-line-removal patch, would bring the code in sync with
> newer kernel source code, and it really fixes existing code.
>
> I still believe that this justifies for a backport.
>
> Nevertheless, if you really disagree, I'm fine dropping the
> backport to stable and will only push it in the next
> merge window for v4.20.

To clarify, you have no users of this api anywhere (hopefully), and so
the patch in question prevents anyone from using the api in the future.
This makes the suseconds_t handling easier for some reason because only
sparc32 is a "problem" now, right?

So I don't see the "bug" that is being fixed here. I would have pushed
back on the submission for this for the stable trees as well, this isn't
anything that anyone is using, so there's nothing to "fix" that I can
tell.

Yes, doing it in the "future" is fine, to prevent anyone from making
this mistake (are new machines even being made for this arch?) But I
don't see how this is a -stable issue.

In this series, only the first patch, would seem to be a real fix, but
even that one isn't. You are just using a #define for a magic number,
one that will never change either way (the define will never change.) So
that too isn't really a fix, just a code cleanup.

So I am strongly inclined to just not take any of these right now.

thanks,

greg k-h