From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.3 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_PASS,USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 95BD8C64EBC for ; Tue, 2 Oct 2018 22:24:56 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 4EF8120666 for ; Tue, 2 Oct 2018 22:24:56 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 4EF8120666 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=linuxfoundation.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726806AbeJCFKa (ORCPT ); Wed, 3 Oct 2018 01:10:30 -0400 Received: from mail.linuxfoundation.org ([140.211.169.12]:49642 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725976AbeJCFK3 (ORCPT ); Wed, 3 Oct 2018 01:10:29 -0400 Received: from localhost (unknown [64.124.202.226]) by mail.linuxfoundation.org (Postfix) with ESMTPSA id D5719AF0; Tue, 2 Oct 2018 22:24:53 +0000 (UTC) Date: Tue, 2 Oct 2018 15:24:52 -0700 From: Greg Kroah-Hartman To: Helge Deller Cc: Linus Torvalds , linux-kernel@vger.kernel.org, linux-parisc@vger.kernel.org, James Bottomley , John David Anglin Subject: Re: [GIT PULL] parisc fixes for kernel v4.19 Message-ID: <20181002222452.GB11788@kroah.com> References: <20181002210213.GA17826@ls3530.fritz.box> <20181002211645.GA6454@kroah.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Oct 02, 2018 at 11:46:11PM +0200, Helge Deller wrote: > Hi Greg, > > On 02.10.2018 23:16, Greg Kroah-Hartman wrote: > > On Tue, Oct 02, 2018 at 11:02:13PM +0200, Helge Deller wrote: > >> please pull a last set of fixes for the parisc architecture for kernel 4.19 from: > >> > >> git://git.kernel.org/pub/scm/linux/kernel/git/deller/parisc-linux.git parisc-4.19-3 > >> > >> The major change is for parisc64 to use a 64-bit suseconds_t type to > >> match what glibc expects for 64-bit userspace. It's an ABI change, but > >> since we don't have a 64-bit userspace on parisc yet, it won't introduce > >> a breakage. > > > > Isn't it a bit "late" in the release cycle for such a change? Why not > > do this on the -rc1 release? > > I've tagged it for stable release. > So, it can go in now, or just wait until -rc1 and go in later. Why is a major API change a viable stable change? What bugfix does it provide? > >> Other than that we simply drop unused code and outdated gcc version > >> checks. > > > > Why are those needed now? > > The patch in there which is by me changes one line simply cleans up a patch which > went in during the 4.19 merge cycle. So it would be nice to have it > added now before v4.19 gets released. > The other two patches are trivial and just remove dead code. > I rate them all as non-critical, but nice-to-have-in-v4.19. > > If you disagree I'm absolutely fine to wait with all of them > for the next merge window. Normally I only let "bugfixes" into my trees at this point in time. cleanups always wait for the next -rc1 merge window as that's what it is there for. So I'd recommend waiting as well. I'm more "worried" about the api change listed above. thanks, greg k-h