From: Ingo Molnar <mingo@kernel.org>
To: Tim Chen <tim.c.chen@linux.intel.com>
Cc: Jiri Kosina <jikos@kernel.org>,
Thomas Gleixner <tglx@linutronix.de>,
Tom Lendacky <thomas.lendacky@amd.com>,
Ingo Molnar <mingo@redhat.com>,
Peter Zijlstra <peterz@infradead.org>,
Josh Poimboeuf <jpoimboe@redhat.com>,
Andrea Arcangeli <aarcange@redhat.com>,
David Woodhouse <dwmw@amazon.co.uk>,
Andi Kleen <ak@linux.intel.com>,
Dave Hansen <dave.hansen@intel.com>,
Casey Schaufler <casey.schaufler@intel.com>,
Asit Mallick <asit.k.mallick@intel.com>,
Arjan van de Ven <arjan@linux.intel.com>,
Jon Masters <jcm@redhat.com>,
linux-kernel@vger.kernel.org, x86@kernel.org
Subject: Re: [Patch v2 4/4] x86/speculation: Add prctl to control indirect branch speculation per process
Date: Wed, 3 Oct 2018 09:25:28 +0200 [thread overview]
Message-ID: <20181003072528.GA98965@gmail.com> (raw)
In-Reply-To: <20a42fd4-0026-c30e-1d82-4a345f6257cc@linux.intel.com>
* Tim Chen <tim.c.chen@linux.intel.com> wrote:
> Thanks for the corrections. I'll update the patchset.
Please also go beyond the direct review feedback me and Thomas gave, and pro-actively look out
for similar patterns of mistakes in these patches and in all future patches you send.
As Thomas's and my review made it abundantly clear, this patch series has a very high
proportion of small, indefensible trivial quality problems.
If the root of the problem is that you are sending out patches too fast then please *read* your
own code and changelogs more than once before sending it to lkml, fix trivial mistakes and
coding style so that others don't have to waste time over trivialities.
If the root of the problem is that you don't have enough time to spend on these patches then
you should perhaps delay your next series for another day or two, use more time to review the
series, before sending it for an upstream merge.
I.e. please make a serious effort to improve patch and changelog quality in the future.
Thanks,
Ingo
next prev parent reply other threads:[~2018-10-03 7:25 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-09-26 0:43 [Patch v2 0/4] Provide options to enable spectre_v2 userspace-userspace protection Tim Chen
2018-09-26 0:43 ` [Patch v2 1/4] x86/speculation: Option to select app to app mitigation for spectre_v2 Tim Chen
2018-10-02 9:23 ` Ingo Molnar
2018-10-02 16:24 ` Tim Chen
2018-10-02 20:04 ` Thomas Gleixner
2018-09-26 0:43 ` [Patch v2 2/4] x86/speculation: Provide application property based STIBP protection Tim Chen
2018-10-02 19:10 ` Thomas Gleixner
2018-10-04 19:19 ` Tim Chen
2018-09-26 0:43 ` [Patch v2 3/4] x86/speculation: Extend per process STIBP to AMD cpus Tim Chen
2018-09-26 17:24 ` Tim Chen
2018-09-26 19:11 ` Lendacky, Thomas
2018-10-02 9:27 ` Ingo Molnar
2018-10-02 19:02 ` Thomas Gleixner
2018-09-26 0:43 ` [Patch v2 4/4] x86/speculation: Add prctl to control indirect branch speculation per process Tim Chen
2018-10-02 9:35 ` Ingo Molnar
2018-10-02 16:12 ` Tim Chen
2018-10-03 7:25 ` Ingo Molnar [this message]
2018-10-02 17:58 ` Thomas Gleixner
2018-10-05 18:12 ` Tim Chen
2018-10-05 18:46 ` Thomas Gleixner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181003072528.GA98965@gmail.com \
--to=mingo@kernel.org \
--cc=aarcange@redhat.com \
--cc=ak@linux.intel.com \
--cc=arjan@linux.intel.com \
--cc=asit.k.mallick@intel.com \
--cc=casey.schaufler@intel.com \
--cc=dave.hansen@intel.com \
--cc=dwmw@amazon.co.uk \
--cc=jcm@redhat.com \
--cc=jikos@kernel.org \
--cc=jpoimboe@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=peterz@infradead.org \
--cc=tglx@linutronix.de \
--cc=thomas.lendacky@amd.com \
--cc=tim.c.chen@linux.intel.com \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).