From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_PASS,URIBL_BLOCKED,USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 68FBAC00449 for ; Wed, 3 Oct 2018 15:51:10 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 130712098A for ; Wed, 3 Oct 2018 15:51:10 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 130712098A Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=iki.fi Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727537AbeJCWkF (ORCPT ); Wed, 3 Oct 2018 18:40:05 -0400 Received: from emh03.mail.saunalahti.fi ([62.142.5.109]:33180 "EHLO emh03.mail.saunalahti.fi" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726748AbeJCWkE (ORCPT ); Wed, 3 Oct 2018 18:40:04 -0400 Received: from ydin.reaktio.net (reaktio.net [85.76.255.15]) by emh03.mail.saunalahti.fi (Postfix) with ESMTP id 51560400A1; Wed, 3 Oct 2018 18:51:05 +0300 (EEST) Received: by ydin.reaktio.net (Postfix, from userid 1001) id D7CE236C0F6; Wed, 3 Oct 2018 18:51:04 +0300 (EEST) Date: Wed, 3 Oct 2018 18:51:04 +0300 From: Pasi =?iso-8859-1?Q?K=E4rkk=E4inen?= To: Roger Pau =?iso-8859-1?Q?Monn=E9?= Cc: Boris Ostrovsky , George Dunlap , Jan Beulich , Juergen Gross , "linux-pci@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "bhelgaas@google.com" , xen-devel , Konrad Rzeszutek Wilk Subject: Re: [Xen-devel] [PATCH V3 2/2] Xen/PCIback: Implement PCI flr/slot/bus reset with 'reset' SysFS attribute Message-ID: <20181003155104.GH5318@reaktio.net> References: <8a3bc517-1255-4547-d244-5c400e44cc77@Oracle.COM> <5A377E020200007800197FFA@prv-mh.provo.novell.com> <559ffd12-b541-8a69-60bd-fbe10e3dc159@oracle.com> <20180916114306.GF18222@reaktio.net> <20180918071519.GG18222@reaktio.net> <5E7DDB68-4E68-48A5-AEEC-EE1B21A50E9E@citrix.com> <352310b3-ec9b-2ceb-83f0-4550718120c3@oracle.com> <20180919090526.s3ahnemrt2ik2tx3@mac.bytemobile.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20180919090526.s3ahnemrt2ik2tx3@mac.bytemobile.com> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Sep 19, 2018 at 11:05:26AM +0200, Roger Pau Monné wrote: > On Tue, Sep 18, 2018 at 02:09:53PM -0400, Boris Ostrovsky wrote: > > On 9/18/18 5:32 AM, George Dunlap wrote: > > > > > >> On Sep 18, 2018, at 8:15 AM, Pasi Kärkkäinen wrote: > > >> > > >> Hi, > > >> > > >> On Mon, Sep 17, 2018 at 02:06:02PM -0400, Boris Ostrovsky wrote: > > >>> What about the toolstack changes? Have they been accepted? I vaguely > > >>> recall there was a discussion about those changes but don't remember how > > >>> it ended. > > >>> > > >> I don't think toolstack/libxl patch has been applied yet either. > > >> > > >> > > >> "[PATCH V1 0/1] Xen/Tools: PCI reset using 'reset' SysFS attribute": > > >> https://lists.xen.org/archives/html/xen-devel/2017-12/msg00664.html > > >> > > >> "[PATCH V1 1/1] Xen/libxl: Perform PCI reset using 'reset' SysFS attribute": > > >> https://lists.xen.org/archives/html/xen-devel/2017-12/msg00663.html > > > > > > Will this patch work for *BSD? Roger? > > At least FreeBSD don't support pci-passthrough, so none of this works > ATM. There's no sysfs on BSD, so much of what's in libxl_pci.c will > have to be moved to libxl_linux.c when BSD support is added. > Ok. That sounds like it's OK for the initial pci 'reset' implementation in xl/libxl to be linux-only.. Thanks, -- Pasi > Thanks, Roger.