From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id DFE89C64EB8 for ; Wed, 3 Oct 2018 21:27:07 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id ADFA021470 for ; Wed, 3 Oct 2018 21:27:07 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org ADFA021470 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=bootlin.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727188AbeJDERM (ORCPT ); Thu, 4 Oct 2018 00:17:12 -0400 Received: from mail.bootlin.com ([62.4.15.54]:49958 "EHLO mail.bootlin.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726182AbeJDERM (ORCPT ); Thu, 4 Oct 2018 00:17:12 -0400 Received: by mail.bootlin.com (Postfix, from userid 110) id 929362072B; Wed, 3 Oct 2018 23:27:02 +0200 (CEST) Received: from bbrezillon (91-160-177-164.subs.proxad.net [91.160.177.164]) by mail.bootlin.com (Postfix) with ESMTPSA id 4952C2072B; Wed, 3 Oct 2018 23:27:02 +0200 (CEST) Date: Wed, 3 Oct 2018 23:27:02 +0200 From: Boris Brezillon To: Ricardo Ribalda Delgado Cc: David Woodhouse , Brian Norris , Marek Vasut , Richard Weinberger , Zhouyang Jia , linux-mtd@lists.infradead.org, open list , devicetree@vger.kernel.org Subject: Re: [PATCH v5 7/8] dt-binding: mtd: Document gpio-addr-flash Message-ID: <20181003232702.4c18e725@bbrezillon> In-Reply-To: <20181003193859.23928-7-ricardo.ribalda@gmail.com> References: <20181003193859.23928-1-ricardo.ribalda@gmail.com> <20181003193859.23928-7-ricardo.ribalda@gmail.com> X-Mailer: Claws Mail 3.15.0-dirty (GTK+ 2.24.31; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, 3 Oct 2018 21:38:58 +0200 Ricardo Ribalda Delgado wrote: > Add documentation for gpio-addr-flash. This binding allow creating > flash devices that are paged using GPIOs. > > Cc: devicetree@vger.kernel.org > Reviewed-by: Rob Herring > Signed-off-by: Ricardo Ribalda Delgado > --- > .../bindings/mtd/gpio-addr-flash.txt | 54 +++++++++++++++++++ > 1 file changed, 54 insertions(+) > create mode 100644 Documentation/devicetree/bindings/mtd/gpio-addr-flash.txt > > diff --git a/Documentation/devicetree/bindings/mtd/gpio-addr-flash.txt b/Documentation/devicetree/bindings/mtd/gpio-addr-flash.txt > new file mode 100644 > index 000000000000..5006a26e1753 > --- /dev/null > +++ b/Documentation/devicetree/bindings/mtd/gpio-addr-flash.txt > @@ -0,0 +1,54 @@ > +Memory Mapped flash with some address lines addressed using GPIOs > + > +Handle the case where a flash device is mostly addressed using physical > +line and supplemented by GPIOs. This way you can hook up say a 8MiB flash > +to a 2MiB memory range and use the GPIOs to select a particular range. > + > + - compatible : "cfi-gpio-addr-flash" > + - reg : Address range of the mtd chip that is memory mapped, this is, > + on the previous example 2MiB. > + - bank-width : Width (in bytes) of the bank. Equal to the > + device width times the number of interleaved chips. > + - gpios: List of GPIO specifiers that will be used to address the MSBs address > + lines. The order goes from LSB to MSB. > + - probe-type : (optional) "cfi_probe", "jedec_probe". How the mtd chip > + is going to be probed. If omitted, assumed to be equal to "cfi_probe". Looks like other bindings are encoding the probe type in the compatible [1][2], and we should probably follow what's been done by others. > + - #address-cells, #size-cells : Must be present if the device has > + sub-nodes representing partitions (see below). In this case > + both #address-cells and #size-cells must be equal to 1. > + > +The device tree may optionally contain sub-nodes describing partitions of the > +address space. Check partition.txt for more details. > + > +Example: > + > + flash@300000 { > + #address-cells = <1>; > + #size-cells = <1>; You should not have the #address-cells and #size-cells props defined at this level, it's done in the partitions node already. > + compatible = "cfi-gpio-addr-flash"; > + bank-width = <2>; > + reg = < 0x00300000 0x00200000 >; > + gpios = <&gpio_0 3 0>, <&gpio_0 4 0>; > + partitions { > + compatible = "fixed-partitions"; > + #address-cells = <1>; > + #size-cells = <1>; > + > + partition@0 { > + reg = < 0x0 0x200000 >; > + label = "Golden Bitstream"; > + }; > + partition@200000 { > + reg = < 0x200000 0x200000 >; > + label = "User Bitstream"; > + }; > + partition@400000 { > + reg = < 0x400000 0x200000 >; > + label = "V4L Controls"; > + }; > + partition@600000 { > + reg = < 0x600000 0x200000 >; > + label = "Production Data"; > + }; > + } > + } ; [1]https://elixir.bootlin.com/linux/latest/source/Documentation/devicetree/bindings/mtd/cortina,gemini-flash.txt [2]https://elixir.bootlin.com/linux/latest/source/Documentation/devicetree/bindings/mtd/arm-versatile.txt