From: Bjorn Andersson <bjorn.andersson@linaro.org>
To: Arun Kumar Neelakantam <aneela@codeaurora.org>
Cc: ohad@wizery.com, clew@codeaurora.org, sricharan@codeaurora.org,
linux-remoteproc@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/5] rpmsg: Add signal callback to rpmsg char device
Date: Wed, 3 Oct 2018 17:26:51 -0700 [thread overview]
Message-ID: <20181004002651.GU2523@minitux> (raw)
In-Reply-To: <1538566463-24627-3-git-send-email-aneela@codeaurora.org>
On Wed 03 Oct 04:34 PDT 2018, Arun Kumar Neelakantam wrote:
> Register a callback to get the signal notifications from rpmsg.
>
> Signed-off-by: Arun Kumar Neelakantam <aneela@codeaurora.org>
Please incorporate this into patch 4.
Regards,
Bjorn
> ---
> drivers/rpmsg/rpmsg_char.c | 8 ++++++++
> 1 file changed, 8 insertions(+)
>
> diff --git a/drivers/rpmsg/rpmsg_char.c b/drivers/rpmsg/rpmsg_char.c
> index a76b963..86003d5 100644
> --- a/drivers/rpmsg/rpmsg_char.c
> +++ b/drivers/rpmsg/rpmsg_char.c
> @@ -5,6 +5,7 @@
> * Copyright (c) 2012, PetaLogix
> * Copyright (c) 2011, Texas Instruments, Inc.
> * Copyright (c) 2011, Google, Inc.
> + * Copyright (c) 2018, The Linux Foundation.
> *
> * Based on rpmsg performance statistics driver by Michal Simek, which in turn
> * was based on TI & Google OMX rpmsg driver.
> @@ -120,6 +121,12 @@ static int rpmsg_ept_cb(struct rpmsg_device *rpdev, void *buf, int len,
> return 0;
> }
>
> +static int rpmsg_sigs_cb(struct rpmsg_device *rpdev, void *priv,
> + u32 old, u32 new)
> +{
> + return 0;
> +}
> +
> static int rpmsg_eptdev_open(struct inode *inode, struct file *filp)
> {
> struct rpmsg_eptdev *eptdev = cdev_to_eptdev(inode->i_cdev);
> @@ -136,6 +143,7 @@ static int rpmsg_eptdev_open(struct inode *inode, struct file *filp)
> return -EINVAL;
> }
>
> + ept->sig_cb = rpmsg_sigs_cb;
> eptdev->ept = ept;
> filp->private_data = eptdev;
>
> --
> The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum,
> a Linux Foundation Collaborative Project
>
next prev parent reply other threads:[~2018-10-04 0:26 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-10-03 11:34 [PATCH 0/5] Add TIOCM Signals support for RPMSG char devices Arun Kumar Neelakantam
2018-10-03 11:34 ` [PATCH 1/5] rpmsg: glink: Add GLINK signal support for RPMSG Arun Kumar Neelakantam
2018-10-04 0:46 ` Bjorn Andersson
2018-10-03 11:34 ` [PATCH 2/5] rpmsg: Add signal callback to rpmsg char device Arun Kumar Neelakantam
2018-10-04 0:26 ` Bjorn Andersson [this message]
2018-10-03 11:34 ` [PATCH 3/5] rpmsg: Add TIOCMGET/TIOCMSET ioctl support Arun Kumar Neelakantam
2018-10-04 0:54 ` Bjorn Andersson
2018-10-03 11:34 ` [PATCH 4/5] rpmsg: wakeup poll to notify signal update Arun Kumar Neelakantam
2018-10-04 0:31 ` Bjorn Andersson
2018-10-03 11:34 ` [PATCH 5/5] rpmsg: glink: Convert the native signals to TIOCM Arun Kumar Neelakantam
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181004002651.GU2523@minitux \
--to=bjorn.andersson@linaro.org \
--cc=aneela@codeaurora.org \
--cc=clew@codeaurora.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-remoteproc@vger.kernel.org \
--cc=ohad@wizery.com \
--cc=sricharan@codeaurora.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox