From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.3 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_PASS,USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 42A58C64EB8 for ; Thu, 4 Oct 2018 13:48:46 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 10DA62084D for ; Thu, 4 Oct 2018 13:48:46 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 10DA62084D Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=atomide.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727600AbeJDUmH (ORCPT ); Thu, 4 Oct 2018 16:42:07 -0400 Received: from muru.com ([72.249.23.125]:58134 "EHLO muru.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727354AbeJDUmG (ORCPT ); Thu, 4 Oct 2018 16:42:06 -0400 Received: from atomide.com (localhost [127.0.0.1]) by muru.com (Postfix) with ESMTPS id E7A4B809C; Thu, 4 Oct 2018 13:53:11 +0000 (UTC) Date: Thu, 4 Oct 2018 06:48:39 -0700 From: Tony Lindgren To: Ulf Hansson Cc: "Rafael J . Wysocki" , Sudeep Holla , Lorenzo Pieralisi , Mark Rutland , Daniel Lezcano , linux-pm@vger.kernel.org, Kevin Hilman , Lina Iyer , Rob Herring , Viresh Kumar , Vincent Guittot , Geert Uytterhoeven , linux-arm-kernel@lists.infradead.org, linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v9 03/11] PM / Domains: Document flags for genpd Message-ID: <20181004134839.GZ5662@atomide.com> References: <20181003143824.13059-1-ulf.hansson@linaro.org> <20181003143824.13059-4-ulf.hansson@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20181003143824.13059-4-ulf.hansson@linaro.org> User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi, * Ulf Hansson [181003 14:43]: > + * GENPD_FLAG_IRQ_SAFE: This informs genpd that its backend callbacks, > + * ->power_on|off(), doesn't sleep. Hence, these > + * can be invoked from within atomic context, which > + * enables genpd to power on/off the PM domain, > + * even when pm_runtime_is_irq_safe() returns true, > + * for any of its attached devices. Note that, a > + * genpd having this flag set, requires its > + * masterdomains to also have it set. > + * Let's try to avoid adding more irq_safe stuff because of having that propagate to the masterdomains.. I think you can just flag the power_on/off in genpd, then have cpu_pm callbacks do it. Regards, Tony