From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.3 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_PASS,USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id CD901C00449 for ; Fri, 5 Oct 2018 04:10:25 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 9C53E208E7 for ; Fri, 5 Oct 2018 04:10:25 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 9C53E208E7 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linux.ibm.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727607AbeJELHN (ORCPT ); Fri, 5 Oct 2018 07:07:13 -0400 Received: from mx0a-001b2d01.pphosted.com ([148.163.156.1]:51786 "EHLO mx0a-001b2d01.pphosted.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726286AbeJELHN (ORCPT ); Fri, 5 Oct 2018 07:07:13 -0400 Received: from pps.filterd (m0098404.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.16.0.22/8.16.0.22) with SMTP id w954AEpc143444 for ; Fri, 5 Oct 2018 00:10:14 -0400 Received: from e17.ny.us.ibm.com (e17.ny.us.ibm.com [129.33.205.207]) by mx0a-001b2d01.pphosted.com with ESMTP id 2mwwhhfvgk-1 (version=TLSv1.2 cipher=AES256-GCM-SHA384 bits=256 verify=NOT) for ; Fri, 05 Oct 2018 00:09:05 -0400 Received: from localhost by e17.ny.us.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Fri, 5 Oct 2018 00:09:04 -0400 Received: from b01cxnp23034.gho.pok.ibm.com (9.57.198.29) by e17.ny.us.ibm.com (146.89.104.204) with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted; (version=TLSv1/SSLv3 cipher=AES256-GCM-SHA384 bits=256/256) Fri, 5 Oct 2018 00:09:01 -0400 Received: from b01ledav003.gho.pok.ibm.com (b01ledav003.gho.pok.ibm.com [9.57.199.108]) by b01cxnp23034.gho.pok.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id w95491hP24445074 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=FAIL); Fri, 5 Oct 2018 04:09:01 GMT Received: from b01ledav003.gho.pok.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id D2325B205F; Fri, 5 Oct 2018 00:07:09 -0400 (EDT) Received: from b01ledav003.gho.pok.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id B2CB0B2066; Fri, 5 Oct 2018 00:07:09 -0400 (EDT) Received: from paulmck-ThinkPad-W541 (unknown [9.80.210.4]) by b01ledav003.gho.pok.ibm.com (Postfix) with ESMTP; Fri, 5 Oct 2018 00:07:09 -0400 (EDT) Received: by paulmck-ThinkPad-W541 (Postfix, from userid 1000) id 801C716C1CED; Thu, 4 Oct 2018 21:09:00 -0700 (PDT) Date: Thu, 4 Oct 2018 21:09:00 -0700 From: "Paul E. McKenney" To: Dmitry Torokhov Cc: linux-input@vger.kernel.org, Eric Dumazet , linux-kernel@vger.kernel.org Subject: Re: [PATCH] Input: uinput - add a schedule point in uinput_inject_events() Reply-To: paulmck@linux.ibm.com References: <20181005005432.GA218507@dtor-ws> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20181005005432.GA218507@dtor-ws> User-Agent: Mutt/1.5.21 (2010-09-15) X-TM-AS-GCONF: 00 x-cbid: 18100504-0040-0000-0000-0000047B7BB0 X-IBM-SpamModules-Scores: X-IBM-SpamModules-Versions: BY=3.00009824; HX=3.00000242; KW=3.00000007; PH=3.00000004; SC=3.00000267; SDB=6.01098052; UDB=6.00567917; IPR=6.00878092; MB=3.00023621; MTD=3.00000008; XFM=3.00000015; UTC=2018-10-05 04:09:03 X-IBM-AV-DETECTION: SAVI=unused REMOTE=unused XFE=unused x-cbparentid: 18100504-0041-0000-0000-000008838832 Message-Id: <20181005040900.GV2674@linux.ibm.com> X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:,, definitions=2018-10-05_01:,, signatures=0 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 priorityscore=1501 malwarescore=0 suspectscore=0 phishscore=0 bulkscore=0 spamscore=0 clxscore=1015 lowpriorityscore=0 mlxscore=0 impostorscore=0 mlxlogscore=999 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1807170000 definitions=main-1810050042 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Oct 04, 2018 at 05:54:32PM -0700, Dmitry Torokhov wrote: > Large writes to uinput interface may cause rcu stalls. Let's add > cond_resched() to the loop to avoid this. > > Signed-off-by: Dmitry Torokhov Reviewed-by: Paul E. McKenney > --- > drivers/input/misc/uinput.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/input/misc/uinput.c b/drivers/input/misc/uinput.c > index eb14ddf69346..8ec483e8688b 100644 > --- a/drivers/input/misc/uinput.c > +++ b/drivers/input/misc/uinput.c > @@ -598,6 +598,7 @@ static ssize_t uinput_inject_events(struct uinput_device *udev, > > input_event(udev->dev, ev.type, ev.code, ev.value); > bytes += input_event_size(); > + cond_resched(); > } > > return bytes; > -- > 2.19.0.605.g01d371f741-goog > > > -- > Dmitry >