Re: [PATCH v3 0/3] get_user_pages*() and RDMA: first steps

Dennis Dalessandro
2018-10-08T15:53:27Z

On 10/5/2018 10:49 PM, john.hubbard@gmail.com wrote:
> From: John Hubbard <jhubbard@nvidia.com>
>
> Changes since v2:
>
> -- Absorbed more dirty page handling logic into the put_user_page*(), and
> handled some page releasing loops in infiniband more thoroughly, as per
> Jason Gunthorpe's feedback.
>
> -- Fixed a bug in the put_user_pages*() routines' loops (thanks to
> Ralph Campbell for spotting it).
>
> Changes since v1:
>
> -- Renamed release_user_pages*() to put_user_pages*(), from Jan's feedback.
>
> -- Removed the goldfish.c changes, and instead, only included a single
> user (infiniband) of the new functions. That is because goldfish.c no
> longer has a name collision (it has a release_user_pages() routine), and
> also because infiniband exercises both the put_user_page() and
> put_user_pages*() paths.
>
> -- Updated links to discussions and plans, so as to be sure to include
> bounce buffers, thanks to Jerome's feedback.
>
> Also:
>
> -- Dennis, thanks for your earlier review, and I have not yet added your
> Reviewed-by tag, because this revision changes the things that you had
> previously reviewed, thus potentially requiring another look.

This spin looks fine to me.

Reviewed-by: Dennis Dalessandro <dennis.dalessandro@intel.com>