Re: [PATCH v9 04/10] x86: refcount: prevent gcc distortions

Ingo Molnar
2018-10-05T12:52:49Z

* Borislav Petkov <bp@alien8.de> wrote:

> On Fri, Oct 05, 2018 at 11:31:08AM +0200, Ingo Molnar wrote:
> >
> > * Nadav Amit <namit@vmware.com> wrote:
> >
> > > > Are you using defconfig or a reasonable distro-config for your tests?
> > >
> > > I think it is best to take the kernel and run localyesconfig for testing.
> >
> > Ok, agreed - and this makes the numbers you provided pretty representative.
> >
> > Good - now that all of my concerns were addressed I'd like to merge the remaining 3 patches as
> > well - but they are conflicting with ongoing x86 work in tip:x86/core. The extable conflict is
> > trivial, the jump-label conflict a bit more involved.
>
> FWIW, gcc guys are not too averse to the idea of enhancing gcc inline
> asm syntax with a statement which specifies its size so that gcc can use
> it to do better inlining cost estimation than counting lines.
>
> Lemme work the process ...

Thanks!

Ingo