Re: [PATCH v9 04/10] x86: refcount: prevent gcc distortions

Ingo Molnar
2018-10-04T09:16:59Z

* hpa@zytor.com <hpa@zytor.com> wrote:

> Ingo: I wasn't talking necessarily about the specifics of each bit, but rather the general
> concept about being able to use macros in inlines...

Ok, agreed about that part - and some of the patches did improve readability.

Also, the 275 lines macros.s is a lot nicer than the 4,200 lines macros.S.

Also, I'm not against using workarounds when the benefits are larger than the costs, but I am
against *hiding* the fact that these are workarounds and that for some of them there are costs.

> I can send you something I have been working on in the background, but have been holding off
> on because of this, in the morning my time.

BTW., I have applied most of the series to tip:x86/kbuild already, and will push them out later
today after some testing. I didn't apply the final 3 patches as they have dependencies, but
applied the basics and fixed up the changelogs.

So you can rely on this.

Thanks,

Ingo