* [PATCH] sched/dl : return accurate release rq lock info
@ 2018-10-06 1:08 Peng Hao
2018-10-05 17:50 ` Steven Rostedt
2018-10-08 8:47 ` Juri Lelli
0 siblings, 2 replies; 3+ messages in thread
From: Peng Hao @ 2018-10-06 1:08 UTC (permalink / raw)
To: mingo, peterz; +Cc: rostedt, andrea.parri, linux-kernel, Peng Hao
find_lock_later_rq may or not releease rq lock when return
later_rq=NULL, but it is fuzzy.
If not releasing rq lock, it is unnecessary to re-call
pick_next_pushable_dl_task.
Signed-off-by: Peng Hao <peng.hao2@zte.com.cn>
---
kernel/sched/deadline.c | 6 ++++--
1 file changed, 4 insertions(+), 2 deletions(-)
diff --git a/kernel/sched/deadline.c b/kernel/sched/deadline.c
index 997ea7b..8e875ec 100644
--- a/kernel/sched/deadline.c
+++ b/kernel/sched/deadline.c
@@ -1979,7 +1979,7 @@ static struct rq *find_lock_later_rq(struct task_struct *task, struct rq *rq)
!dl_task(task) ||
!task_on_rq_queued(task))) {
double_unlock_balance(rq, later_rq);
- later_rq = NULL;
+ later_rq = RETRY_TASK;
break;
}
}
@@ -2063,7 +2063,9 @@ static int push_dl_task(struct rq *rq)
/* Will lock the rq it'll find */
later_rq = find_lock_later_rq(next_task, rq);
- if (!later_rq) {
+ if (!later_rq)
+ goto out;
+ if (later_rq == RETRY_TASK) {
struct task_struct *task;
/*
--
1.8.3.1
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH] sched/dl : return accurate release rq lock info
2018-10-06 1:08 [PATCH] sched/dl : return accurate release rq lock info Peng Hao
@ 2018-10-05 17:50 ` Steven Rostedt
2018-10-08 8:47 ` Juri Lelli
1 sibling, 0 replies; 3+ messages in thread
From: Steven Rostedt @ 2018-10-05 17:50 UTC (permalink / raw)
To: Peng Hao; +Cc: mingo, peterz, andrea.parri, linux-kernel
On Sat, 6 Oct 2018 09:08:37 +0800
Peng Hao <peng.hao2@zte.com.cn> wrote:
> find_lock_later_rq may or not releease rq lock when return
> later_rq=NULL, but it is fuzzy.
> If not releasing rq lock, it is unnecessary to re-call
> pick_next_pushable_dl_task.
>
> Signed-off-by: Peng Hao <peng.hao2@zte.com.cn>
Reviewed-by: Steven Rostedt (VMware) <rostedt@goodmis.org>
-- Steve
> ---
> kernel/sched/deadline.c | 6 ++++--
> 1 file changed, 4 insertions(+), 2 deletions(-)
>
> diff --git a/kernel/sched/deadline.c b/kernel/sched/deadline.c
> index 997ea7b..8e875ec 100644
> --- a/kernel/sched/deadline.c
> +++ b/kernel/sched/deadline.c
> @@ -1979,7 +1979,7 @@ static struct rq *find_lock_later_rq(struct task_struct *task, struct rq *rq)
> !dl_task(task) ||
> !task_on_rq_queued(task))) {
> double_unlock_balance(rq, later_rq);
> - later_rq = NULL;
> + later_rq = RETRY_TASK;
> break;
> }
> }
> @@ -2063,7 +2063,9 @@ static int push_dl_task(struct rq *rq)
>
> /* Will lock the rq it'll find */
> later_rq = find_lock_later_rq(next_task, rq);
> - if (!later_rq) {
> + if (!later_rq)
> + goto out;
> + if (later_rq == RETRY_TASK) {
> struct task_struct *task;
>
> /*
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] sched/dl : return accurate release rq lock info
2018-10-06 1:08 [PATCH] sched/dl : return accurate release rq lock info Peng Hao
2018-10-05 17:50 ` Steven Rostedt
@ 2018-10-08 8:47 ` Juri Lelli
1 sibling, 0 replies; 3+ messages in thread
From: Juri Lelli @ 2018-10-08 8:47 UTC (permalink / raw)
To: Peng Hao; +Cc: mingo, peterz, rostedt, andrea.parri, linux-kernel
On 06/10/18 09:08, Peng Hao wrote:
> find_lock_later_rq may or not releease rq lock when return
> later_rq=NULL, but it is fuzzy.
> If not releasing rq lock, it is unnecessary to re-call
> pick_next_pushable_dl_task.
>
> Signed-off-by: Peng Hao <peng.hao2@zte.com.cn>
Subject has whitespaces problems and changelog might be improved.
Other then that patch looks good, thanks!
Acked-by: Juri Lelli <juri.lelli@redhat.com>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2018-10-08 8:48 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2018-10-06 1:08 [PATCH] sched/dl : return accurate release rq lock info Peng Hao
2018-10-05 17:50 ` Steven Rostedt
2018-10-08 8:47 ` Juri Lelli
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox