Re: [PATCH v11 2/3]: perf record: enable asynchronous trace writing

Alexey Budankov
2018-10-08T12:27:03Z

Hi,

On 08.10.2018 13:58, Jiri Olsa wrote:
> On Mon, Oct 08, 2018 at 09:17:11AM +0300, Alexey Budankov wrote:
>>
<SNIP>
>> +#ifdef HAVE_AIO_SUPPORT
>> + off = lseek(trace_fd, 0, SEEK_CUR);
>> +#endif
>> for (i = 0; i < evlist->nr_mmaps; i++) {
>> struct perf_mmap *map = &maps[i];
>>
>> if (map->base) {
>> - if (perf_mmap__push(map, rec, record__pushfn) != 0) {
>> - rc = -1;
>> - goto out;
>> +#ifdef HAVE_AIO_SUPPORT
>> + if (!rec->opts.nr_cblocks) {
>> +#endif
>
> maybe it'd be less confusing having something like
> rec->opts.aio.enabled
>
> or aio__is_enabled() global with the dummy counterpart

Makes sense. Will implement __is_enabled() function.

Thanks,
Alexey

>
> jirka
>