Re: [PATCH v11 1/3]: perf util: map data buffer for preserving collected data

Alexey Budankov
2018-10-08T12:05:55Z

Hi,

On 08.10.2018 13:51, Jiri Olsa wrote:
> On Mon, Oct 08, 2018 at 09:14:29AM +0300, Alexey Budankov wrote:
<SNIP>
>
> could you please separate those in struct, maybe anonymous like:
>
> ...
> struct {
> void *data;
> struct aiocb cblock;
> int nr_cblocks;
> } aio;
> ...
>

Accepted.

>
>> };
>>
>> /*
>> @@ -59,6 +67,9 @@ enum bkw_mmap_state {
>> struct mmap_params {
>> int prot, mask;
>> struct auxtrace_mmap_params auxtrace_mp;
>> +#ifdef HAVE_AIO_SUPPORT
>> + int nr_cblocks;
>> +#endif
>
> I dont think we need the ifdef here.. IMO one extra int is not
> worth of the ifdef endif confusion

Accepted.

Thanks,
Alexey

>
> jirka
>