From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Gao Xiang <gaoxiang25@huawei.com>
Cc: Loic Tourlonias <loic.tourlonias.lkml@gmail.com>,
Chao Yu <yuchao0@huawei.com>,
linux-erofs@lists.ozlabs.org, devel@driverdev.osuosl.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] staging: erofs: add SPDX identifer
Date: Mon, 8 Oct 2018 15:49:28 +0200 [thread overview]
Message-ID: <20181008134928.GA31820@kroah.com> (raw)
In-Reply-To: <fe0ab9ae-3b71-7d63-053c-53b6dab95ef6@huawei.com>
On Mon, Oct 08, 2018 at 09:20:55PM +0800, Gao Xiang wrote:
> Hi Loic,
>
> On 2018/10/8 18:41, Loic Tourlonias wrote:
> > Add SPDX identifier to simplify header and remove whole license text
> >
> > Signed-off-by: Loic Tourlonias <loic.tourlonias.lkml@gmail.com>
> > ---
> > drivers/staging/erofs/lz4defs.h | 23 ++---------------------
> > 1 file changed, 2 insertions(+), 21 deletions(-)
> >
> > diff --git a/drivers/staging/erofs/lz4defs.h b/drivers/staging/erofs/lz4defs.h
> > index 00a0b58a0871..bdb1022981d8 100644
> > --- a/drivers/staging/erofs/lz4defs.h
> > +++ b/drivers/staging/erofs/lz4defs.h
> > @@ -1,32 +1,13 @@
> > #ifndef __LZ4DEFS_H__
> > #define __LZ4DEFS_H__
> >
> > +// SPDX-License-Identifier: BSD-2-Clause
>
> For *.h files, it seems SPDX Identifier should be /* SPDX-License-Identifier: */
> rather than // SPDX-License-Identifier:
That is correct.
> And I think it should be placed at the first line of the line, but I am not sure of that.
Yes, it has to be the first line.
The documentation for the SPDX lines in the kernel describe all of this.
thanks,
greg k-h
prev parent reply other threads:[~2018-10-08 14:01 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-10-08 10:41 [PATCH] staging: erofs: add SPDX identifer Loic Tourlonias
2018-10-08 13:20 ` Gao Xiang
2018-10-08 13:49 ` Greg Kroah-Hartman [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181008134928.GA31820@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=devel@driverdev.osuosl.org \
--cc=gaoxiang25@huawei.com \
--cc=linux-erofs@lists.ozlabs.org \
--cc=linux-kernel@vger.kernel.org \
--cc=loic.tourlonias.lkml@gmail.com \
--cc=yuchao0@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox