Re: [PATCH] media: vivid: Support 480p for webcam capture

Hans Verkuil
2018-10-09T06:34:04Z

On 10/09/2018 08:01 AM, Keiichi Watanabe wrote:
> Let me back to the topic about interval.
> I'd like to send a nex version of this patch to avoid duplication of intervals.
>
> We need to choose two intervals from the three options: 1/20, 2/25 and 1/40.
> As Mauro said, we would want to have 2/25 for a fractional rate.
> Then, I think adding 2/25 and 1/40 will work well.
> If it's okay, I will send an updated version.

Fine by me!

Hans

>
> Best regards,
> Kei
>
> On Tue, Oct 9, 2018 at 4:00 AM, Mauro Carvalho Chehab
> <mchehab+samsung@kernel.org> wrote:
>> Em Mon, 8 Oct 2018 20:31:10 +0200
>> Hans Verkuil <hverkuil@xs4all.nl> escreveu:
>>
>>>> (gdb) list *vivid_fillbuff+0x1e9b
>>>> 0x1936b is in vivid_fillbuff (drivers/media/platform/vivid/vivid-kthread-cap.c:495).
>>>> 490 ms % 1000,
>>>> 491 buf->vb.sequence,
>>>> 492 (dev->field_cap == V4L2_FIELD_ALTERNATE) ?
>>>> 493 (buf->vb.field == V4L2_FIELD_TOP ?
>>>> 494 " top" : " bottom") : "");
>>>> 495 tpg_gen_text(tpg, basep, line++ * line_height, 16, str);
>>>> 496 }
>>>> 497 if (dev->osd_mode == 0) {
>>>> 498 snprintf(str, sizeof(str), " %dx%d, input %d ",
>>>> 499 dev->src_rect.width, dev->src_rect.height, dev->input);
>>>>
>>>
>>> There is a bug with hflip handling in that function. Nothing to do with the
>>> resolution. I could reproduce it by just checking the hflip control.
>>> I'll investigate.
>>
>> Ah! Well, as I said, I got it only once last week while trying to use
>> vivid for some event racing test. I didn't have time to actually
>> seek. On that time, the bug only manifested when I changed the frame
>> rate.
>>
>> Thanks,
>> Mauro