From: Jiri Olsa <jolsa@redhat.com>
To: Alexey Budankov <alexey.budankov@linux.intel.com>
Cc: Peter Zijlstra <peterz@infradead.org>,
Ingo Molnar <mingo@kernel.org>,
Arnaldo Carvalho de Melo <acme@kernel.org>,
Alexander Shishkin <alexander.shishkin@linux.intel.com>,
Namhyung Kim <namhyung@kernel.org>,
Andi Kleen <ak@linux.intel.com>,
linux-kernel <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v11 1/3]: perf util: map data buffer for preserving collected data
Date: Mon, 8 Oct 2018 17:12:58 +0200 [thread overview]
Message-ID: <20181008151258.GI18757@krava> (raw)
In-Reply-To: <cc781e40-c162-9581-9573-d994785c4cc1@linux.intel.com>
On Mon, Oct 08, 2018 at 05:43:38PM +0300, Alexey Budankov wrote:
> Hi,
>
> On 08.10.2018 15:38, Jiri Olsa wrote:
> > On Mon, Oct 08, 2018 at 03:03:18PM +0300, Alexey Budankov wrote:
> <SNIP>
> >>
> >> Well, let's go with stub functions design as opposite to pure
> >> conditional compilation. However this may, probably, result in
> >> unintended Perf tool binary size growth, even if NO_AIO is
> >> defined during compilation.
> >
> > hum, empty functions are be optimized out
>
> Yes, but there will be references to stubs in else branch of
> record__mmap_read_evlist() so I am not sure that *all* compilers
> are smart enough to recognize and still optimize it out.
well, kernel is doing that and it seem to be fine,
so I wouldn't worry about it
jirka
next prev parent reply other threads:[~2018-10-08 15:13 UTC|newest]
Thread overview: 33+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-10-08 5:55 [PATCH v11 0/3]: perf: reduce data loss when profiling highly parallel CPU bound workloads Alexey Budankov
2018-10-08 6:14 ` [PATCH v11 1/3]: perf util: map data buffer for preserving collected data Alexey Budankov
2018-10-08 10:50 ` Jiri Olsa
2018-10-08 11:55 ` Alexey Budankov
2018-10-08 12:37 ` Jiri Olsa
2018-10-08 10:50 ` Jiri Olsa
2018-10-08 12:03 ` Alexey Budankov
2018-10-08 12:38 ` Jiri Olsa
2018-10-08 14:43 ` Alexey Budankov
2018-10-08 15:12 ` Jiri Olsa [this message]
2018-10-08 15:38 ` Alexey Budankov
2018-10-08 10:51 ` Jiri Olsa
2018-10-08 12:05 ` Alexey Budankov
2018-10-08 6:17 ` [PATCH v11 2/3]: perf record: enable asynchronous trace writing Alexey Budankov
2018-10-08 10:50 ` Jiri Olsa
2018-10-08 12:17 ` Alexey Budankov
2018-10-08 10:51 ` Jiri Olsa
2018-10-08 12:19 ` Alexey Budankov
2018-10-08 10:52 ` Jiri Olsa
2018-10-08 12:24 ` Alexey Budankov
2018-10-08 12:53 ` Jiri Olsa
2018-10-08 14:42 ` Alexey Budankov
2018-10-08 15:11 ` Jiri Olsa
2018-10-08 15:39 ` Alexey Budankov
2018-10-08 10:57 ` Jiri Olsa
2018-10-08 12:15 ` Alexey Budankov
2018-10-08 10:58 ` Jiri Olsa
2018-10-08 12:26 ` Alexey Budankov
2018-10-08 6:19 ` [PATCH v11 3/3]: perf record: extend trace writing to multi AIO Alexey Budankov
2018-10-08 10:55 ` Jiri Olsa
2018-10-08 11:47 ` Alexey Budankov
2018-10-08 12:45 ` Jiri Olsa
2018-10-08 15:21 ` Alexey Budankov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181008151258.GI18757@krava \
--to=jolsa@redhat.com \
--cc=acme@kernel.org \
--cc=ak@linux.intel.com \
--cc=alexander.shishkin@linux.intel.com \
--cc=alexey.budankov@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@kernel.org \
--cc=namhyung@kernel.org \
--cc=peterz@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox