From: Al Viro <viro@ZenIV.linux.org.uk>
To: Ahmad Fatoum <a.fatoum@pengutronix.de>
Cc: Andrew Morton <akpm@linux-foundation.org>,
Alexey Dobriyan <adobriyan@gmail.com>,
David Howells <dhowells@redhat.com>,
Florian Westphal <fw@strlen.de>,
linux-kernel@vger.kernel.org, kernel@pengutronix.de
Subject: Re: [PATCH RFC] proc: Don't retain negative dentries
Date: Mon, 8 Oct 2018 17:55:45 +0100 [thread overview]
Message-ID: <20181008165545.GE32577@ZenIV.linux.org.uk> (raw)
In-Reply-To: <20181008165009.21890-1-a.fatoum@pengutronix.de>
On Mon, Oct 08, 2018 at 06:50:10PM +0200, Ahmad Fatoum wrote:
> The referenced commit 1da4d377f94 ("proc: revalidate misc dentries")
> caused following userspace code to access a stale /proc/net/dev
> after the network namespace was changed:
> Despite switching the network namespace, the read access from the
> newly opened file gave back what the very first read in the default
> network namespace returned.
What the hell does that have to do with negative dentries anywhere???
NAK. Rationale makes no sense _and_ the patch has nothing to do
with claimed rationale.
next prev parent reply other threads:[~2018-10-08 16:55 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-10-08 16:50 [PATCH RFC] proc: Don't retain negative dentries Ahmad Fatoum
2018-10-08 16:54 ` Ahmad Fatoum
2018-10-08 16:55 ` Al Viro [this message]
2018-10-08 17:02 ` Ahmad Fatoum
2018-10-08 18:01 ` Al Viro
2018-10-15 9:56 ` Ahmad Fatoum
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181008165545.GE32577@ZenIV.linux.org.uk \
--to=viro@zeniv.linux.org.uk \
--cc=a.fatoum@pengutronix.de \
--cc=adobriyan@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=dhowells@redhat.com \
--cc=fw@strlen.de \
--cc=kernel@pengutronix.de \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox