[GIT PULL 00/12] perf/core improvements and fixes

[GIT PULL 00/12] perf/core improvements and fixes

[Arnaldo Carvalho de Melo]

Hi Ingo,

	Please consider pulling.

	 I'll continue processing patchsets by Jiri, Namhyung, David, Irina and
others tomorrow.

	I also have to rework the pagefaults patches, as the code it touches
changed lately, will add that NUMA node info you suggested.

- Arnaldo

The following changes since commit ce37f400336a34bb6e72c4700f9dcc2a41ff7163:

  x86: Allow tracing of functions in arch/x86/kernel/rtc.c (2012-10-24 13:14:22 +0200)

are available in the git repository at:

  git://git.kernel.org/pub/scm/linux/kernel/git/acme/linux tags/perf-core-for-mingo

for you to fetch changes up to af3df2cf17f5df079189c3cc88870d28e219496b:

  perf tools: Try to build Documentation when installing (2012-10-24 19:30:48 -0200)

----------------------------------------------------------------
perf/core improvements and fixes

. Align the 'Ok'/'FAILED!' test results in 'perf test.

. Support interrupted syscalls in 'trace'

. Add an event duration column and filter in 'trace'.

. There are references to the man pages in some tools, so try to build
  Documentation when installing, warning the user if that is not possible,
  from Borislav Petkov.

. Give user better message if precise is not supported, from David Ahern.

. Try to find cross-built objdump path by using the session environment
  information in the perf.data file header, from Irina Tirdea, original
  patch and idea by Namhyung Kim.

. Diplays more output on features check for make V=1, so that one can figure
  out what is happening by looking at gcc output, etc. From Jiri Olsa.

. Account the nr_entries in rblist properly, fix by Suzuki K. Poulose.

Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>

----------------------------------------------------------------
Arnaldo Carvalho de Melo (7):
      perf tools: Remove noise in python version feature test
      perf test: Align the 'Ok'/'FAILED!' test results
      perf trace: Support interrupted syscalls
      perf trace: Add an event duration column
      perf trace: Add duration filter
      perf tools: Pretty print errno for some more functions
      perf trace: Print the name of a syscall when failing to read its info

Borislav Petkov (1):
      perf tools: Try to build Documentation when installing

David Ahern (1):
      perf tools: Give user better message if precise is not supported

Irina Tirdea (1):
      perf tools: Try to find cross-built objdump path

Jiri Olsa (1):
      perf tools: Diplays more output on features check for make V=1

Suzuki K. Poulose (1):
      Account the nr_entries in rblist properly

 tools/perf/Documentation/Makefile       |   31 +++-
 tools/perf/Documentation/perf-trace.txt |    3 +
 tools/perf/Makefile                     |   53 ++++---
 tools/perf/arch/common.c                |  178 ++++++++++++++++++++++
 tools/perf/arch/common.h                |   10 ++
 tools/perf/builtin-annotate.c           |    7 +
 tools/perf/builtin-record.c             |    5 +
 tools/perf/builtin-report.c             |    7 +
 tools/perf/builtin-test.c               |   18 ++-
 tools/perf/builtin-top.c                |    4 +
 tools/perf/builtin-trace.c              |  250 ++++++++++++++++++++++++++++---
 tools/perf/config/feature-tests.mak     |    5 +-
 tools/perf/config/utilities.mak         |   11 +-
 tools/perf/util/annotate.h              |    1 -
 tools/perf/util/parse-events.c          |    2 +-
 tools/perf/util/rblist.c                |    4 +-
 tools/perf/util/util.h                  |    4 +
 17 files changed, 535 insertions(+), 58 deletions(-)
 create mode 100644 tools/perf/arch/common.c
 create mode 100644 tools/perf/arch/common.h

Re: [GIT PULL 00/12] perf/core improvements and fixes

[Ingo Molnar]

* Arnaldo Carvalho de Melo <acme@infradead.org> wrote:

> Hi Ingo,
> 
> 	Please consider pulling.
> 
> 	 I'll continue processing patchsets by Jiri, Namhyung, David, Irina and
> others tomorrow.
> 
> 	I also have to rework the pagefaults patches, as the code it touches
> changed lately, will add that NUMA node info you suggested.
> 
> - Arnaldo
> 
> The following changes since commit ce37f400336a34bb6e72c4700f9dcc2a41ff7163:
> 
>   x86: Allow tracing of functions in arch/x86/kernel/rtc.c (2012-10-24 13:14:22 +0200)
> 
> are available in the git repository at:
> 
>   git://git.kernel.org/pub/scm/linux/kernel/git/acme/linux tags/perf-core-for-mingo
> 
> for you to fetch changes up to af3df2cf17f5df079189c3cc88870d28e219496b:
> 
>   perf tools: Try to build Documentation when installing (2012-10-24 19:30:48 -0200)
> 
> ----------------------------------------------------------------
> perf/core improvements and fixes
> 
> . Align the 'Ok'/'FAILED!' test results in 'perf test.
> 
> . Support interrupted syscalls in 'trace'
> 
> . Add an event duration column and filter in 'trace'.
> 
> . There are references to the man pages in some tools, so try to build
>   Documentation when installing, warning the user if that is not possible,
>   from Borislav Petkov.
> 
> . Give user better message if precise is not supported, from David Ahern.
> 
> . Try to find cross-built objdump path by using the session environment
>   information in the perf.data file header, from Irina Tirdea, original
>   patch and idea by Namhyung Kim.
> 
> . Diplays more output on features check for make V=1, so that one can figure
>   out what is happening by looking at gcc output, etc. From Jiri Olsa.
> 
> . Account the nr_entries in rblist properly, fix by Suzuki K. Poulose.
> 
> Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
> 
> ----------------------------------------------------------------
> Arnaldo Carvalho de Melo (7):
>       perf tools: Remove noise in python version feature test
>       perf test: Align the 'Ok'/'FAILED!' test results
>       perf trace: Support interrupted syscalls
>       perf trace: Add an event duration column
>       perf trace: Add duration filter
>       perf tools: Pretty print errno for some more functions
>       perf trace: Print the name of a syscall when failing to read its info
> 
> Borislav Petkov (1):
>       perf tools: Try to build Documentation when installing
> 
> David Ahern (1):
>       perf tools: Give user better message if precise is not supported
> 
> Irina Tirdea (1):
>       perf tools: Try to find cross-built objdump path
> 
> Jiri Olsa (1):
>       perf tools: Diplays more output on features check for make V=1
> 
> Suzuki K. Poulose (1):
>       Account the nr_entries in rblist properly
> 
>  tools/perf/Documentation/Makefile       |   31 +++-
>  tools/perf/Documentation/perf-trace.txt |    3 +
>  tools/perf/Makefile                     |   53 ++++---
>  tools/perf/arch/common.c                |  178 ++++++++++++++++++++++
>  tools/perf/arch/common.h                |   10 ++
>  tools/perf/builtin-annotate.c           |    7 +
>  tools/perf/builtin-record.c             |    5 +
>  tools/perf/builtin-report.c             |    7 +
>  tools/perf/builtin-test.c               |   18 ++-
>  tools/perf/builtin-top.c                |    4 +
>  tools/perf/builtin-trace.c              |  250 ++++++++++++++++++++++++++++---
>  tools/perf/config/feature-tests.mak     |    5 +-
>  tools/perf/config/utilities.mak         |   11 +-
>  tools/perf/util/annotate.h              |    1 -
>  tools/perf/util/parse-events.c          |    2 +-
>  tools/perf/util/rblist.c                |    4 +-
>  tools/perf/util/util.h                  |    4 +
>  17 files changed, 535 insertions(+), 58 deletions(-)
>  create mode 100644 tools/perf/arch/common.c
>  create mode 100644 tools/perf/arch/common.h

Pulled, thanks a lot Arnado!

	Ingo

[GIT PULL 00/12] perf/core improvements and fixes

[Arnaldo Carvalho de Melo]

From: Arnaldo Carvalho de Melo <acme@ghostprotocols.net>

Hi Ingo,

	Please consider pulling,

- Arnaldo

The following changes since commit 0ed1e0bee0b2c6b4cc6d7a63787739a9d3ac8aa8:

  Merge tag 'perf-core-for-mingo' of git://git.kernel.org/pub/scm/linux/kernel/git/acme/linux into perf/core (2013-11-30 13:42:48 +0100)

are available in the git repository at:


  git://git.kernel.org/pub/scm/linux/kernel/git/acme/linux tags/perf-core-for-mingo

for you to fetch changes up to f885037ef6400ce4a4c122a88845dea2c9bca256:

  perf trace: Honour -m option (2013-12-02 16:29:40 -0300)

----------------------------------------------------------------
perf/tools improvements and fixes:

. Honour -m option in 'trace', the tool was offering the option to
  set the mmap size, but wasn't using it when doing the actual mmap
  on the events file descriptors, fix from Jiri Olsa.

. Correct the message in feature-libnuma checking, swowing the right
  devel package names for various distros, from Dongsheng Yang.

. Polish 'readn' function and introduce its counterpart, 'writen', from
  Jiri Olsa.

. Start moving timechart state from global variables to a 'perf_tool' derived
  'timechart' struct.

Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>

----------------------------------------------------------------
Arnaldo Carvalho de Melo (4):
      perf timechart: Introduce tool struct
      perf timechart: Move all_data per_pid list to 'struct timechart'
      perf timechart: Move power_events list to 'struct timechart'
      perf timechart: Move wake_events list to 'struct timechart'

Dongsheng Yang (1):
      perf tools: Correct the message in feature-libnuma checking.

Jiri Olsa (7):
      perf record: Unify data output code into perf_record__write function
      perf tools: Use correct return type for readn function
      perf tools: Fine tune readn function
      perf tools: Add writen function
      perf tools: Add perf_data_file__write interface
      perf tools: Include test-stackprotector-all.c in test-all
      perf trace: Honour -m option

 tools/perf/builtin-record.c                 |  20 +-
 tools/perf/builtin-timechart.c              | 364 +++++++++++++++-------------
 tools/perf/builtin-trace.c                  |   2 +-
 tools/perf/config/Makefile                  |   2 +-
 tools/perf/config/feature-checks/test-all.c |   5 +
 tools/perf/util/data.c                      |   6 +
 tools/perf/util/data.h                      |  14 +-
 tools/perf/util/header.c                    |  18 +-
 tools/perf/util/session.c                   |   2 +-
 tools/perf/util/util.c                      |  32 ++-
 tools/perf/util/util.h                      |   3 +-
 11 files changed, 256 insertions(+), 212 deletions(-)

Re: [GIT PULL 00/12] perf/core improvements and fixes

[Ingo Molnar]

* Arnaldo Carvalho de Melo <acme@infradead.org> wrote:

> From: Arnaldo Carvalho de Melo <acme@ghostprotocols.net>
> 
> Hi Ingo,
> 
> 	Please consider pulling,
> 
> - Arnaldo
> 
> The following changes since commit 0ed1e0bee0b2c6b4cc6d7a63787739a9d3ac8aa8:
> 
>   Merge tag 'perf-core-for-mingo' of git://git.kernel.org/pub/scm/linux/kernel/git/acme/linux into perf/core (2013-11-30 13:42:48 +0100)
> 
> are available in the git repository at:
> 
> 
>   git://git.kernel.org/pub/scm/linux/kernel/git/acme/linux tags/perf-core-for-mingo
> 
> for you to fetch changes up to f885037ef6400ce4a4c122a88845dea2c9bca256:
> 
>   perf trace: Honour -m option (2013-12-02 16:29:40 -0300)
> 
> ----------------------------------------------------------------
> perf/tools improvements and fixes:
> 
> . Honour -m option in 'trace', the tool was offering the option to
>   set the mmap size, but wasn't using it when doing the actual mmap
>   on the events file descriptors, fix from Jiri Olsa.
> 
> . Correct the message in feature-libnuma checking, swowing the right
>   devel package names for various distros, from Dongsheng Yang.
> 
> . Polish 'readn' function and introduce its counterpart, 'writen', from
>   Jiri Olsa.
> 
> . Start moving timechart state from global variables to a 'perf_tool' derived
>   'timechart' struct.
> 
> Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
> 
> ----------------------------------------------------------------
> Arnaldo Carvalho de Melo (4):
>       perf timechart: Introduce tool struct
>       perf timechart: Move all_data per_pid list to 'struct timechart'
>       perf timechart: Move power_events list to 'struct timechart'
>       perf timechart: Move wake_events list to 'struct timechart'
> 
> Dongsheng Yang (1):
>       perf tools: Correct the message in feature-libnuma checking.
> 
> Jiri Olsa (7):
>       perf record: Unify data output code into perf_record__write function
>       perf tools: Use correct return type for readn function
>       perf tools: Fine tune readn function
>       perf tools: Add writen function
>       perf tools: Add perf_data_file__write interface
>       perf tools: Include test-stackprotector-all.c in test-all
>       perf trace: Honour -m option
> 
>  tools/perf/builtin-record.c                 |  20 +-
>  tools/perf/builtin-timechart.c              | 364 +++++++++++++++-------------
>  tools/perf/builtin-trace.c                  |   2 +-
>  tools/perf/config/Makefile                  |   2 +-
>  tools/perf/config/feature-checks/test-all.c |   5 +
>  tools/perf/util/data.c                      |   6 +
>  tools/perf/util/data.h                      |  14 +-
>  tools/perf/util/header.c                    |  18 +-
>  tools/perf/util/session.c                   |   2 +-
>  tools/perf/util/util.c                      |  32 ++-
>  tools/perf/util/util.h                      |   3 +-
>  11 files changed, 256 insertions(+), 212 deletions(-)

Pulled, thanks a lot Arnaldo!

	Ingo

[GIT PULL 00/12] perf/core improvements and fixes

[Arnaldo Carvalho de Melo]

From: Arnaldo Carvalho de Melo <acme@ghostprotocols.net>

Hi Ingo,

	Please consider pulling,

- Arnaldo

The following changes since commit 7e74efcf76c16f851df5c838c143c4a1865ea9fa:

  Merge tag 'perf-core-for-mingo' of git://git.kernel.org/pub/scm/linux/kernel/git/acme/linux into perf/core (2014-02-22 17:26:24 +0100)

are available in the git repository at:


  git://git.kernel.org/pub/scm/linux/kernel/git/acme/linux tags/perf-core-for-mingo

for you to fetch changes up to 1029f9fedf87fa6f52096991588fa54ffd159584:

  perf symbols: Check compatible symtab type before loading dso (2014-02-24 16:25:01 -0300)

----------------------------------------------------------------
perf/core improvements and fixes

. Add support for the new DWARF unwinder library in elfutils (Jiri Olsa)

. Fix build race in the generation of bison files (Jiri Olsa)

. Further streamline the feature detection display, trimming it a bit to
  show just the libraries detected, using VF=1 gets a more verbose output,
  showing the less interesting feature checks as well (Jiri Olsa).

. Check compatible symtab type before loading dso (Namhyung Kim)

. Check return value of filename__read_debuglink() (Stephane Eranian)

Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>

----------------------------------------------------------------
Arnaldo Carvalho de Melo (1):
      perf tools: Warn the user about how to enable libunwind support

Jiri Olsa (9):
      perf tests: Fix *.o make tests
      perf tests: Add pmu-bison.o make test
      perf tools: Fix bison OUTPUT directories dependency
      perf tools: Factor features display code
      perf tools: Add variable display for VF make output
      perf tools: Add feature check for libdw dwarf unwind
      perf tools: Add libdw DWARF post unwind support
      perf tools: Setup default dwarf post unwinder
      perf tests: Add NO_LIBDW_DWARF_UNWIND make test

Namhyung Kim (1):
      perf symbols: Check compatible symtab type before loading dso

Stephane Eranian (1):
      perf symbols: Check return value of filename__read_debuglink()

 tools/perf/Makefile.perf                           |  24 ++-
 tools/perf/arch/x86/Makefile                       |   5 +
 tools/perf/arch/x86/util/unwind-libdw.c            |  51 +++++
 tools/perf/config/Makefile                         | 232 +++++++++++++++------
 tools/perf/config/feature-checks/Makefile          |   6 +-
 tools/perf/config/feature-checks/test-all.c        |   5 +
 .../feature-checks/test-libdw-dwarf-unwind.c       |  13 ++
 tools/perf/tests/make                              |  25 ++-
 tools/perf/util/dso.c                              |   4 +-
 tools/perf/util/symbol-elf.c                       |   2 +
 tools/perf/util/symbol.c                           |  61 +++++-
 tools/perf/util/unwind-libdw.c                     | 210 +++++++++++++++++++
 tools/perf/util/unwind-libdw.h                     |  21 ++
 13 files changed, 569 insertions(+), 90 deletions(-)
 create mode 100644 tools/perf/arch/x86/util/unwind-libdw.c
 create mode 100644 tools/perf/config/feature-checks/test-libdw-dwarf-unwind.c
 create mode 100644 tools/perf/util/unwind-libdw.c
 create mode 100644 tools/perf/util/unwind-libdw.h

Re: [GIT PULL 00/12] perf/core improvements and fixes

[Ingo Molnar]

* Arnaldo Carvalho de Melo <acme@infradead.org> wrote:

> From: Arnaldo Carvalho de Melo <acme@ghostprotocols.net>
> 
> Hi Ingo,
> 
> 	Please consider pulling,
> 
> - Arnaldo
> 
> The following changes since commit 7e74efcf76c16f851df5c838c143c4a1865ea9fa:
> 
>   Merge tag 'perf-core-for-mingo' of git://git.kernel.org/pub/scm/linux/kernel/git/acme/linux into perf/core (2014-02-22 17:26:24 +0100)
> 
> are available in the git repository at:
> 
> 
>   git://git.kernel.org/pub/scm/linux/kernel/git/acme/linux tags/perf-core-for-mingo
> 
> for you to fetch changes up to 1029f9fedf87fa6f52096991588fa54ffd159584:
> 
>   perf symbols: Check compatible symtab type before loading dso (2014-02-24 16:25:01 -0300)
> 
> ----------------------------------------------------------------
> perf/core improvements and fixes
> 
> . Add support for the new DWARF unwinder library in elfutils (Jiri Olsa)
> 
> . Fix build race in the generation of bison files (Jiri Olsa)
> 
> . Further streamline the feature detection display, trimming it a bit to
>   show just the libraries detected, using VF=1 gets a more verbose output,
>   showing the less interesting feature checks as well (Jiri Olsa).
> 
> . Check compatible symtab type before loading dso (Namhyung Kim)
> 
> . Check return value of filename__read_debuglink() (Stephane Eranian)
> 
> Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
> 
> ----------------------------------------------------------------
> Arnaldo Carvalho de Melo (1):
>       perf tools: Warn the user about how to enable libunwind support
> 
> Jiri Olsa (9):
>       perf tests: Fix *.o make tests
>       perf tests: Add pmu-bison.o make test
>       perf tools: Fix bison OUTPUT directories dependency
>       perf tools: Factor features display code
>       perf tools: Add variable display for VF make output
>       perf tools: Add feature check for libdw dwarf unwind
>       perf tools: Add libdw DWARF post unwind support
>       perf tools: Setup default dwarf post unwinder
>       perf tests: Add NO_LIBDW_DWARF_UNWIND make test
> 
> Namhyung Kim (1):
>       perf symbols: Check compatible symtab type before loading dso
> 
> Stephane Eranian (1):
>       perf symbols: Check return value of filename__read_debuglink()
> 
>  tools/perf/Makefile.perf                           |  24 ++-
>  tools/perf/arch/x86/Makefile                       |   5 +
>  tools/perf/arch/x86/util/unwind-libdw.c            |  51 +++++
>  tools/perf/config/Makefile                         | 232 +++++++++++++++------
>  tools/perf/config/feature-checks/Makefile          |   6 +-
>  tools/perf/config/feature-checks/test-all.c        |   5 +
>  .../feature-checks/test-libdw-dwarf-unwind.c       |  13 ++
>  tools/perf/tests/make                              |  25 ++-
>  tools/perf/util/dso.c                              |   4 +-
>  tools/perf/util/symbol-elf.c                       |   2 +
>  tools/perf/util/symbol.c                           |  61 +++++-
>  tools/perf/util/unwind-libdw.c                     | 210 +++++++++++++++++++
>  tools/perf/util/unwind-libdw.h                     |  21 ++
>  13 files changed, 569 insertions(+), 90 deletions(-)
>  create mode 100644 tools/perf/arch/x86/util/unwind-libdw.c
>  create mode 100644 tools/perf/config/feature-checks/test-libdw-dwarf-unwind.c
>  create mode 100644 tools/perf/util/unwind-libdw.c
>  create mode 100644 tools/perf/util/unwind-libdw.h

Pulled, thanks a lot Arnaldo!

Btw., the build output looks weird now - on a system that used to pass 
all feature tests there's this output:

  BUILD:   Doing 'make -j12' parallel build
config/Makefile:288: No libdw DWARF unwind found, Please install 
elfutils-devel/libdw-dev >= 0.158 and/or set LIBDW_DIR

Auto-detecting system features:
...                         dwarf: [ on  ]
...                         glibc: [ on  ]
...                          gtk2: [ on  ]
...                      libaudit: [ on  ]
...                        libbfd: [ on  ]
...                        libelf: [ on  ]
...                       libnuma: [ on  ]
...                       libperl: [ on  ]
...                     libpython: [ on  ]
...                      libslang: [ on  ]
...                     libunwind: [ on  ]
...            libdw-dwarf-unwind: [ OFF ]
...     DWARF post unwind library: libunwind

but:

   Package elfutils-devel-0.156-5.fc19.x86_64 already installed and latest version

Also, the information content of this line is unclear to me:

...     DWARF post unwind library: libunwind


what does that line want to tell?

Thanks,

	Ingo

Re: [GIT PULL 00/12] perf/core improvements and fixes

[Jiri Olsa]

On Thu, Feb 27, 2014 at 12:46:58PM +0100, Ingo Molnar wrote:
> 
> * Arnaldo Carvalho de Melo <acme@infradead.org> wrote:
> 
> > From: Arnaldo Carvalho de Melo <acme@ghostprotocols.net>
> > 
> > Hi Ingo,
> > 
> > 	Please consider pulling,
> > 
> > - Arnaldo
> > 
> > The following changes since commit 7e74efcf76c16f851df5c838c143c4a1865ea9fa:
> > 
> >   Merge tag 'perf-core-for-mingo' of git://git.kernel.org/pub/scm/linux/kernel/git/acme/linux into perf/core (2014-02-22 17:26:24 +0100)
> > 
> > are available in the git repository at:
> > 
> > 
> >   git://git.kernel.org/pub/scm/linux/kernel/git/acme/linux tags/perf-core-for-mingo
> > 
> > for you to fetch changes up to 1029f9fedf87fa6f52096991588fa54ffd159584:
> > 
> >   perf symbols: Check compatible symtab type before loading dso (2014-02-24 16:25:01 -0300)
> > 
> > ----------------------------------------------------------------
> > perf/core improvements and fixes
> > 
> > . Add support for the new DWARF unwinder library in elfutils (Jiri Olsa)
> > 
> > . Fix build race in the generation of bison files (Jiri Olsa)
> > 
> > . Further streamline the feature detection display, trimming it a bit to
> >   show just the libraries detected, using VF=1 gets a more verbose output,
> >   showing the less interesting feature checks as well (Jiri Olsa).
> > 
> > . Check compatible symtab type before loading dso (Namhyung Kim)
> > 
> > . Check return value of filename__read_debuglink() (Stephane Eranian)
> > 
> > Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
> > 
> > ----------------------------------------------------------------
> > Arnaldo Carvalho de Melo (1):
> >       perf tools: Warn the user about how to enable libunwind support
> > 
> > Jiri Olsa (9):
> >       perf tests: Fix *.o make tests
> >       perf tests: Add pmu-bison.o make test
> >       perf tools: Fix bison OUTPUT directories dependency
> >       perf tools: Factor features display code
> >       perf tools: Add variable display for VF make output
> >       perf tools: Add feature check for libdw dwarf unwind
> >       perf tools: Add libdw DWARF post unwind support
> >       perf tools: Setup default dwarf post unwinder
> >       perf tests: Add NO_LIBDW_DWARF_UNWIND make test
> > 
> > Namhyung Kim (1):
> >       perf symbols: Check compatible symtab type before loading dso
> > 
> > Stephane Eranian (1):
> >       perf symbols: Check return value of filename__read_debuglink()
> > 
> >  tools/perf/Makefile.perf                           |  24 ++-
> >  tools/perf/arch/x86/Makefile                       |   5 +
> >  tools/perf/arch/x86/util/unwind-libdw.c            |  51 +++++
> >  tools/perf/config/Makefile                         | 232 +++++++++++++++------
> >  tools/perf/config/feature-checks/Makefile          |   6 +-
> >  tools/perf/config/feature-checks/test-all.c        |   5 +
> >  .../feature-checks/test-libdw-dwarf-unwind.c       |  13 ++
> >  tools/perf/tests/make                              |  25 ++-
> >  tools/perf/util/dso.c                              |   4 +-
> >  tools/perf/util/symbol-elf.c                       |   2 +
> >  tools/perf/util/symbol.c                           |  61 +++++-
> >  tools/perf/util/unwind-libdw.c                     | 210 +++++++++++++++++++
> >  tools/perf/util/unwind-libdw.h                     |  21 ++
> >  13 files changed, 569 insertions(+), 90 deletions(-)
> >  create mode 100644 tools/perf/arch/x86/util/unwind-libdw.c
> >  create mode 100644 tools/perf/config/feature-checks/test-libdw-dwarf-unwind.c
> >  create mode 100644 tools/perf/util/unwind-libdw.c
> >  create mode 100644 tools/perf/util/unwind-libdw.h
> 
> Pulled, thanks a lot Arnaldo!
> 
> Btw., the build output looks weird now - on a system that used to pass 
> all feature tests there's this output:
> 
>   BUILD:   Doing 'make -j12' parallel build
> config/Makefile:288: No libdw DWARF unwind found, Please install 
> elfutils-devel/libdw-dev >= 0.158 and/or set LIBDW_DIR
> 
> Auto-detecting system features:
> ...                         dwarf: [ on  ]
> ...                         glibc: [ on  ]
> ...                          gtk2: [ on  ]
> ...                      libaudit: [ on  ]
> ...                        libbfd: [ on  ]
> ...                        libelf: [ on  ]
> ...                       libnuma: [ on  ]
> ...                       libperl: [ on  ]
> ...                     libpython: [ on  ]
> ...                      libslang: [ on  ]
> ...                     libunwind: [ on  ]
> ...            libdw-dwarf-unwind: [ OFF ]
> ...     DWARF post unwind library: libunwind
> 
> but:
> 
>    Package elfutils-devel-0.156-5.fc19.x86_64 already installed and latest version
> 
> Also, the information content of this line is unclear to me:
> 
> ...     DWARF post unwind library: libunwind
> 
> 
> what does that line want to tell?

this tells what DWARF unwind library is compiled
in.. 'libunwind' in this case

the other choice is 'libdw', which was not detected
in your case (and thats what the 1st message tells you)

we discussed with Arnaldo, that we would not display warnings
for missing features by default.. only tell that there are
missing features and display them for verbose (VF=1) output

jirka

Re: [GIT PULL 00/12] perf/core improvements and fixes

[Jiri Olsa]

On Thu, Feb 27, 2014 at 12:46:58PM +0100, Ingo Molnar wrote:
> 
> * Arnaldo Carvalho de Melo <acme@infradead.org> wrote:
> 
> > From: Arnaldo Carvalho de Melo <acme@ghostprotocols.net>
> > 
> > Hi Ingo,
> > 
> > 	Please consider pulling,
> > 
> > - Arnaldo
> > 
> > The following changes since commit 7e74efcf76c16f851df5c838c143c4a1865ea9fa:
> > 
> >   Merge tag 'perf-core-for-mingo' of git://git.kernel.org/pub/scm/linux/kernel/git/acme/linux into perf/core (2014-02-22 17:26:24 +0100)
> > 
> > are available in the git repository at:
> > 
> > 
> >   git://git.kernel.org/pub/scm/linux/kernel/git/acme/linux tags/perf-core-for-mingo
> > 
> > for you to fetch changes up to 1029f9fedf87fa6f52096991588fa54ffd159584:
> > 
> >   perf symbols: Check compatible symtab type before loading dso (2014-02-24 16:25:01 -0300)
> > 
> > ----------------------------------------------------------------
> > perf/core improvements and fixes
> > 
> > . Add support for the new DWARF unwinder library in elfutils (Jiri Olsa)
> > 
> > . Fix build race in the generation of bison files (Jiri Olsa)
> > 
> > . Further streamline the feature detection display, trimming it a bit to
> >   show just the libraries detected, using VF=1 gets a more verbose output,
> >   showing the less interesting feature checks as well (Jiri Olsa).
> > 
> > . Check compatible symtab type before loading dso (Namhyung Kim)
> > 
> > . Check return value of filename__read_debuglink() (Stephane Eranian)
> > 
> > Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
> > 
> > ----------------------------------------------------------------
> > Arnaldo Carvalho de Melo (1):
> >       perf tools: Warn the user about how to enable libunwind support
> > 
> > Jiri Olsa (9):
> >       perf tests: Fix *.o make tests
> >       perf tests: Add pmu-bison.o make test
> >       perf tools: Fix bison OUTPUT directories dependency
> >       perf tools: Factor features display code
> >       perf tools: Add variable display for VF make output
> >       perf tools: Add feature check for libdw dwarf unwind
> >       perf tools: Add libdw DWARF post unwind support
> >       perf tools: Setup default dwarf post unwinder
> >       perf tests: Add NO_LIBDW_DWARF_UNWIND make test
> > 
> > Namhyung Kim (1):
> >       perf symbols: Check compatible symtab type before loading dso
> > 
> > Stephane Eranian (1):
> >       perf symbols: Check return value of filename__read_debuglink()
> > 
> >  tools/perf/Makefile.perf                           |  24 ++-
> >  tools/perf/arch/x86/Makefile                       |   5 +
> >  tools/perf/arch/x86/util/unwind-libdw.c            |  51 +++++
> >  tools/perf/config/Makefile                         | 232 +++++++++++++++------
> >  tools/perf/config/feature-checks/Makefile          |   6 +-
> >  tools/perf/config/feature-checks/test-all.c        |   5 +
> >  .../feature-checks/test-libdw-dwarf-unwind.c       |  13 ++
> >  tools/perf/tests/make                              |  25 ++-
> >  tools/perf/util/dso.c                              |   4 +-
> >  tools/perf/util/symbol-elf.c                       |   2 +
> >  tools/perf/util/symbol.c                           |  61 +++++-
> >  tools/perf/util/unwind-libdw.c                     | 210 +++++++++++++++++++
> >  tools/perf/util/unwind-libdw.h                     |  21 ++
> >  13 files changed, 569 insertions(+), 90 deletions(-)
> >  create mode 100644 tools/perf/arch/x86/util/unwind-libdw.c
> >  create mode 100644 tools/perf/config/feature-checks/test-libdw-dwarf-unwind.c
> >  create mode 100644 tools/perf/util/unwind-libdw.c
> >  create mode 100644 tools/perf/util/unwind-libdw.h
> 
> Pulled, thanks a lot Arnaldo!
> 
> Btw., the build output looks weird now - on a system that used to pass 
> all feature tests there's this output:
> 
>   BUILD:   Doing 'make -j12' parallel build
> config/Makefile:288: No libdw DWARF unwind found, Please install 
> elfutils-devel/libdw-dev >= 0.158 and/or set LIBDW_DIR
> 
> Auto-detecting system features:
> ...                         dwarf: [ on  ]
> ...                         glibc: [ on  ]
> ...                          gtk2: [ on  ]
> ...                      libaudit: [ on  ]
> ...                        libbfd: [ on  ]
> ...                        libelf: [ on  ]
> ...                       libnuma: [ on  ]
> ...                       libperl: [ on  ]
> ...                     libpython: [ on  ]
> ...                      libslang: [ on  ]
> ...                     libunwind: [ on  ]
> ...            libdw-dwarf-unwind: [ OFF ]
> ...     DWARF post unwind library: libunwind
> 
> but:
> 
>    Package elfutils-devel-0.156-5.fc19.x86_64 already installed and latest version

forgot.. remote unwind in libdw is supported from version 0.158,
which I guess wasn't updated in FC19 yet

jirka

Re: [GIT PULL 00/12] perf/core improvements and fixes

[Ingo Molnar]

* Jiri Olsa <jolsa@redhat.com> wrote:

> On Thu, Feb 27, 2014 at 12:46:58PM +0100, Ingo Molnar wrote:
> > 
> > * Arnaldo Carvalho de Melo <acme@infradead.org> wrote:
> > 
> > > From: Arnaldo Carvalho de Melo <acme@ghostprotocols.net>
> > > 
> > > Hi Ingo,
> > > 
> > > 	Please consider pulling,
> > > 
> > > - Arnaldo
> > > 
> > > The following changes since commit 7e74efcf76c16f851df5c838c143c4a1865ea9fa:
> > > 
> > >   Merge tag 'perf-core-for-mingo' of git://git.kernel.org/pub/scm/linux/kernel/git/acme/linux into perf/core (2014-02-22 17:26:24 +0100)
> > > 
> > > are available in the git repository at:
> > > 
> > > 
> > >   git://git.kernel.org/pub/scm/linux/kernel/git/acme/linux tags/perf-core-for-mingo
> > > 
> > > for you to fetch changes up to 1029f9fedf87fa6f52096991588fa54ffd159584:
> > > 
> > >   perf symbols: Check compatible symtab type before loading dso (2014-02-24 16:25:01 -0300)
> > > 
> > > ----------------------------------------------------------------
> > > perf/core improvements and fixes
> > > 
> > > . Add support for the new DWARF unwinder library in elfutils (Jiri Olsa)
> > > 
> > > . Fix build race in the generation of bison files (Jiri Olsa)
> > > 
> > > . Further streamline the feature detection display, trimming it a bit to
> > >   show just the libraries detected, using VF=1 gets a more verbose output,
> > >   showing the less interesting feature checks as well (Jiri Olsa).
> > > 
> > > . Check compatible symtab type before loading dso (Namhyung Kim)
> > > 
> > > . Check return value of filename__read_debuglink() (Stephane Eranian)
> > > 
> > > Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
> > > 
> > > ----------------------------------------------------------------
> > > Arnaldo Carvalho de Melo (1):
> > >       perf tools: Warn the user about how to enable libunwind support
> > > 
> > > Jiri Olsa (9):
> > >       perf tests: Fix *.o make tests
> > >       perf tests: Add pmu-bison.o make test
> > >       perf tools: Fix bison OUTPUT directories dependency
> > >       perf tools: Factor features display code
> > >       perf tools: Add variable display for VF make output
> > >       perf tools: Add feature check for libdw dwarf unwind
> > >       perf tools: Add libdw DWARF post unwind support
> > >       perf tools: Setup default dwarf post unwinder
> > >       perf tests: Add NO_LIBDW_DWARF_UNWIND make test
> > > 
> > > Namhyung Kim (1):
> > >       perf symbols: Check compatible symtab type before loading dso
> > > 
> > > Stephane Eranian (1):
> > >       perf symbols: Check return value of filename__read_debuglink()
> > > 
> > >  tools/perf/Makefile.perf                           |  24 ++-
> > >  tools/perf/arch/x86/Makefile                       |   5 +
> > >  tools/perf/arch/x86/util/unwind-libdw.c            |  51 +++++
> > >  tools/perf/config/Makefile                         | 232 +++++++++++++++------
> > >  tools/perf/config/feature-checks/Makefile          |   6 +-
> > >  tools/perf/config/feature-checks/test-all.c        |   5 +
> > >  .../feature-checks/test-libdw-dwarf-unwind.c       |  13 ++
> > >  tools/perf/tests/make                              |  25 ++-
> > >  tools/perf/util/dso.c                              |   4 +-
> > >  tools/perf/util/symbol-elf.c                       |   2 +
> > >  tools/perf/util/symbol.c                           |  61 +++++-
> > >  tools/perf/util/unwind-libdw.c                     | 210 +++++++++++++++++++
> > >  tools/perf/util/unwind-libdw.h                     |  21 ++
> > >  13 files changed, 569 insertions(+), 90 deletions(-)
> > >  create mode 100644 tools/perf/arch/x86/util/unwind-libdw.c
> > >  create mode 100644 tools/perf/config/feature-checks/test-libdw-dwarf-unwind.c
> > >  create mode 100644 tools/perf/util/unwind-libdw.c
> > >  create mode 100644 tools/perf/util/unwind-libdw.h
> > 
> > Pulled, thanks a lot Arnaldo!
> > 
> > Btw., the build output looks weird now - on a system that used to pass 
> > all feature tests there's this output:
> > 
> >   BUILD:   Doing 'make -j12' parallel build
> > config/Makefile:288: No libdw DWARF unwind found, Please install 
> > elfutils-devel/libdw-dev >= 0.158 and/or set LIBDW_DIR
> > 
> > Auto-detecting system features:
> > ...                         dwarf: [ on  ]
> > ...                         glibc: [ on  ]
> > ...                          gtk2: [ on  ]
> > ...                      libaudit: [ on  ]
> > ...                        libbfd: [ on  ]
> > ...                        libelf: [ on  ]
> > ...                       libnuma: [ on  ]
> > ...                       libperl: [ on  ]
> > ...                     libpython: [ on  ]
> > ...                      libslang: [ on  ]
> > ...                     libunwind: [ on  ]
> > ...            libdw-dwarf-unwind: [ OFF ]
> > ...     DWARF post unwind library: libunwind
> > 
> > but:
> > 
> >    Package elfutils-devel-0.156-5.fc19.x86_64 already installed and latest version
> > 
> > Also, the information content of this line is unclear to me:
> > 
> > ...     DWARF post unwind library: libunwind
> > 
> > 
> > what does that line want to tell?
> 
> this tells what DWARF unwind library is compiled
> in.. 'libunwind' in this case

So my (stylistic) complaint is that it's really reading weird in a 
table generated with the following purpose:

      Auto-detecting system features:

Also, we already know that libunwind is present, because just in the 
line before it, it says:

    ...                     libunwind: [ on  ]

So it's doubly confusing. How about not displaying that line at all? 
Is there a strong reason to not keep 'OFF' messages on a single line?

> the other choice is 'libdw', which was not detected in your case 
> (and thats what the 1st message tells you)
> 
> we discussed with Arnaldo, that we would not display warnings for 
> missing features by default.. only tell that there are missing 
> features and display them for verbose (VF=1) output

That's probably a good plan. I'd suggest the following 'short log' for 
failures:

     # Auto-detecting system features: 2 libraries are missing. Try 'make VF=1' for a verbose list.

I.e. that way people can notice if the count goes up or down after an 
update. Also, that too should be a single line, so that it does not 
spam people.

Thanks,

	Ingo

Re: [GIT PULL 00/12] perf/core improvements and fixes

[Jiri Olsa]

On Thu, Feb 27, 2014 at 01:30:52PM +0100, Ingo Molnar wrote:
> 
> * Jiri Olsa <jolsa@redhat.com> wrote:
> 
> > On Thu, Feb 27, 2014 at 12:46:58PM +0100, Ingo Molnar wrote:
> > > 
> > > * Arnaldo Carvalho de Melo <acme@infradead.org> wrote:
> > > 
> > > > From: Arnaldo Carvalho de Melo <acme@ghostprotocols.net>
> > > > 

SNIP

> > > Pulled, thanks a lot Arnaldo!
> > > 
> > > Btw., the build output looks weird now - on a system that used to pass 
> > > all feature tests there's this output:
> > > 
> > >   BUILD:   Doing 'make -j12' parallel build
> > > config/Makefile:288: No libdw DWARF unwind found, Please install 
> > > elfutils-devel/libdw-dev >= 0.158 and/or set LIBDW_DIR
> > > 
> > > Auto-detecting system features:
> > > ...                         dwarf: [ on  ]
> > > ...                         glibc: [ on  ]
> > > ...                          gtk2: [ on  ]
> > > ...                      libaudit: [ on  ]
> > > ...                        libbfd: [ on  ]
> > > ...                        libelf: [ on  ]
> > > ...                       libnuma: [ on  ]
> > > ...                       libperl: [ on  ]
> > > ...                     libpython: [ on  ]
> > > ...                      libslang: [ on  ]
> > > ...                     libunwind: [ on  ]
> > > ...            libdw-dwarf-unwind: [ OFF ]
> > > ...     DWARF post unwind library: libunwind
> > > 
> > > but:
> > > 
> > >    Package elfutils-devel-0.156-5.fc19.x86_64 already installed and latest version
> > > 
> > > Also, the information content of this line is unclear to me:
> > > 
> > > ...     DWARF post unwind library: libunwind
> > > 
> > > 
> > > what does that line want to tell?
> > 
> > this tells what DWARF unwind library is compiled
> > in.. 'libunwind' in this case
> 
> So my (stylistic) complaint is that it's really reading weird in a 
> table generated with the following purpose:
> 
>       Auto-detecting system features:
> 
> Also, we already know that libunwind is present, because just in the 
> line before it, it says:
> 
>     ...                     libunwind: [ on  ]
> 
> So it's doubly confusing. How about not displaying that line at all? 
> Is there a strong reason to not keep 'OFF' messages on a single line?

well, on/OFF lines are only about detecting libs

this line:
'DWARF post unwind library: libunwind'

is about telling which one goes in.. could be you have both
libraries detected and need to choose one or keep default

> 
> > the other choice is 'libdw', which was not detected in your case 
> > (and thats what the 1st message tells you)
> > 
> > we discussed with Arnaldo, that we would not display warnings for 
> > missing features by default.. only tell that there are missing 
> > features and display them for verbose (VF=1) output
> 
> That's probably a good plan. I'd suggest the following 'short log' for 
> failures:
> 
>      # Auto-detecting system features: 2 libraries are missing. Try 'make VF=1' for a verbose list.
> 
> I.e. that way people can notice if the count goes up or down after an 
> update. Also, that too should be a single line, so that it does not 
> spam people.

ook

jirka

Re: [GIT PULL 00/12] perf/core improvements and fixes

[Ingo Molnar]

* Jiri Olsa <jolsa@redhat.com> wrote:

> On Thu, Feb 27, 2014 at 01:30:52PM +0100, Ingo Molnar wrote:
> > 
> > * Jiri Olsa <jolsa@redhat.com> wrote:
> > 
> > > On Thu, Feb 27, 2014 at 12:46:58PM +0100, Ingo Molnar wrote:
> > > > 
> > > > * Arnaldo Carvalho de Melo <acme@infradead.org> wrote:
> > > > 
> > > > > From: Arnaldo Carvalho de Melo <acme@ghostprotocols.net>
> > > > > 
> 
> SNIP
> 
> > > > Pulled, thanks a lot Arnaldo!
> > > > 
> > > > Btw., the build output looks weird now - on a system that used to pass 
> > > > all feature tests there's this output:
> > > > 
> > > >   BUILD:   Doing 'make -j12' parallel build
> > > > config/Makefile:288: No libdw DWARF unwind found, Please install 
> > > > elfutils-devel/libdw-dev >= 0.158 and/or set LIBDW_DIR
> > > > 
> > > > Auto-detecting system features:
> > > > ...                         dwarf: [ on  ]
> > > > ...                         glibc: [ on  ]
> > > > ...                          gtk2: [ on  ]
> > > > ...                      libaudit: [ on  ]
> > > > ...                        libbfd: [ on  ]
> > > > ...                        libelf: [ on  ]
> > > > ...                       libnuma: [ on  ]
> > > > ...                       libperl: [ on  ]
> > > > ...                     libpython: [ on  ]
> > > > ...                      libslang: [ on  ]
> > > > ...                     libunwind: [ on  ]
> > > > ...            libdw-dwarf-unwind: [ OFF ]
> > > > ...     DWARF post unwind library: libunwind
> > > > 
> > > > but:
> > > > 
> > > >    Package elfutils-devel-0.156-5.fc19.x86_64 already installed and latest version
> > > > 
> > > > Also, the information content of this line is unclear to me:
> > > > 
> > > > ...     DWARF post unwind library: libunwind
> > > > 
> > > > 
> > > > what does that line want to tell?
> > > 
> > > this tells what DWARF unwind library is compiled
> > > in.. 'libunwind' in this case
> > 
> > So my (stylistic) complaint is that it's really reading weird in a 
> > table generated with the following purpose:
> > 
> >       Auto-detecting system features:
> > 
> > Also, we already know that libunwind is present, because just in the 
> > line before it, it says:
> > 
> >     ...                     libunwind: [ on  ]
> > 
> > So it's doubly confusing. How about not displaying that line at all? 
> > Is there a strong reason to not keep 'OFF' messages on a single line?
> 
> well, on/OFF lines are only about detecting libs
> 
> this line:
> 'DWARF post unwind library: libunwind'
> 
> is about telling which one goes in.. could be you have both
> libraries detected and need to choose one or keep default

Okay - but that is not at all clear from the output.

Thanks,

	Ingo

[GIT PULL 00/12] perf/core improvements and fixes

[Arnaldo Carvalho de Melo]

Hi Ingo,

	Please consider pulling,

- Arnaldo

The following changes since commit 4e6e311e596eadba30d4f56f64eae7d45611a01c:

  Merge tag 'perf-core-for-mingo' of git://git.kernel.org/pub/scm/linux/kernel/git/acme/linux into perf/core (2014-11-20 08:32:01 +0100)

are available in the git repository at:


  git://git.kernel.org/pub/scm/linux/kernel/git/acme/linux.git tags/perf-core-for-mingo

for you to fetch changes up to 1d9e446b91e182055d874fbb30150aad479a4981:

  perf tools: Add snapshot format file parsing (2014-11-24 18:03:51 -0300)

----------------------------------------------------------------
perf/core improvements and fixes:

User visible:

- Callchain improvements from Andi Kleen including:
  * Enable printing the srcline in the history
  * Make get_srcline fall back to sym+offset

- Allow to force redirect pr_debug to stderr. (Andi Kleen)

- TUI hist_entry browser fixes, including showing missing overhead
  value for first level callchain. Detected comparing the output of
  --stdio/--gui (that matched) with --tui, that had this problem. (Namhyung Kim)

- Fix segfault due to invalid kernel dso access (Namhyung Kim)

Infrastructure:

- Move bfd_demangle stubbing to its only user (Arnaldo Carvalho de Melo)

- 'perf stat' refactorings, moving stuff from it to evsel.c to use in
  per-pkg/snapshot format changes (Jiri Olsa)

- Add per-pkg format file parsing (Matt Fleming)

Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>

----------------------------------------------------------------
Andi Kleen (3):
      perf callchain: Enable printing the srcline in the history
      perf callchain: Make get_srcline fall back to sym+offset
      perf tools: Allow to force redirect pr_debug to stderr.

Arnaldo Carvalho de Melo (1):
      perf symbols: Move bfd_demangle stubbing to its only user

Jiri Olsa (4):
      perf evsel: Introduce perf_evsel__compute_deltas function
      perf evsel: Introduce perf_counts_values__scale function
      perf evsel: Introduce perf_evsel__read_cb function
      perf tools: Add snapshot format file parsing

Matt Fleming (1):
      perf tools: Add per-pkg format file parsing

Namhyung Kim (3):
      perf hists browser: Print overhead percent value for first-level callchain
      perf tools: Collapse first level callchain entry if it has sibling
      perf tools: Fix segfault due to invalid kernel dso access

 tools/perf/ui/browsers/hists.c | 25 +++++++++++---
 tools/perf/util/annotate.c     |  2 +-
 tools/perf/util/callchain.c    | 12 ++++++-
 tools/perf/util/callchain.h    |  1 +
 tools/perf/util/debug.c        |  4 ++-
 tools/perf/util/evsel.c        | 72 +++++++++++++++++++++++-----------------
 tools/perf/util/evsel.h        | 15 +++++++++
 tools/perf/util/machine.c      |  4 +--
 tools/perf/util/map.c          |  2 +-
 tools/perf/util/parse-events.c |  2 ++
 tools/perf/util/pmu.c          | 74 +++++++++++++++++++++++++++++++++++-------
 tools/perf/util/pmu.h          |  4 +++
 tools/perf/util/sort.c         |  6 ++--
 tools/perf/util/srcline.c      | 15 +++++++--
 tools/perf/util/symbol-elf.c   | 21 ++++++++++++
 tools/perf/util/symbol.h       | 21 ------------
 tools/perf/util/util.h         |  4 ++-
 17 files changed, 205 insertions(+), 79 deletions(-)

[GIT PULL 00/12] perf/core improvements and fixes

[Arnaldo Carvalho de Melo]

Hi Ingo,

	Please consider pulling, way more to process in the next days, with the
patchkit for eBPF looking good, perf stat stuff from Jiri and some new hardware
stuff from Andi.

- Arnaldo

The following changes since commit 75f80859b130a1cc84e59e71295ce2dd51fe1c81:

  perf/x86/intel/pebs: Robustify PEBS buffer drain (2015-08-04 10:17:01 +0200)

are available in the git repository at:

  git://git.kernel.org/pub/scm/linux/kernel/git/acme/linux.git tags/perf-core-for-mingo

for you to fetch changes up to f151f53aa4f54a647353e1935e4c6cef7f094dd4:

  perf tools: Fix build errors with mipsel-linux-uclibc compiler (2015-08-05 16:56:16 -0300)

----------------------------------------------------------------
perf/core improvements and fixes:

New features:

- Deref sys_enter pointer args with contents from probe:vfs_getname, showing
  pathnames instead of pointers in many syscalls in 'perf trace' (Arnaldo Carvalho de Melo)

- Make 'perf trace' write to stderr by default, just like 'strace' (Milian Woff)

Infrastructure:

- color_vfprintf() fixes (Andi Kleen, Jiri Olsa)

- Allow enabling/disabling PERF_SAMPLE_TIME per event (Kan Liang)

- Fix build errors with mipsel-linux-uclibc compiler (Petri Gynther)

Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>

----------------------------------------------------------------
Andi Kleen (1):
      perf tools: Do not include escape sequences in color_vfprintf return

Arnaldo Carvalho de Melo (6):
      perf script: No tracepoints? Don't call libtraceevent.
      perf trace: Do not show syscall tracepoint filter in the --no-syscalls case
      perf trace: Remember if the vfs_getname tracepoint/kprobe is in place
      perf trace: Use a constant for the syscall formatting buffer
      perf trace: Deref sys_enter pointer args with contents from probe:vfs_getname
      perf trace: Use vfs_getname syscall arg beautifier in more syscalls

Jiri Olsa (1):
      perf tools: Remove trail argument to color vsprintf

Kan Liang (2):
      perf tools: Per-event time support
      perf tools: Refine parse/config callchain functions

Milian Wolff (1):
      perf trace: Write to stderr by default

Petri Gynther (1):
      perf tools: Fix build errors with mipsel-linux-uclibc compiler

 tools/build/feature/test-glibc.c         |  11 ++
 tools/perf/Documentation/perf-record.txt |   4 +-
 tools/perf/builtin-record.c              |   2 +-
 tools/perf/builtin-script.c              |   3 +-
 tools/perf/builtin-trace.c               | 175 +++++++++++++++++++++++++++----
 tools/perf/util/callchain.c              |  14 +--
 tools/perf/util/callchain.h              |   2 +-
 tools/perf/util/cloexec.h                |   2 +-
 tools/perf/util/color.c                  |  21 +---
 tools/perf/util/color.h                  |   1 -
 tools/perf/util/evsel.c                  |  25 +++--
 tools/perf/util/evsel.h                  |   2 +
 tools/perf/util/parse-events.c           |  12 +++
 tools/perf/util/parse-events.h           |   1 +
 tools/perf/util/parse-events.l           |   1 +
 tools/perf/util/pmu.c                    |   2 +-
 16 files changed, 220 insertions(+), 58 deletions(-)

[GIT PULL 00/12] perf/core improvements and fixes

[Arnaldo Carvalho de Melo]

Hi Ingo,

	Please consider pulling,

- Arnaldo

The following changes since commit 4341801873e23bbecee76dabb7c111e3693b900f:

  Merge tag 'perf-core-for-mingo' of git://git.kernel.org/pub/scm/linux/kernel/git/acme/linux into perf/core (2015-10-25 09:40:31 +0100)

are available in the git repository at:

  git://git.kernel.org/pub/scm/linux/kernel/git/acme/linux.git tags/perf-core-for-mingo

for you to fetch changes up to 443f8c75e8d58d394b0e65b47e02e5cd8ed32b41:

  perf symbols: Fix endless loop in dso__split_kallsyms_for_kcore (2015-10-28 11:19:30 -0300)

----------------------------------------------------------------
perf/core improvements and fixes:

User visible:

- Enable per-event perf_event_attr.inherit setting by config terms, i.e.
  this becomes possible:

      $ perf record -e cycles/inherit/ -e instructions/no-inherit/

  This affects the default, that can be changed globally using the --no-inherit
  option.

  This fine grained control appeared in the eBPF patchkit, but this added
  flexibility may end up being useful in other scenarios (Wang Nan)

- Setup pager when printing usage and help, we have long lists of options,
  better use the pager like we do with normal tooling output, i.e. when needed,
  and including any error messages in the paged output (Namhyung Kim)

- Search for more options when passing args to -h, e.g.: (Arnaldo Carvalho de Melo)

  $ perf report -h interface

   Usage: perf report [<options>]

    --gtk    Use the GTK2 interface
    --stdio  Use the stdio interface
    --tui    Use the TUI interface

- Fix reading separate debuginfo files based on a build-id, problem
  found on a Debian system (Dima Kogan)

- Fix endless loop when splitting kallsyms symbols per section for
  handling kcore files, problem found on a s390x system (Jiri Olsa)

Infrastructure:

- Prep work for the 'perf stat record' work that will allow generating
  perf.data files with counting data in addition to the sampling mode
  we have now (Jiri Olsa)

Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>

----------------------------------------------------------------
Arnaldo Carvalho de Melo (1):
      perf tools: Search for more options when passing args to -h

Dima Kogan (2):
      perf symbols: Fix type error when reading a build-id
      perf symbols: we can now read separate debug-info files based on a build ID

Jiri Olsa (4):
      perf evsel: Move id_offset out of struct perf_evsel union member
      perf cpu_map: Add cpu_map__empty_new function
      perf stat: Cache aggregated map entries in extra cpumap
      perf symbols: Fix endless loop in dso__split_kallsyms_for_kcore

Namhyung Kim (4):
      perf tools: Improve ambiguous option help message
      perf report: Rename to --show-cpu-utilization
      perf tools: Setup pager when printing usage and help
      perf tools: Introduce usage_with_options_msg()

Wang Nan (1):
      perf tools: Enable pre-event inherit setting by config terms

 tools/perf/Documentation/perf-report.txt |  2 +-
 tools/perf/builtin-evlist.c              |  4 +--
 tools/perf/builtin-probe.c               | 20 ++++++-----
 tools/perf/builtin-record.c              | 11 +++---
 tools/perf/builtin-report.c              |  4 ++-
 tools/perf/builtin-sched.c               |  4 +--
 tools/perf/builtin-script.c              |  8 ++---
 tools/perf/builtin-stat.c                | 59 +++++++++++++++++++++++++++---
 tools/perf/util/cpumap.c                 | 17 +++++++++
 tools/perf/util/cpumap.h                 |  1 +
 tools/perf/util/evsel.c                  |  9 +++++
 tools/perf/util/evsel.h                  |  4 ++-
 tools/perf/util/parse-events.c           | 14 ++++++++
 tools/perf/util/parse-events.h           |  2 ++
 tools/perf/util/parse-events.l           |  2 ++
 tools/perf/util/parse-options.c          | 62 +++++++++++++++++++++++++-------
 tools/perf/util/parse-options.h          |  5 +++
 tools/perf/util/strbuf.c                 | 22 ++++++++----
 tools/perf/util/strbuf.h                 |  2 ++
 tools/perf/util/symbol-minimal.c         |  2 +-
 tools/perf/util/symbol.c                 | 11 +++++-
 21 files changed, 216 insertions(+), 49 deletions(-)

Re: [GIT PULL 00/12] perf/core improvements and fixes

[Ingo Molnar]

* Arnaldo Carvalho de Melo <acme@kernel.org> wrote:

> Hi Ingo,
> 
> 	Please consider pulling,
> 
> - Arnaldo
> 
> The following changes since commit 4341801873e23bbecee76dabb7c111e3693b900f:
> 
>   Merge tag 'perf-core-for-mingo' of git://git.kernel.org/pub/scm/linux/kernel/git/acme/linux into perf/core (2015-10-25 09:40:31 +0100)
> 
> are available in the git repository at:
> 
>   git://git.kernel.org/pub/scm/linux/kernel/git/acme/linux.git tags/perf-core-for-mingo
> 
> for you to fetch changes up to 443f8c75e8d58d394b0e65b47e02e5cd8ed32b41:
> 
>   perf symbols: Fix endless loop in dso__split_kallsyms_for_kcore (2015-10-28 11:19:30 -0300)
> 
> ----------------------------------------------------------------
> perf/core improvements and fixes:
> 
> User visible:
> 
> - Enable per-event perf_event_attr.inherit setting by config terms, i.e.
>   this becomes possible:
> 
>       $ perf record -e cycles/inherit/ -e instructions/no-inherit/
> 
>   This affects the default, that can be changed globally using the --no-inherit
>   option.
> 
>   This fine grained control appeared in the eBPF patchkit, but this added
>   flexibility may end up being useful in other scenarios (Wang Nan)
> 
> - Setup pager when printing usage and help, we have long lists of options,
>   better use the pager like we do with normal tooling output, i.e. when needed,
>   and including any error messages in the paged output (Namhyung Kim)
> 
> - Search for more options when passing args to -h, e.g.: (Arnaldo Carvalho de Melo)
> 
>   $ perf report -h interface
> 
>    Usage: perf report [<options>]
> 
>     --gtk    Use the GTK2 interface
>     --stdio  Use the stdio interface
>     --tui    Use the TUI interface

I love this! For example if I'd like to know what symbol related options we have, 
I only have to type:

triton:~/tip> perf top -h sym

 Usage: perf top [<options>]

    -D, --dump-symtab     dump the symbol table used for profiling
    -K, --hide_kernel_symbols
                          hide kernel symbols
    -s, --sort <key[,key2...]>
                          sort by key(s): pid, comm, dso, symbol, parent, cpu, srcline, ... Please refer the man page for the complete list.
    -U, --hide_user_symbols
                          hide user symbols
        --comms <comm[,comm...]>
                          only consider symbols in these comms
        --demangle-kernel
                          Enable kernel symbol demangling
        --dsos <dso[,dso...]>
                          only consider symbols in these dsos
        --sym-annotate <symbol name>
                          symbol to annotate
        --symbols <symbol[,symbol...]>
                          only consider these symbols

and it's a nice touch that it's searching in the parameter descriptions as well, 
not just the parameter name. Thus if I only remember some sort of keyword that's 
enough to narrow things down and figure out the option.

One small detail I noticed, for some reason the following search does not work:

  triton:~/tip> perf report -h --invert

    Usage: perf report [<options>]

It only works if I don't use the dashes:

  triton:~/tip> perf report -h invert

   Usage: perf report [<options>]

      -G, --inverted        alias for inverted call graph

... which is a bit surprising, agreed?

> - Fix reading separate debuginfo files based on a build-id, problem
>   found on a Debian system (Dima Kogan)
> 
> - Fix endless loop when splitting kallsyms symbols per section for
>   handling kcore files, problem found on a s390x system (Jiri Olsa)

Btw., is this bug specific to perf/core, or do we want it for perf/urgent as well?

> 
> Infrastructure:
> 
> - Prep work for the 'perf stat record' work that will allow generating
>   perf.data files with counting data in addition to the sampling mode
>   we have now (Jiri Olsa)
> 
> Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
> 
> ----------------------------------------------------------------
> Arnaldo Carvalho de Melo (1):
>       perf tools: Search for more options when passing args to -h
> 
> Dima Kogan (2):
>       perf symbols: Fix type error when reading a build-id
>       perf symbols: we can now read separate debug-info files based on a build ID
> 
> Jiri Olsa (4):
>       perf evsel: Move id_offset out of struct perf_evsel union member
>       perf cpu_map: Add cpu_map__empty_new function
>       perf stat: Cache aggregated map entries in extra cpumap
>       perf symbols: Fix endless loop in dso__split_kallsyms_for_kcore
> 
> Namhyung Kim (4):
>       perf tools: Improve ambiguous option help message
>       perf report: Rename to --show-cpu-utilization
>       perf tools: Setup pager when printing usage and help
>       perf tools: Introduce usage_with_options_msg()
> 
> Wang Nan (1):
>       perf tools: Enable pre-event inherit setting by config terms
> 
>  tools/perf/Documentation/perf-report.txt |  2 +-
>  tools/perf/builtin-evlist.c              |  4 +--
>  tools/perf/builtin-probe.c               | 20 ++++++-----
>  tools/perf/builtin-record.c              | 11 +++---
>  tools/perf/builtin-report.c              |  4 ++-
>  tools/perf/builtin-sched.c               |  4 +--
>  tools/perf/builtin-script.c              |  8 ++---
>  tools/perf/builtin-stat.c                | 59 +++++++++++++++++++++++++++---
>  tools/perf/util/cpumap.c                 | 17 +++++++++
>  tools/perf/util/cpumap.h                 |  1 +
>  tools/perf/util/evsel.c                  |  9 +++++
>  tools/perf/util/evsel.h                  |  4 ++-
>  tools/perf/util/parse-events.c           | 14 ++++++++
>  tools/perf/util/parse-events.h           |  2 ++
>  tools/perf/util/parse-events.l           |  2 ++
>  tools/perf/util/parse-options.c          | 62 +++++++++++++++++++++++++-------
>  tools/perf/util/parse-options.h          |  5 +++
>  tools/perf/util/strbuf.c                 | 22 ++++++++----
>  tools/perf/util/strbuf.h                 |  2 ++
>  tools/perf/util/symbol-minimal.c         |  2 +-
>  tools/perf/util/symbol.c                 | 11 +++++-
>  21 files changed, 216 insertions(+), 49 deletions(-)

Pulled, thanks a lot Arnaldo!

	Ingo

Re: [GIT PULL 00/12] perf/core improvements and fixes

[Ingo Molnar]

* Ingo Molnar <mingo@kernel.org> wrote:

> One small detail I noticed, for some reason the following search does not work:
> 
>   triton:~/tip> perf report -h --invert
> 
>     Usage: perf report [<options>]
> 

Btw., another detail, if it searches but does not try, I think we should output a 
warning to the user.

Printing something like this would be more helpful:

   triton:~/tip> perf report -h --invert
 
     Search pattern '--invert' not found amongst the parameters. To resolve this 
     use a different search pattern or use '-h' to list all parameters.

Thanks,

	Ingo

Re: [GIT PULL 00/12] perf/core improvements and fixes

[Jiri Olsa]

On Thu, Oct 29, 2015 at 10:36:36AM +0100, Ingo Molnar wrote:

SNIP

> 
> > - Fix reading separate debuginfo files based on a build-id, problem
> >   found on a Debian system (Dima Kogan)
> > 
> > - Fix endless loop when splitting kallsyms symbols per section for
> >   handling kcore files, problem found on a s390x system (Jiri Olsa)
> 
> Btw., is this bug specific to perf/core, or do we want it for perf/urgent as well?

it could go to perf/urgent as well

jirka

[GIT PULL 00/12] perf/core improvements and fixes

[Arnaldo Carvalho de Melo]

Hi Ingo,

	Please consider pulling,

- Arnaldo

The following changes since commit bebd23a2ed31d47e7dd746d3b125068aa2c42d85:

  Merge tag 'perf-core-for-mingo' of git://git.kernel.org/pub/scm/linux/kernel/git/acme/linux into perf/core (2015-10-30 10:09:37 +0100)

are available in the git repository at:

  git://git.kernel.org/pub/scm/linux/kernel/git/acme/linux.git tags/perf-core-for-mingo

for you to fetch changes up to 0014de172d228e450377d1fd079d94e67128d27f:

  perf sched latency: Fix thread pid reuse issue (2015-11-05 12:51:00 -0300)

----------------------------------------------------------------
perf/core improvements and fixes:

User visible:

- Fix 'perf top' segfault related to splitting overlapping mmaps (Jiri Olsa)

- Fix 'perf sched latency' when there is pid/tid reuse (Jiri Olsa)

- Fix documentation for 'perf trace -i' (Peter Feiner)

Infrastructure:

- Make the LINUX_VERSION_CODE define available for bpf scriptlets to use (Wang Nan)

- Pass the number of configured CPUs via the __NR_CPUS__ define to bpf scriptlets (Wang Nan)

- Fix libbpf compiler warning on CentOS 6 (Namhyung Kim)

- Only be verbose in several perf test entries, bpf included, when -v is used (Wang Nan)

- Don't run the 'build-test' entries always in the same order, the full
  set takes a long time, so sometimes we interrupt, shuffling them avoids
  running just the first same few in interrupted runs (Arnaldo Carvalho de Melo)

- Change FEATURE-DUMP to FEATURE-DUMP.libbpf in .gitignore and 'clean' make target (Yunlong Song)

- 'perf stat' refactorings to avoid duplicated code (Andi Kleen)

Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>

----------------------------------------------------------------
Andi Kleen (2):
      perf stat: Move sw clock metrics printout to stat-shadow
      perf stat: Use common printout function to avoid duplicated code

Arnaldo Carvalho de Melo (1):
      perf tools: Allow shuffling the build tests

Jiri Olsa (2):
      perf tools: Insert split maps correctly into origin group
      perf sched latency: Fix thread pid reuse issue

Namhyung Kim (1):
      tools lib bpf: Fix compiler warning on CentOS 6

Peter Feiner (1):
      perf trace: Fix documentation for -i

Wang Nan (5):
      perf test: Keep test result clean if '-v' not set
      perf bpf: Mute libbpf when '-v' not set
      perf llvm: Pass number of configured CPUs to clang compiler
      perf llvm: Pass LINUX_VERSION_CODE to BPF program when compiling
      perf tools: Fix find_perf_probe_point_from_map() which incorrectly returns success

Yunlong Song (1):
      tools lib bpf: Change FEATURE-DUMP to FEATURE-DUMP.libbpf

 tools/lib/bpf/.gitignore                |  2 +-
 tools/lib/bpf/Makefile                  |  2 +-
 tools/lib/bpf/libbpf.c                  |  4 +--
 tools/lib/bpf/libbpf.h                  |  2 +-
 tools/perf/Documentation/perf-trace.txt |  1 -
 tools/perf/Makefile                     |  2 +-
 tools/perf/builtin-sched.c              |  5 +--
 tools/perf/builtin-stat.c               | 59 +++++++++++----------------------
 tools/perf/tests/attr.c                 |  3 +-
 tools/perf/tests/code-reading.c         |  8 ++---
 tools/perf/tests/keep-tracking.c        |  4 +--
 tools/perf/tests/llvm.c                 | 11 +++---
 tools/perf/tests/make                   |  5 +++
 tools/perf/tests/switch-tracking.c      |  4 +--
 tools/perf/util/bpf-loader.c            |  4 +--
 tools/perf/util/llvm-utils.c            | 51 ++++++++++++++++++++++++----
 tools/perf/util/map.c                   | 10 ++++--
 tools/perf/util/probe-event.c           |  3 ++
 tools/perf/util/stat-shadow.c           |  5 +++
 19 files changed, 110 insertions(+), 75 deletions(-)

[GIT PULL 00/12] perf/core improvements and fixes

[Arnaldo Carvalho de Melo]

From: Arnaldo Carvalho de Melo <acme@redhat.com>

Hi Ingo,

	Please consider pulling,

- Arnaldo

The following changes since commit 3f56e687a138481894a1088d5aa7d41951bdb020:

  perf/core: Disable the event on a truncated AUX record (2016-05-12 10:14:55 +0200)

are available in the git repository at:

  git://git.kernel.org/pub/scm/linux/kernel/git/acme/linux.git tags/perf-core-for-mingo-20160516

for you to fetch changes up to a29d5c9b8167dbc21a7ca8c0302e3799f9063b4e:

  perf tools: Separate accounting of contexts and real addresses in a stack trace (2016-05-16 23:11:54 -0300)

----------------------------------------------------------------
perf/core improvements and fixes:

User visible:

- Honour the kernel.perf_event_max_stack knob more precisely by not counting
  PERF_CONTEXT_{KERNEL,USER} when deciding when to stop adding entries to
  the perf_sample->ip_callchain[] array (Arnaldo Carvalho de Melo)

- Fix identation of 'stalled-backend-cycles' in 'perf stat' (Namhyung Kim)

- Update runtime using 'cpu-clock' event in 'perf stat' (Namhyung Kim)

- Use 'cpu-clock' for cpu targets in 'perf stat' (Namhyung Kim)

- Avoid fractional digits for integer scales in 'perf stat' (Andi Kleen)

- Store vdso buildid unconditionally, as it appears in callchains and
  we're not checking those when creating the build-id table, so we
  end up not being able to resolve VDSO symbols when doing analysis
  on a different machine than the one where recording was done, possibly
  of a different arch even (arm -> x86_64) (He Kuang)

Infrastructure:

- Generalize max_stack sysctl handler, will be used for configuring
  multiple kernel knobs related to callchains (Arnaldo Carvalho de Melo)

Cleanups:

- Introduce DSO__NAME_KALLSYMS and DSO__NAME_KCORE, to stop using
  open coded strings (Masami Hiramatsu)

Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>

----------------------------------------------------------------
Andi Kleen (1):
      perf stat: Avoid fractional digits for integer scales

Arnaldo Carvalho de Melo (6):
      perf core: Generalize max_stack sysctl handler
      perf core: Pass max stack as a perf_callchain_entry context
      perf core: Add a 'nr' field to perf_event_callchain_context
      perf core: Add perf_callchain_store_context() helper
      perf core: Separate accounting of contexts and real addresses in a stack trace
      perf tools: Separate accounting of contexts and real addresses in a stack trace

He Kuang (1):
      perf symbols: Store vdso buildid unconditionally

Masami Hiramatsu (1):
      perf symbols: Introduce DSO__NAME_KALLSYMS and DSO__NAME_KCORE

Namhyung Kim (3):
      perf stat: Fix indentation of stalled backend cycle
      perf stat: Update runtime using cpu-clock event
      perf stat: Use cpu-clock event for cpu targets

 Documentation/sysctl/kernel.txt    | 14 ++++++++++++++
 arch/arc/kernel/perf_event.c       |  6 +++---
 arch/arm/kernel/perf_callchain.c   | 10 +++++-----
 arch/arm64/kernel/perf_callchain.c | 14 +++++++-------
 arch/metag/kernel/perf_callchain.c | 10 +++++-----
 arch/mips/kernel/perf_event.c      | 12 ++++++------
 arch/powerpc/perf/callchain.c      | 20 ++++++++++----------
 arch/s390/kernel/perf_event.c      |  4 ++--
 arch/sh/kernel/perf_callchain.c    |  4 ++--
 arch/sparc/kernel/perf_event.c     | 14 +++++++-------
 arch/tile/kernel/perf_event.c      |  6 +++---
 arch/x86/events/core.c             | 14 +++++++-------
 arch/xtensa/kernel/perf_event.c    | 10 +++++-----
 include/linux/perf_event.h         | 34 +++++++++++++++++++++++++++++-----
 include/uapi/linux/perf_event.h    |  1 +
 kernel/bpf/stackmap.c              |  3 ++-
 kernel/events/callchain.c          | 36 ++++++++++++++++++++++++------------
 kernel/sysctl.c                    | 11 ++++++++++-
 tools/perf/builtin-buildid-cache.c |  8 ++++----
 tools/perf/builtin-stat.c          | 22 +++++++++++++---------
 tools/perf/perf.c                  |  3 +++
 tools/perf/util/annotate.c         |  2 +-
 tools/perf/util/build-id.c         |  2 +-
 tools/perf/util/dso.c              |  3 ++-
 tools/perf/util/machine.c          | 28 ++++++++++++++++++----------
 tools/perf/util/stat-shadow.c      |  8 +++++---
 tools/perf/util/symbol.c           | 10 +++++-----
 tools/perf/util/symbol.h           |  3 +++
 tools/perf/util/util.c             |  3 ++-
 tools/perf/util/util.h             |  3 ++-
 30 files changed, 201 insertions(+), 117 deletions(-)

Re: [GIT PULL 00/12] perf/core improvements and fixes

[Ingo Molnar]

* Arnaldo Carvalho de Melo <acme@kernel.org> wrote:

> From: Arnaldo Carvalho de Melo <acme@redhat.com>
> 
> Hi Ingo,
> 
> 	Please consider pulling,
> 
> - Arnaldo
> 
> The following changes since commit 3f56e687a138481894a1088d5aa7d41951bdb020:
> 
>   perf/core: Disable the event on a truncated AUX record (2016-05-12 10:14:55 +0200)
> 
> are available in the git repository at:
> 
>   git://git.kernel.org/pub/scm/linux/kernel/git/acme/linux.git tags/perf-core-for-mingo-20160516
> 
> for you to fetch changes up to a29d5c9b8167dbc21a7ca8c0302e3799f9063b4e:
> 
>   perf tools: Separate accounting of contexts and real addresses in a stack trace (2016-05-16 23:11:54 -0300)
> 
> ----------------------------------------------------------------
> perf/core improvements and fixes:
> 
> User visible:
> 
> - Honour the kernel.perf_event_max_stack knob more precisely by not counting
>   PERF_CONTEXT_{KERNEL,USER} when deciding when to stop adding entries to
>   the perf_sample->ip_callchain[] array (Arnaldo Carvalho de Melo)
> 
> - Fix identation of 'stalled-backend-cycles' in 'perf stat' (Namhyung Kim)
> 
> - Update runtime using 'cpu-clock' event in 'perf stat' (Namhyung Kim)
> 
> - Use 'cpu-clock' for cpu targets in 'perf stat' (Namhyung Kim)
> 
> - Avoid fractional digits for integer scales in 'perf stat' (Andi Kleen)
> 
> - Store vdso buildid unconditionally, as it appears in callchains and
>   we're not checking those when creating the build-id table, so we
>   end up not being able to resolve VDSO symbols when doing analysis
>   on a different machine than the one where recording was done, possibly
>   of a different arch even (arm -> x86_64) (He Kuang)
> 
> Infrastructure:
> 
> - Generalize max_stack sysctl handler, will be used for configuring
>   multiple kernel knobs related to callchains (Arnaldo Carvalho de Melo)
> 
> Cleanups:
> 
> - Introduce DSO__NAME_KALLSYMS and DSO__NAME_KCORE, to stop using
>   open coded strings (Masami Hiramatsu)
> 
> Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
> 
> ----------------------------------------------------------------
> Andi Kleen (1):
>       perf stat: Avoid fractional digits for integer scales
> 
> Arnaldo Carvalho de Melo (6):
>       perf core: Generalize max_stack sysctl handler
>       perf core: Pass max stack as a perf_callchain_entry context
>       perf core: Add a 'nr' field to perf_event_callchain_context
>       perf core: Add perf_callchain_store_context() helper
>       perf core: Separate accounting of contexts and real addresses in a stack trace
>       perf tools: Separate accounting of contexts and real addresses in a stack trace
> 
> He Kuang (1):
>       perf symbols: Store vdso buildid unconditionally
> 
> Masami Hiramatsu (1):
>       perf symbols: Introduce DSO__NAME_KALLSYMS and DSO__NAME_KCORE
> 
> Namhyung Kim (3):
>       perf stat: Fix indentation of stalled backend cycle
>       perf stat: Update runtime using cpu-clock event
>       perf stat: Use cpu-clock event for cpu targets
> 
>  Documentation/sysctl/kernel.txt    | 14 ++++++++++++++
>  arch/arc/kernel/perf_event.c       |  6 +++---
>  arch/arm/kernel/perf_callchain.c   | 10 +++++-----
>  arch/arm64/kernel/perf_callchain.c | 14 +++++++-------
>  arch/metag/kernel/perf_callchain.c | 10 +++++-----
>  arch/mips/kernel/perf_event.c      | 12 ++++++------
>  arch/powerpc/perf/callchain.c      | 20 ++++++++++----------
>  arch/s390/kernel/perf_event.c      |  4 ++--
>  arch/sh/kernel/perf_callchain.c    |  4 ++--
>  arch/sparc/kernel/perf_event.c     | 14 +++++++-------
>  arch/tile/kernel/perf_event.c      |  6 +++---
>  arch/x86/events/core.c             | 14 +++++++-------
>  arch/xtensa/kernel/perf_event.c    | 10 +++++-----
>  include/linux/perf_event.h         | 34 +++++++++++++++++++++++++++++-----
>  include/uapi/linux/perf_event.h    |  1 +
>  kernel/bpf/stackmap.c              |  3 ++-
>  kernel/events/callchain.c          | 36 ++++++++++++++++++++++++------------
>  kernel/sysctl.c                    | 11 ++++++++++-
>  tools/perf/builtin-buildid-cache.c |  8 ++++----
>  tools/perf/builtin-stat.c          | 22 +++++++++++++---------
>  tools/perf/perf.c                  |  3 +++
>  tools/perf/util/annotate.c         |  2 +-
>  tools/perf/util/build-id.c         |  2 +-
>  tools/perf/util/dso.c              |  3 ++-
>  tools/perf/util/machine.c          | 28 ++++++++++++++++++----------
>  tools/perf/util/stat-shadow.c      |  8 +++++---
>  tools/perf/util/symbol.c           | 10 +++++-----
>  tools/perf/util/symbol.h           |  3 +++
>  tools/perf/util/util.c             |  3 ++-
>  tools/perf/util/util.h             |  3 ++-
>  30 files changed, 201 insertions(+), 117 deletions(-)

Pulled, thanks a lot Arnaldo!

	Ingo

[GIT PULL 00/12] perf/core improvements and fixes

[Arnaldo Carvalho de Melo]

Hi Ingo,

	Please consider pulling,

- Arnaldo

The following changes since commit 711460514b1c80494f14001bdf30dd70fd401a8f:

  Merge tag 'perf-urgent-for-mingo-20160527' of git://git.kernel.org/pub/scm/linux/kernel/git/acme/linux into perf/urgent (2016-05-29 20:15:37 +0200)

are available in the git repository at:

  git://git.kernel.org/pub/scm/linux/kernel/git/acme/linux.git tags/perf-core-for-mingo-20160530

for you to fetch changes up to 01412261d99497021353c4b1d67e8df6c9cdc3c6:

  perf buildid-cache: Use path/to/bin/buildid/elf instead of path/to/bin/buildid (2016-05-30 13:15:03 -0300)

----------------------------------------------------------------
perf/core improvements and fixes:

User visible/kernel ABI:

- Per event callchain limit: Recently we introduced a sysctl to tune the
  max-stack for all events for which callchains were requested:

  $ sysctl kernel.perf_event_max_stack
  kernel.perf_event_max_stack = 127

  Now this patch introduces a way to configure this per event, i.e. this
  becomes possible:

  $ perf record -e sched:*/max-stack=2/ -e block:*/max-stack=10/ -a

  allowing finer tuning of how much buffer space callchains use.

  This uses an u16 from the reserved space at the end, leaving another
  u16 for future use.

  There has been interest in even finer tuning, namely to control the
  max stack for kernel and userspace callchains separately. Further
  discussion is needed, we may for instance use the remaining u16 for
  that and when it is present, assume that the sample_max_stack introduced
  in this patch applies for the kernel, and the u16 left is used for
  limiting the userspace callchain. (Arnaldo Carvalho de Melo)

Infrastructure:

- Adopt get_main_thread from db-export.c (Andi Kleen)

- More prep work for backward ring buffer support (Wang Nan)

- Prep work for supporting SDT (Statically Defined Tracing)
  tracepoints (Masami Hiramatsu)

- Add arch/*/include/generated/ to .gitignore (Taeung Song)

Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>

----------------------------------------------------------------
Andi Kleen (1):
      perf thread: Adopt get_main_thread from db-export.c

Arnaldo Carvalho de Melo (2):
      perf core: Per event callchain limit
      perf tools: Per event max-stack settings

Masami Hiramatsu (3):
      perf symbols: Introduce filename__readable to check readability
      perf symbols: Cleanup the code flow of dso__find_kallsyms
      perf buildid-cache: Use path/to/bin/buildid/elf instead of path/to/bin/buildid

Taeung Song (1):
      perf tools: Add arch/*/include/generated/ to .gitignore

Wang Nan (5):
      perf record: Robustify perf_event__synth_time_conv()
      perf evlist: Don't poll and mmap overwritable events
      perf evlist: Check 'base' pointer before checking refcnt when put a mmap
      perf evlist: Choose correct reading direction according to evlist->backward
      tools: Pass arg to fdarray__filter's call back function

 include/linux/perf_event.h      |   2 +-
 include/uapi/linux/perf_event.h |   6 ++-
 kernel/bpf/stackmap.c           |   2 +-
 kernel/events/callchain.c       |  14 ++++-
 kernel/events/core.c            |   5 +-
 tools/lib/api/fd/array.c        |   5 +-
 tools/lib/api/fd/array.h        |   3 +-
 tools/perf/.gitignore           |   1 +
 tools/perf/arch/x86/util/tsc.c  |   2 +
 tools/perf/builtin-record.c     |   9 +++-
 tools/perf/tests/fdarray.c      |   8 +--
 tools/perf/util/build-id.c      | 115 ++++++++++++++++++++++++++++++----------
 tools/perf/util/build-id.h      |   2 +
 tools/perf/util/callchain.h     |   1 +
 tools/perf/util/db-export.c     |  13 +----
 tools/perf/util/dso.h           |   5 ++
 tools/perf/util/evlist.c        |  43 +++++++++++----
 tools/perf/util/evlist.h        |   2 +
 tools/perf/util/evsel.c         |  16 +++++-
 tools/perf/util/evsel.h         |   2 +
 tools/perf/util/parse-events.c  |   8 +++
 tools/perf/util/parse-events.h  |   1 +
 tools/perf/util/parse-events.l  |   1 +
 tools/perf/util/session.c       |   2 +
 tools/perf/util/symbol.c        |  71 ++++++++++++-------------
 tools/perf/util/thread.c        |  11 ++++
 tools/perf/util/thread.h        |   2 +
 27 files changed, 252 insertions(+), 100 deletions(-)

Re: [GIT PULL 00/12] perf/core improvements and fixes

[Ingo Molnar]

* Arnaldo Carvalho de Melo <acme@kernel.org> wrote:

> Hi Ingo,
> 
> 	Please consider pulling,
> 
> - Arnaldo
> 
> The following changes since commit 711460514b1c80494f14001bdf30dd70fd401a8f:
> 
>   Merge tag 'perf-urgent-for-mingo-20160527' of git://git.kernel.org/pub/scm/linux/kernel/git/acme/linux into perf/urgent (2016-05-29 20:15:37 +0200)
> 
> are available in the git repository at:
> 
>   git://git.kernel.org/pub/scm/linux/kernel/git/acme/linux.git tags/perf-core-for-mingo-20160530
> 
> for you to fetch changes up to 01412261d99497021353c4b1d67e8df6c9cdc3c6:
> 
>   perf buildid-cache: Use path/to/bin/buildid/elf instead of path/to/bin/buildid (2016-05-30 13:15:03 -0300)
> 
> ----------------------------------------------------------------
> perf/core improvements and fixes:
> 
> User visible/kernel ABI:
> 
> - Per event callchain limit: Recently we introduced a sysctl to tune the
>   max-stack for all events for which callchains were requested:
> 
>   $ sysctl kernel.perf_event_max_stack
>   kernel.perf_event_max_stack = 127
> 
>   Now this patch introduces a way to configure this per event, i.e. this
>   becomes possible:
> 
>   $ perf record -e sched:*/max-stack=2/ -e block:*/max-stack=10/ -a
> 
>   allowing finer tuning of how much buffer space callchains use.
> 
>   This uses an u16 from the reserved space at the end, leaving another
>   u16 for future use.
> 
>   There has been interest in even finer tuning, namely to control the
>   max stack for kernel and userspace callchains separately. Further
>   discussion is needed, we may for instance use the remaining u16 for
>   that and when it is present, assume that the sample_max_stack introduced
>   in this patch applies for the kernel, and the u16 left is used for
>   limiting the userspace callchain. (Arnaldo Carvalho de Melo)
> 
> Infrastructure:
> 
> - Adopt get_main_thread from db-export.c (Andi Kleen)
> 
> - More prep work for backward ring buffer support (Wang Nan)
> 
> - Prep work for supporting SDT (Statically Defined Tracing)
>   tracepoints (Masami Hiramatsu)
> 
> - Add arch/*/include/generated/ to .gitignore (Taeung Song)
> 
> Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
> 
> ----------------------------------------------------------------
> Andi Kleen (1):
>       perf thread: Adopt get_main_thread from db-export.c
> 
> Arnaldo Carvalho de Melo (2):
>       perf core: Per event callchain limit
>       perf tools: Per event max-stack settings
> 
> Masami Hiramatsu (3):
>       perf symbols: Introduce filename__readable to check readability
>       perf symbols: Cleanup the code flow of dso__find_kallsyms
>       perf buildid-cache: Use path/to/bin/buildid/elf instead of path/to/bin/buildid
> 
> Taeung Song (1):
>       perf tools: Add arch/*/include/generated/ to .gitignore
> 
> Wang Nan (5):
>       perf record: Robustify perf_event__synth_time_conv()
>       perf evlist: Don't poll and mmap overwritable events
>       perf evlist: Check 'base' pointer before checking refcnt when put a mmap
>       perf evlist: Choose correct reading direction according to evlist->backward
>       tools: Pass arg to fdarray__filter's call back function
> 
>  include/linux/perf_event.h      |   2 +-
>  include/uapi/linux/perf_event.h |   6 ++-
>  kernel/bpf/stackmap.c           |   2 +-
>  kernel/events/callchain.c       |  14 ++++-
>  kernel/events/core.c            |   5 +-
>  tools/lib/api/fd/array.c        |   5 +-
>  tools/lib/api/fd/array.h        |   3 +-
>  tools/perf/.gitignore           |   1 +
>  tools/perf/arch/x86/util/tsc.c  |   2 +
>  tools/perf/builtin-record.c     |   9 +++-
>  tools/perf/tests/fdarray.c      |   8 +--
>  tools/perf/util/build-id.c      | 115 ++++++++++++++++++++++++++++++----------
>  tools/perf/util/build-id.h      |   2 +
>  tools/perf/util/callchain.h     |   1 +
>  tools/perf/util/db-export.c     |  13 +----
>  tools/perf/util/dso.h           |   5 ++
>  tools/perf/util/evlist.c        |  43 +++++++++++----
>  tools/perf/util/evlist.h        |   2 +
>  tools/perf/util/evsel.c         |  16 +++++-
>  tools/perf/util/evsel.h         |   2 +
>  tools/perf/util/parse-events.c  |   8 +++
>  tools/perf/util/parse-events.h  |   1 +
>  tools/perf/util/parse-events.l  |   1 +
>  tools/perf/util/session.c       |   2 +
>  tools/perf/util/symbol.c        |  71 ++++++++++++-------------
>  tools/perf/util/thread.c        |  11 ++++
>  tools/perf/util/thread.h        |   2 +
>  27 files changed, 252 insertions(+), 100 deletions(-)

Pulled, thanks a lot Arnaldo!

	Ingo

[GIT PULL 00/12] perf/core improvements and fixes

[Arnaldo Carvalho de Melo]

Hi Ingo,

	Please consider pulling,

- Arnaldo

The following changes since commit c0b172e5b6770048751b2c0a4fe44346c2080c5d:

  Merge tag 'perf-core-for-mingo-20160901' of git://git.kernel.org/pub/scm/linux/kernel/git/acme/linux into perf/core (2016-09-05 15:15:49 +0200)

are available in the git repository at:

  git://git.kernel.org/pub/scm/linux/kernel/git/acme/linux.git tags/perf-core-for-mingo-20160908

for you to fetch changes up to 25b8592e912f085ce2ff736a2927584ddeab238c:

  perf powerpc: Fix build-test failure (2016-09-08 13:44:07 -0300)

----------------------------------------------------------------
perf/core improvements and fixes:

User visible:

- Add branch stack / basic block info to 'perf annotate --stdio', where for
  each branch, we add an asm comment after the instruction with information on
  how often it was taken and predicted. See example with color output at:

    http://vger.kernel.org/~acme/perf/annotate_basic_blocks.png

  (Peter Zijlstra)

- Only open an evsel in CPUs in its cpu map, fixing some use cases in
  systems with multiple PMUs with different CPU maps (Mark Rutland)

- Fix handling of huge TLB maps, recognizing it as anonymous (Wang Nan)

Infrastructure:

- Remove the symbol filtering code, i.e. the callbacks passed to all functions
  that could end up loading a DSO symtab, simplifying the code, eventually
  allowing what we should have had since day one: removing the 'map' parameter
  from dso__load() functions (Arnaldo Carvalho de Melo)

Arch specific build fixes:

- Fix detached tarball build on powerpc, where we were still accessing a
  file outside tools/ (Ravi Bangoria)

Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>

----------------------------------------------------------------
Arnaldo Carvalho de Melo (5):
      perf symbols: Mark if a symbol is idle in the library
      perf top: Remove old kernel-only symbol filter
      perf machine: Remove machine->symbol_filter and friends
      perf test vmlinux: Remove dead symbol_filter_t code
      perf symbols: Remove symbol_filter_t machinery

Mark Rutland (2):
      perf evlist: Only open events on CPUs an evsel permits
      perf pmu: Support alternative sysfs cpumask

Peter Zijlstra (1):
      perf annotate: Add branch stack / basic block

Ravi Bangoria (1):
      perf powerpc: Fix build-test failure

Wang Nan (3):
      perf tools: Recognize hugetlb mapping as anon mapping
      tools lib api fs: Add hugetlbfs filesystem detector
      perf record: Mark MAP_HUGETLB when synthesizing mmap events

 tools/lib/api/fs/fs.c                       |  15 ++
 tools/lib/api/fs/fs.h                       |   1 +
 tools/perf/arch/powerpc/util/sym-handling.c |   2 +-
 tools/perf/builtin-annotate.c               | 104 +++++++++
 tools/perf/builtin-inject.c                 |   2 +-
 tools/perf/builtin-kmem.c                   |  10 +-
 tools/perf/builtin-script.c                 |   4 +-
 tools/perf/builtin-top.c                    |  30 ---
 tools/perf/perf-sys.h                       |   1 -
 tools/perf/tests/code-reading.c             |   4 +-
 tools/perf/tests/vmlinux-kallsyms.c         |  17 +-
 tools/perf/ui/browsers/annotate.c           |   2 +-
 tools/perf/ui/browsers/map.c                |   4 +-
 tools/perf/util/Build                       |   1 +
 tools/perf/util/annotate.c                  |  95 +++++++-
 tools/perf/util/annotate.h                  |   1 +
 tools/perf/util/block-range.c               | 328 ++++++++++++++++++++++++++++
 tools/perf/util/block-range.h               |  71 ++++++
 tools/perf/util/event.c                     |  21 +-
 tools/perf/util/evlist.c                    |   8 +-
 tools/perf/util/intel-bts.c                 |   2 +-
 tools/perf/util/intel-pt.c                  |   4 +-
 tools/perf/util/machine.c                   |  38 +---
 tools/perf/util/machine.h                   |  34 +--
 tools/perf/util/map.c                       |  50 ++---
 tools/perf/util/map.h                       |  32 +--
 tools/perf/util/pmu.c                       |  15 +-
 tools/perf/util/probe-event.c               |  17 +-
 tools/perf/util/symbol-elf.c                |  32 +--
 tools/perf/util/symbol-minimal.c            |   4 +-
 tools/perf/util/symbol.c                    | 134 ++++++------
 tools/perf/util/symbol.h                    |  20 +-
 32 files changed, 817 insertions(+), 286 deletions(-)
 create mode 100644 tools/perf/util/block-range.c
 create mode 100644 tools/perf/util/block-range.h

Build stats:

  [root@jouet ~]# time dm
   1 69.078 alpine:3.4: Ok
   2 24.055 android-ndk:r12b-arm: Ok
   3 71.911 archlinux:latest: Ok
   4 41.209 centos:5: Ok
   5 58.240 centos:6: Ok
   6 67.238 centos:7: Ok
   7 62.040 debian:7: Ok
   8 69.061 debian:8: Ok
   9 38.124 debian:experimental: Ok
  10 67.623 fedora:20: Ok
  11 71.458 fedora:21: Ok
  12 70.807 fedora:22: Ok
  13 71.013 fedora:23: Ok
  14 73.330 fedora:24: Ok
  15 30.062 fedora:24-x-ARC-uClibc: Ok
  16 77.616 fedora:rawhide: Ok
  17 73.663 mageia:5: Ok
  18 69.264 opensuse:13.2: Ok
  19 71.532 opensuse:42.1: Ok
  20 76.282 opensuse:tumbleweed: Ok
  21 54.666 ubuntu:12.04.5: Ok
  22 37.170 ubuntu:14.04: Ok
  23 66.101 ubuntu:14.04.4: Ok
  24 68.881 ubuntu:15.10: Ok
  25 62.698 ubuntu:16.04: Ok
  26 53.046 ubuntu:16.04-x-arm: Ok
  27 51.609 ubuntu:16.04-x-arm64: Ok
  28 51.842 ubuntu:16.04-x-powerpc64: Ok
  29 53.347 ubuntu:16.04-x-powerpc64el: Ok
  30 72.280 ubuntu:16.10: Ok
  31 54.078 ubuntu:16.10-x-s390: Ok

  real	31m19.919s
  user	0m1.890s
  sys	0m2.201s
  [root@jouet ~]#

Re: [GIT PULL 00/12] perf/core improvements and fixes

[Ingo Molnar]

* Arnaldo Carvalho de Melo <acme@kernel.org> wrote:

> Hi Ingo,
> 
> 	Please consider pulling,
> 
> - Arnaldo
> 
> The following changes since commit c0b172e5b6770048751b2c0a4fe44346c2080c5d:
> 
>   Merge tag 'perf-core-for-mingo-20160901' of git://git.kernel.org/pub/scm/linux/kernel/git/acme/linux into perf/core (2016-09-05 15:15:49 +0200)
> 
> are available in the git repository at:
> 
>   git://git.kernel.org/pub/scm/linux/kernel/git/acme/linux.git tags/perf-core-for-mingo-20160908
> 
> for you to fetch changes up to 25b8592e912f085ce2ff736a2927584ddeab238c:
> 
>   perf powerpc: Fix build-test failure (2016-09-08 13:44:07 -0300)
> 
> ----------------------------------------------------------------
> perf/core improvements and fixes:
> 
> User visible:
> 
> - Add branch stack / basic block info to 'perf annotate --stdio', where for
>   each branch, we add an asm comment after the instruction with information on
>   how often it was taken and predicted. See example with color output at:
> 
>     http://vger.kernel.org/~acme/perf/annotate_basic_blocks.png
> 
>   (Peter Zijlstra)
> 
> - Only open an evsel in CPUs in its cpu map, fixing some use cases in
>   systems with multiple PMUs with different CPU maps (Mark Rutland)
> 
> - Fix handling of huge TLB maps, recognizing it as anonymous (Wang Nan)
> 
> Infrastructure:
> 
> - Remove the symbol filtering code, i.e. the callbacks passed to all functions
>   that could end up loading a DSO symtab, simplifying the code, eventually
>   allowing what we should have had since day one: removing the 'map' parameter
>   from dso__load() functions (Arnaldo Carvalho de Melo)
> 
> Arch specific build fixes:
> 
> - Fix detached tarball build on powerpc, where we were still accessing a
>   file outside tools/ (Ravi Bangoria)
> 
> Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
> 
> ----------------------------------------------------------------
> Arnaldo Carvalho de Melo (5):
>       perf symbols: Mark if a symbol is idle in the library
>       perf top: Remove old kernel-only symbol filter
>       perf machine: Remove machine->symbol_filter and friends
>       perf test vmlinux: Remove dead symbol_filter_t code
>       perf symbols: Remove symbol_filter_t machinery
> 
> Mark Rutland (2):
>       perf evlist: Only open events on CPUs an evsel permits
>       perf pmu: Support alternative sysfs cpumask
> 
> Peter Zijlstra (1):
>       perf annotate: Add branch stack / basic block
> 
> Ravi Bangoria (1):
>       perf powerpc: Fix build-test failure
> 
> Wang Nan (3):
>       perf tools: Recognize hugetlb mapping as anon mapping
>       tools lib api fs: Add hugetlbfs filesystem detector
>       perf record: Mark MAP_HUGETLB when synthesizing mmap events
> 
>  tools/lib/api/fs/fs.c                       |  15 ++
>  tools/lib/api/fs/fs.h                       |   1 +
>  tools/perf/arch/powerpc/util/sym-handling.c |   2 +-
>  tools/perf/builtin-annotate.c               | 104 +++++++++
>  tools/perf/builtin-inject.c                 |   2 +-
>  tools/perf/builtin-kmem.c                   |  10 +-
>  tools/perf/builtin-script.c                 |   4 +-
>  tools/perf/builtin-top.c                    |  30 ---
>  tools/perf/perf-sys.h                       |   1 -
>  tools/perf/tests/code-reading.c             |   4 +-
>  tools/perf/tests/vmlinux-kallsyms.c         |  17 +-
>  tools/perf/ui/browsers/annotate.c           |   2 +-
>  tools/perf/ui/browsers/map.c                |   4 +-
>  tools/perf/util/Build                       |   1 +
>  tools/perf/util/annotate.c                  |  95 +++++++-
>  tools/perf/util/annotate.h                  |   1 +
>  tools/perf/util/block-range.c               | 328 ++++++++++++++++++++++++++++
>  tools/perf/util/block-range.h               |  71 ++++++
>  tools/perf/util/event.c                     |  21 +-
>  tools/perf/util/evlist.c                    |   8 +-
>  tools/perf/util/intel-bts.c                 |   2 +-
>  tools/perf/util/intel-pt.c                  |   4 +-
>  tools/perf/util/machine.c                   |  38 +---
>  tools/perf/util/machine.h                   |  34 +--
>  tools/perf/util/map.c                       |  50 ++---
>  tools/perf/util/map.h                       |  32 +--
>  tools/perf/util/pmu.c                       |  15 +-
>  tools/perf/util/probe-event.c               |  17 +-
>  tools/perf/util/symbol-elf.c                |  32 +--
>  tools/perf/util/symbol-minimal.c            |   4 +-
>  tools/perf/util/symbol.c                    | 134 ++++++------
>  tools/perf/util/symbol.h                    |  20 +-
>  32 files changed, 817 insertions(+), 286 deletions(-)
>  create mode 100644 tools/perf/util/block-range.c
>  create mode 100644 tools/perf/util/block-range.h
> 
> Build stats:
> 
>   [root@jouet ~]# time dm
>    1 69.078 alpine:3.4: Ok
>    2 24.055 android-ndk:r12b-arm: Ok
>    3 71.911 archlinux:latest: Ok
>    4 41.209 centos:5: Ok
>    5 58.240 centos:6: Ok
>    6 67.238 centos:7: Ok
>    7 62.040 debian:7: Ok
>    8 69.061 debian:8: Ok
>    9 38.124 debian:experimental: Ok
>   10 67.623 fedora:20: Ok
>   11 71.458 fedora:21: Ok
>   12 70.807 fedora:22: Ok
>   13 71.013 fedora:23: Ok
>   14 73.330 fedora:24: Ok
>   15 30.062 fedora:24-x-ARC-uClibc: Ok
>   16 77.616 fedora:rawhide: Ok
>   17 73.663 mageia:5: Ok
>   18 69.264 opensuse:13.2: Ok
>   19 71.532 opensuse:42.1: Ok
>   20 76.282 opensuse:tumbleweed: Ok
>   21 54.666 ubuntu:12.04.5: Ok
>   22 37.170 ubuntu:14.04: Ok
>   23 66.101 ubuntu:14.04.4: Ok
>   24 68.881 ubuntu:15.10: Ok
>   25 62.698 ubuntu:16.04: Ok
>   26 53.046 ubuntu:16.04-x-arm: Ok
>   27 51.609 ubuntu:16.04-x-arm64: Ok
>   28 51.842 ubuntu:16.04-x-powerpc64: Ok
>   29 53.347 ubuntu:16.04-x-powerpc64el: Ok
>   30 72.280 ubuntu:16.10: Ok
>   31 54.078 ubuntu:16.10-x-s390: Ok
> 
>   real	31m19.919s
>   user	0m1.890s
>   sys	0m2.201s
>   [root@jouet ~]#

Pulled, thanks a lot Arnaldo!

	Ingo

[GIT PULL 00/12] perf/core improvements and fixes

[Arnaldo Carvalho de Melo]

Hi Ingo,

	Please consider pulling,

- Arnaldo

Test results at the end of this message.

The following changes since commit 47414424c53a70eceb0fc6e0a35a31a2b763d5b2:

  Merge tag 'perf-core-for-mingo-20161123' of git://git.kernel.org/pub/scm/linux/kernel/git/acme/linux into perf/core (2016-11-24 05:09:31 +0100)

are available in the git repository at:

  git://git.kernel.org/pub/scm/linux/kernel/git/acme/linux.git tags/perf-core-for-mingo-20161125

for you to fetch changes up to 4708bbda5cb2f6cdc331744597527143f46394d5:

  tools lib bpf: Fix maps resolution (2016-11-25 11:27:33 -0300)

----------------------------------------------------------------
perf/core improvements and fixes:

New features:

- Improve ARM support in the annotation code, affecting 'perf annotate', 'perf
  report' and live annotation in 'perf top' (Kim Phillips)

- Initial support for PowerPC in the annotation code (Ravi Bangoria)

- Skip repetitive scheduler function on the top of the stack in
  'perf sched timehist' (Namhyung Kim)

Fixes:

- Fix maps resolution in libbpf (Eric Leblond)

- Get the kernel signature via /proc/version_signature, available on
  ubuntu systems, to make sure bpf proggies works, as the one provided
  via 'uname -r' doesn't (Wang Nan)

- Fix segfault in 'perf record' when running with suid and kptr_restrict
  is 1 (Wang Nan)

Infrastructure:

- Support per-arch instruction tables, kept via a static or dynamic table
  (Arnaldo Carvalho de Melo)

Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>

----------------------------------------------------------------
Arnaldo Carvalho de Melo (4):
      perf annotate: Remove duplicate 'name' field from disasm_line
      perf annotate: Introduce alternative method of keeping instructions table
      perf annotate: Allow arches to have a init routine and a priv area
      perf annotate: Improve support for ARM

Eric Leblond (1):
      tools lib bpf: Fix maps resolution

Namhyung Kim (3):
      perf callchain: Add option to skip ignore symbol when printing callchains
      perf sched timehist: Mark schedule function in callchains
      perf sched timehist: Enlarge max stack depth by 2

Ravi Bangoria (1):
      perf annotate: Initial PowerPC support

Wang Nan (3):
      perf tools: Fix kernel version error in ubuntu
      perf record: Fix segfault when running with suid and kptr_restrict is 1
      perf tools: Add missing struct definition in probe_event.h

 tools/lib/bpf/libbpf.c                          | 142 ++++++++++++++-------
 tools/perf/arch/arm/annotate/instructions.c     | 147 +++++++++-------------
 tools/perf/arch/powerpc/annotate/instructions.c |  58 +++++++++
 tools/perf/builtin-sched.c                      |  26 +++-
 tools/perf/ui/browsers/annotate.c               |  18 +--
 tools/perf/util/annotate.c                      | 157 +++++++++++++++++-------
 tools/perf/util/annotate.h                      |  17 ++-
 tools/perf/util/evsel.h                         |   1 +
 tools/perf/util/evsel_fprintf.c                 |   7 +-
 tools/perf/util/probe-event.h                   |   2 +
 tools/perf/util/symbol.c                        |   2 +-
 tools/perf/util/symbol.h                        |   1 +
 tools/perf/util/util.c                          |  55 ++++++++-
 13 files changed, 431 insertions(+), 202 deletions(-)
 create mode 100644 tools/perf/arch/powerpc/annotate/instructions.c

  Rebuilding containers, so limited coverage at this time:
  # dm
   1 debian:experimental: Ok
   2 fedora:24: Ok
   3 fedora:24-x-ARC-uClibc: Ok
   4 fedora:rawhide: Ok
   5 opensuse:tumbleweed: Ok

  # perf test
   1: vmlinux symtab matches kallsyms                          : Ok
   2: detect openat syscall event                              : Ok
   3: detect openat syscall event on all cpus                  : Ok
   4: read samples using the mmap interface                    : Ok
   5: parse events tests                                       : Ok
   6: Validate PERF_RECORD_* events & perf_sample fields       : Ok
   7: Test perf pmu format parsing                             : Ok
   8: Test dso data read                                       : Ok
   9: Test dso data cache                                      : Ok
  10: Test dso data reopen                                     : Ok
  11: roundtrip evsel->name check                              : Ok
  12: Check parsing of sched tracepoints fields                : Ok
  13: Generate and check syscalls:sys_enter_openat event fields: Ok
  14: struct perf_event_attr setup                             : Ok
  15: Test matching and linking multiple hists                 : Ok
  16: Try 'import perf' in python, checking link problems      : Ok
  17: Test breakpoint overflow signal handler                  : Ok
  18: Test breakpoint overflow sampling                        : Ok
  19: Test number of exit event of a simple workload           : Ok
  20: Test software clock events have valid period values      : Ok
  21: Test object code reading                                 : Ok
  22: Test sample parsing                                      : Ok
  23: Test using a dummy software event to keep tracking       : Ok
  24: Test parsing with no sample_id_all bit set               : Ok
  25: Test filtering hist entries                              : Ok
  26: Test mmap thread lookup                                  : Ok
  27: Test thread mg sharing                                   : Ok
  28: Test output sorting of hist entries                      : Ok
  29: Test cumulation of child hist entries                    : Ok
  30: Test tracking with sched_switch                          : Ok
  31: Filter fds with revents mask in a fdarray                : Ok
  32: Add fd to a fdarray, making it autogrow                  : Ok
  33: Test kmod_path__parse function                           : Ok
  34: Test thread map                                          : Ok
  35: Test LLVM searching and compiling                        :
  35.1: Basic BPF llvm compiling test                          : Ok
  35.2: Test kbuild searching                                  : Ok
  35.3: Compile source for BPF prologue generation test        : Ok
  35.4: Compile source for BPF relocation test                 : Ok
  36: Test topology in session                                 : Ok
  37: Test BPF filter                                          :
  37.1: Test basic BPF filtering                               : Ok
  37.2: Test BPF prologue generation                           : Ok
  37.3: Test BPF relocation checker                            : Ok
  38: Test thread map synthesize                               : Ok
  39: Test cpu map synthesize                                  : Ok
  40: Test stat config synthesize                              : Ok
  41: Test stat synthesize                                     : Ok
  42: Test stat round synthesize                               : Ok
  43: Test attr update synthesize                              : Ok
  44: Test events times                                        : Ok
  45: Test backward reading from ring buffer                   : Ok
  46: Test cpu map print                                       : Ok
  47: Test SDT event probing                                   : Ok
  48: Test is_printable_array function                         : Ok
  49: Test bitmap print                                        : Ok
  50: x86 rdpmc test                                           : Ok
  51: Test converting perf time to TSC                         : Ok
  52: Test dwarf unwind                                        : Ok
  53: Test x86 instruction decoder - new instructions          : Ok
  54: Test intel cqm nmi context read                          : Skip
  #
  $ make -C tools/perf build-test
  make: Entering directory '/home/acme/git/linux/tools/perf'
  - tarpkg: ./tests/perf-targz-src-pkg .
             make_no_scripts_O: make NO_LIBPYTHON=1 NO_LIBPERL=1
               make_no_slang_O: make NO_SLANG=1
                make_no_gtk2_O: make NO_GTK2=1
             make_no_libperl_O: make NO_LIBPERL=1
            make_no_libaudit_O: make NO_LIBAUDIT=1
        make_with_babeltrace_O: make LIBBABELTRACE=1
                make_no_newt_O: make NO_NEWT=1
             make_util_map_o_O: make util/map.o
                   make_pure_O: make
              make_no_libbpf_O: make NO_LIBBPF=1
                    make_doc_O: make doc
             make_no_libnuma_O: make NO_LIBNUMA=1
       make_util_pmu_bison_o_O: make util/pmu-bison.o
                   make_tags_O: make tags
         make_install_prefix_O: make install prefix=/tmp/krava
            make_no_demangle_O: make NO_DEMANGLE=1
           make_no_libpython_O: make NO_LIBPYTHON=1
                 make_static_O: make LDFLAGS=-static
                  make_debug_O: make DEBUG=1
                  make_no_ui_O: make NO_NEWT=1 NO_SLANG=1 NO_GTK2=1
   make_install_prefix_slash_O: make install prefix=/tmp/krava/
  make_no_libdw_dwarf_unwind_O: make NO_LIBDW_DWARF_UNWIND=1
            make_no_auxtrace_O: make NO_AUXTRACE=1
                make_minimal_O: make NO_LIBPERL=1 NO_LIBPYTHON=1 NO_NEWT=1 NO_GTK2=1 NO_DEMANGLE=1 NO_LIBELF=1 NO_LIBUNWIND=1 NO_BACKTRACE=1 NO_LIBNUMA=1 NO_LIBAUDIT=1 NO_LIBBIONIC=1 NO_LIBDW_DWARF_UNWIND=1 NO_AUXTRACE=1 NO_LIBBPF=1 NO_LIBCRYPTO=1 NO_SDT=1 NO_JVMTI=1
                 make_perf_o_O: make perf.o
           make_no_libbionic_O: make NO_LIBBIONIC=1
              make_clean_all_O: make clean all
           make_no_backtrace_O: make NO_BACKTRACE=1
                make_install_O: make install
           make_no_libunwind_O: make NO_LIBUNWIND=1
            make_install_bin_O: make install-bin
              make_no_libelf_O: make NO_LIBELF=1
                   make_help_O: make help
  OK
  make: Leaving directory '/home/acme/git/linux/tools/perf'
  $

Re: [GIT PULL 00/12] perf/core improvements and fixes

[Ingo Molnar]

* Arnaldo Carvalho de Melo <acme@kernel.org> wrote:

> Hi Ingo,
> 
> 	Please consider pulling,
> 
> - Arnaldo
> 
> Test results at the end of this message.
> 
> The following changes since commit 47414424c53a70eceb0fc6e0a35a31a2b763d5b2:
> 
>   Merge tag 'perf-core-for-mingo-20161123' of git://git.kernel.org/pub/scm/linux/kernel/git/acme/linux into perf/core (2016-11-24 05:09:31 +0100)
> 
> are available in the git repository at:
> 
>   git://git.kernel.org/pub/scm/linux/kernel/git/acme/linux.git tags/perf-core-for-mingo-20161125
> 
> for you to fetch changes up to 4708bbda5cb2f6cdc331744597527143f46394d5:
> 
>   tools lib bpf: Fix maps resolution (2016-11-25 11:27:33 -0300)
> 
> ----------------------------------------------------------------
> perf/core improvements and fixes:
> 
> New features:
> 
> - Improve ARM support in the annotation code, affecting 'perf annotate', 'perf
>   report' and live annotation in 'perf top' (Kim Phillips)
> 
> - Initial support for PowerPC in the annotation code (Ravi Bangoria)
> 
> - Skip repetitive scheduler function on the top of the stack in
>   'perf sched timehist' (Namhyung Kim)
> 
> Fixes:
> 
> - Fix maps resolution in libbpf (Eric Leblond)
> 
> - Get the kernel signature via /proc/version_signature, available on
>   ubuntu systems, to make sure bpf proggies works, as the one provided
>   via 'uname -r' doesn't (Wang Nan)
> 
> - Fix segfault in 'perf record' when running with suid and kptr_restrict
>   is 1 (Wang Nan)
> 
> Infrastructure:
> 
> - Support per-arch instruction tables, kept via a static or dynamic table
>   (Arnaldo Carvalho de Melo)
> 
> Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
> 
> ----------------------------------------------------------------
> Arnaldo Carvalho de Melo (4):
>       perf annotate: Remove duplicate 'name' field from disasm_line
>       perf annotate: Introduce alternative method of keeping instructions table
>       perf annotate: Allow arches to have a init routine and a priv area
>       perf annotate: Improve support for ARM
> 
> Eric Leblond (1):
>       tools lib bpf: Fix maps resolution
> 
> Namhyung Kim (3):
>       perf callchain: Add option to skip ignore symbol when printing callchains
>       perf sched timehist: Mark schedule function in callchains
>       perf sched timehist: Enlarge max stack depth by 2
> 
> Ravi Bangoria (1):
>       perf annotate: Initial PowerPC support
> 
> Wang Nan (3):
>       perf tools: Fix kernel version error in ubuntu
>       perf record: Fix segfault when running with suid and kptr_restrict is 1
>       perf tools: Add missing struct definition in probe_event.h
> 
>  tools/lib/bpf/libbpf.c                          | 142 ++++++++++++++-------
>  tools/perf/arch/arm/annotate/instructions.c     | 147 +++++++++-------------
>  tools/perf/arch/powerpc/annotate/instructions.c |  58 +++++++++
>  tools/perf/builtin-sched.c                      |  26 +++-
>  tools/perf/ui/browsers/annotate.c               |  18 +--
>  tools/perf/util/annotate.c                      | 157 +++++++++++++++++-------
>  tools/perf/util/annotate.h                      |  17 ++-
>  tools/perf/util/evsel.h                         |   1 +
>  tools/perf/util/evsel_fprintf.c                 |   7 +-
>  tools/perf/util/probe-event.h                   |   2 +
>  tools/perf/util/symbol.c                        |   2 +-
>  tools/perf/util/symbol.h                        |   1 +
>  tools/perf/util/util.c                          |  55 ++++++++-
>  13 files changed, 431 insertions(+), 202 deletions(-)
>  create mode 100644 tools/perf/arch/powerpc/annotate/instructions.c
> 
>   Rebuilding containers, so limited coverage at this time:
>   # dm
>    1 debian:experimental: Ok
>    2 fedora:24: Ok
>    3 fedora:24-x-ARC-uClibc: Ok
>    4 fedora:rawhide: Ok
>    5 opensuse:tumbleweed: Ok
> 
>   # perf test
>    1: vmlinux symtab matches kallsyms                          : Ok
>    2: detect openat syscall event                              : Ok
>    3: detect openat syscall event on all cpus                  : Ok
>    4: read samples using the mmap interface                    : Ok
>    5: parse events tests                                       : Ok
>    6: Validate PERF_RECORD_* events & perf_sample fields       : Ok
>    7: Test perf pmu format parsing                             : Ok
>    8: Test dso data read                                       : Ok
>    9: Test dso data cache                                      : Ok
>   10: Test dso data reopen                                     : Ok
>   11: roundtrip evsel->name check                              : Ok
>   12: Check parsing of sched tracepoints fields                : Ok
>   13: Generate and check syscalls:sys_enter_openat event fields: Ok
>   14: struct perf_event_attr setup                             : Ok
>   15: Test matching and linking multiple hists                 : Ok
>   16: Try 'import perf' in python, checking link problems      : Ok
>   17: Test breakpoint overflow signal handler                  : Ok
>   18: Test breakpoint overflow sampling                        : Ok
>   19: Test number of exit event of a simple workload           : Ok
>   20: Test software clock events have valid period values      : Ok
>   21: Test object code reading                                 : Ok
>   22: Test sample parsing                                      : Ok
>   23: Test using a dummy software event to keep tracking       : Ok
>   24: Test parsing with no sample_id_all bit set               : Ok
>   25: Test filtering hist entries                              : Ok
>   26: Test mmap thread lookup                                  : Ok
>   27: Test thread mg sharing                                   : Ok
>   28: Test output sorting of hist entries                      : Ok
>   29: Test cumulation of child hist entries                    : Ok
>   30: Test tracking with sched_switch                          : Ok
>   31: Filter fds with revents mask in a fdarray                : Ok
>   32: Add fd to a fdarray, making it autogrow                  : Ok
>   33: Test kmod_path__parse function                           : Ok
>   34: Test thread map                                          : Ok
>   35: Test LLVM searching and compiling                        :
>   35.1: Basic BPF llvm compiling test                          : Ok
>   35.2: Test kbuild searching                                  : Ok
>   35.3: Compile source for BPF prologue generation test        : Ok
>   35.4: Compile source for BPF relocation test                 : Ok
>   36: Test topology in session                                 : Ok
>   37: Test BPF filter                                          :
>   37.1: Test basic BPF filtering                               : Ok
>   37.2: Test BPF prologue generation                           : Ok
>   37.3: Test BPF relocation checker                            : Ok
>   38: Test thread map synthesize                               : Ok
>   39: Test cpu map synthesize                                  : Ok
>   40: Test stat config synthesize                              : Ok
>   41: Test stat synthesize                                     : Ok
>   42: Test stat round synthesize                               : Ok
>   43: Test attr update synthesize                              : Ok
>   44: Test events times                                        : Ok
>   45: Test backward reading from ring buffer                   : Ok
>   46: Test cpu map print                                       : Ok
>   47: Test SDT event probing                                   : Ok
>   48: Test is_printable_array function                         : Ok
>   49: Test bitmap print                                        : Ok
>   50: x86 rdpmc test                                           : Ok
>   51: Test converting perf time to TSC                         : Ok
>   52: Test dwarf unwind                                        : Ok
>   53: Test x86 instruction decoder - new instructions          : Ok
>   54: Test intel cqm nmi context read                          : Skip
>   #
>   $ make -C tools/perf build-test
>   make: Entering directory '/home/acme/git/linux/tools/perf'
>   - tarpkg: ./tests/perf-targz-src-pkg .
>              make_no_scripts_O: make NO_LIBPYTHON=1 NO_LIBPERL=1
>                make_no_slang_O: make NO_SLANG=1
>                 make_no_gtk2_O: make NO_GTK2=1
>              make_no_libperl_O: make NO_LIBPERL=1
>             make_no_libaudit_O: make NO_LIBAUDIT=1
>         make_with_babeltrace_O: make LIBBABELTRACE=1
>                 make_no_newt_O: make NO_NEWT=1
>              make_util_map_o_O: make util/map.o
>                    make_pure_O: make
>               make_no_libbpf_O: make NO_LIBBPF=1
>                     make_doc_O: make doc
>              make_no_libnuma_O: make NO_LIBNUMA=1
>        make_util_pmu_bison_o_O: make util/pmu-bison.o
>                    make_tags_O: make tags
>          make_install_prefix_O: make install prefix=/tmp/krava
>             make_no_demangle_O: make NO_DEMANGLE=1
>            make_no_libpython_O: make NO_LIBPYTHON=1
>                  make_static_O: make LDFLAGS=-static
>                   make_debug_O: make DEBUG=1
>                   make_no_ui_O: make NO_NEWT=1 NO_SLANG=1 NO_GTK2=1
>    make_install_prefix_slash_O: make install prefix=/tmp/krava/
>   make_no_libdw_dwarf_unwind_O: make NO_LIBDW_DWARF_UNWIND=1
>             make_no_auxtrace_O: make NO_AUXTRACE=1
>                 make_minimal_O: make NO_LIBPERL=1 NO_LIBPYTHON=1 NO_NEWT=1 NO_GTK2=1 NO_DEMANGLE=1 NO_LIBELF=1 NO_LIBUNWIND=1 NO_BACKTRACE=1 NO_LIBNUMA=1 NO_LIBAUDIT=1 NO_LIBBIONIC=1 NO_LIBDW_DWARF_UNWIND=1 NO_AUXTRACE=1 NO_LIBBPF=1 NO_LIBCRYPTO=1 NO_SDT=1 NO_JVMTI=1
>                  make_perf_o_O: make perf.o
>            make_no_libbionic_O: make NO_LIBBIONIC=1
>               make_clean_all_O: make clean all
>            make_no_backtrace_O: make NO_BACKTRACE=1
>                 make_install_O: make install
>            make_no_libunwind_O: make NO_LIBUNWIND=1
>             make_install_bin_O: make install-bin
>               make_no_libelf_O: make NO_LIBELF=1
>                    make_help_O: make help
>   OK
>   make: Leaving directory '/home/acme/git/linux/tools/perf'
>   $

Pulled, thanks a lot Arnaldo!

	Ingo

[GIT PULL 00/12] perf/core improvements and fixes

[Arnaldo Carvalho de Melo]

Hi Ingo,

	Please consider pulling,

- Arnaldo

Test results at the end of this message, as usual.

The following changes since commit 7c5314b88da6d5af98239786772a1c44cc5eb67d:

  perf/x86/intel: Add quirk for Goldmont Plus (2018-10-02 10:14:33 +0200)

are available in the Git repository at:

  git://git.kernel.org/pub/scm/linux/kernel/git/acme/linux.git tags/perf-core-for-mingo-4.20-20181008

for you to fetch changes up to bb3dd7e7c4d5e024d607c0ec06c2a2fb9408cc99:

  tools lib traceevent, perf tools: Move struct tep_handler definition in a local header file (2018-10-08 15:05:37 -0300)

----------------------------------------------------------------
perf/core improvements and fixes:

. Fix building the python bindings with python3, which fixes some
  problems with building with clang on Clear Linux (Eduardo Habkost)

. Fix coverity warnings, fixing up some error paths and plugging
  some temporary small buffer leaks (Sanskriti Sharma)

. Adopt a wrapper for strerror_r() for the same reasons as recently
  for libbpf (Steven Rostedt)

. S390 does not support watchpoints in 'perf test 22', check if
  that test is supported by the arch. (Thomas Richter)

Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>

----------------------------------------------------------------
Arnaldo Carvalho de Melo (2):
      tools include: Adopt linux/bits.h
      perf auxtrace: Include missing asm/bitsperlong.h to get BITS_PER_LONG

Eduardo Habkost (2):
      perf python: Make clang_has_option() work on Python 3
      perf python: More portable way to make CFLAGS work with clang

Sanskriti Sharma (5):
      perf strbuf: Match va_{add,copy} with va_end
      perf tools: Cleanup trace-event-info 'tdata' leak
      perf tools: Free 'printk' string in parse_ftrace_printk()
      perf tools: Avoid double free in read_event_file()
      perf tools: Free temporary 'sys' string in read_event_files()

Steven Rostedt (VMware) (1):
      tools lib traceevent: Separate out tep_strerror() for strerror_r() issues

Thomas Richter (1):
      perf test: S390 does not support watchpoints in test 22

Tzvetomir Stoyanov (1):
      tools lib traceevent, perf tools: Move struct tep_handler definition in a local header file

 tools/include/linux/bitops.h             |   7 +-
 tools/include/linux/bits.h               |  26 +++
 tools/lib/traceevent/Build               |   2 +
 tools/lib/traceevent/event-parse-api.c   | 275 +++++++++++++++++++++++++++++++
 tools/lib/traceevent/event-parse-local.h |  92 +++++++++++
 tools/lib/traceevent/event-parse.c       |  32 +---
 tools/lib/traceevent/event-parse.h       | 228 ++++---------------------
 tools/lib/traceevent/event-plugin.c      |   1 +
 tools/lib/traceevent/parse-filter.c      |   1 +
 tools/lib/traceevent/tep_strerror.c      |  53 ++++++
 tools/perf/check-headers.sh              |   1 +
 tools/perf/tests/builtin-test.c          |   1 +
 tools/perf/tests/tests.h                 |   1 +
 tools/perf/tests/wp.c                    |  12 ++
 tools/perf/util/auxtrace.h               |   1 +
 tools/perf/util/setup.py                 |  16 +-
 tools/perf/util/strbuf.c                 |  10 +-
 tools/perf/util/trace-event-info.c       |   2 +
 tools/perf/util/trace-event-parse.c      |  26 +--
 tools/perf/util/trace-event-read.c       |  11 +-
 20 files changed, 539 insertions(+), 259 deletions(-)
 create mode 100644 tools/include/linux/bits.h
 create mode 100644 tools/lib/traceevent/event-parse-api.c
 create mode 100644 tools/lib/traceevent/event-parse-local.h
 create mode 100644 tools/lib/traceevent/tep_strerror.c

Test results:

The first ones are container (docker) based builds of tools/perf with
and without libelf support.  Where clang is available, it is also used
to build perf with/without libelf, and building with LIBCLANGLLVM=1
(built-in clang) with gcc and clang when clang and its devel libraries
are installed.

The objtool and samples/bpf/ builds are disabled now that I'm switching from
using the sources in a local volume to fetching them from a http server to
build it inside the container, to make it easier to build in a container cluster.
Those will come back later.

Several are cross builds, the ones with -x-ARCH and the android one, and those
may not have all the features built, due to lack of multi-arch devel packages,
available and being used so far on just a few, like
debian:experimental-x-{arm64,mipsel}.

The 'perf test' one will perform a variety of tests exercising
tools/perf/util/, tools/lib/{bpf,traceevent,etc}, as well as run perf commands
with a variety of command line event specifications to then intercept the
sys_perf_event syscall to check that the perf_event_attr fields are set up as
expected, among a variety of other unit tests.

Then there is the 'make -C tools/perf build-test' ones, that build tools/perf/
with a variety of feature sets, exercising the build with an incomplete set of
features as well as with a complete one. It is planned to have it run on each
of the containers mentioned above, using some container orchestration
infrastructure. Get in contact if interested in helping having this in place.

The Clear Linux container is building with NO_CLANG=1, some problem
preventing its use when building for python3 have been fixed, some more
have been identified and the next builds will build in ClearLinux with
both gcc and clang. This time around only gcc was used.

  # dm
   1 alpine:3.4                    : Ok   gcc (Alpine 5.3.0) 5.3.0
   2 alpine:3.5                    : Ok   gcc (Alpine 6.2.1) 6.2.1 20160822
   3 alpine:3.6                    : Ok   gcc (Alpine 6.3.0) 6.3.0
   4 alpine:3.7                    : Ok   gcc (Alpine 6.4.0) 6.4.0
   5 alpine:3.8                    : Ok   gcc (Alpine 6.4.0) 6.4.0
   6 alpine:edge                   : Ok   gcc (Alpine 6.4.0) 6.4.0
   7 amazonlinux:1                 : Ok   gcc (GCC) 4.8.5 20150623 (Red Hat 4.8.5-28)
   8 amazonlinux:2                 : Ok   gcc (GCC) 7.3.1 20180303 (Red Hat 7.3.1-5)
   9 android-ndk:r12b-arm          : Ok   arm-linux-androideabi-gcc (GCC) 4.9.x 20150123 (prerelease)
  10 android-ndk:r15c-arm          : Ok   arm-linux-androideabi-gcc (GCC) 4.9.x 20150123 (prerelease)
  11 centos:5                      : Ok   gcc (GCC) 4.1.2 20080704 (Red Hat 4.1.2-55)
  12 centos:6                      : Ok   gcc (GCC) 4.4.7 20120313 (Red Hat 4.4.7-23)
  13 centos:7                      : Ok   gcc (GCC) 4.8.5 20150623 (Red Hat 4.8.5-28)
  14 clearlinux:latest             : Ok   gcc (Clear Linux OS for Intel Architecture) 8.2.1 20180502
  15 debian:7                      : Ok   gcc (Debian 4.7.2-5) 4.7.2
  16 debian:8                      : Ok   gcc (Debian 4.9.2-10+deb8u1) 4.9.2
  17 debian:9                      : Ok   gcc (Debian 6.3.0-18+deb9u1) 6.3.0 20170516
  18 debian:experimental           : Ok   gcc (Debian 8.2.0-7) 8.2.0
  19 debian:experimental-x-arm64   : Ok   aarch64-linux-gnu-gcc (Debian 8.2.0-4) 8.2.0
  20 debian:experimental-x-mips    : Ok   mips-linux-gnu-gcc (Debian 8.1.0-12) 8.1.0
  21 debian:experimental-x-mips64  : Ok   mips64-linux-gnuabi64-gcc (Debian 8.1.0-12) 8.1.0
  22 debian:experimental-x-mipsel  : Ok   mipsel-linux-gnu-gcc (Debian 8.1.0-12) 8.1.0
  23 fedora:20                     : Ok   gcc (GCC) 4.8.3 20140911 (Red Hat 4.8.3-7)
  24 fedora:21                     : Ok   gcc (GCC) 4.9.2 20150212 (Red Hat 4.9.2-6)
  25 fedora:22                     : Ok   gcc (GCC) 5.3.1 20160406 (Red Hat 5.3.1-6)
  26 fedora:23                     : Ok   gcc (GCC) 5.3.1 20160406 (Red Hat 5.3.1-6)
  27 fedora:24                     : Ok   gcc (GCC) 6.3.1 20161221 (Red Hat 6.3.1-1)
  28 fedora:24-x-ARC-uClibc        : Ok   arc-linux-gcc (ARCompact ISA Linux uClibc toolchain 2017.09-rc2) 7.1.1 20170710
  29 fedora:25                     : Ok   gcc (GCC) 6.4.1 20170727 (Red Hat 6.4.1-1)
  30 fedora:26                     : Ok   gcc (GCC) 7.3.1 20180130 (Red Hat 7.3.1-2)
  31 fedora:27                     : Ok   gcc (GCC) 7.3.1 20180712 (Red Hat 7.3.1-6)
  32 fedora:28                     : Ok   gcc (GCC) 8.1.1 20180712 (Red Hat 8.1.1-5)
  33 fedora:rawhide                : Ok   gcc (GCC) 8.2.1 20180905 (Red Hat 8.2.1-3)
  34 gentoo-stage3-amd64:latest    : Ok   gcc (Gentoo 7.3.0-r3 p1.4) 7.3.0
  35 mageia:5                      : Ok   gcc (GCC) 4.9.2
  36 mageia:6                      : Ok   gcc (Mageia 5.5.0-1.mga6) 5.5.0
  37 opensuse:13.2                 : Ok   gcc (SUSE Linux) 4.8.3 20140627 [gcc-4_8-branch revision 212064]
  38 opensuse:42.1                 : Ok   gcc (SUSE Linux) 4.8.5
  39 opensuse:42.2                 : Ok   gcc (SUSE Linux) 4.8.5
  40 opensuse:42.3                 : Ok   gcc (SUSE Linux) 4.8.5
  41 opensuse:tumbleweed           : Ok   gcc (SUSE Linux) 7.3.1 20180323 [gcc-7-branch revision 258812]
  42 oraclelinux:6                 : Ok   gcc (GCC) 4.4.7 20120313 (Red Hat 4.4.7-23.0.1)
  43 oraclelinux:7                 : Ok   gcc (GCC) 4.8.5 20150623 (Red Hat 4.8.5-28.0.1)
  44 ubuntu:12.04.5                : Ok   gcc (Ubuntu/Linaro 4.6.3-1ubuntu5) 4.6.3
  45 ubuntu:14.04.4                : Ok   gcc (Ubuntu 4.8.4-2ubuntu1~14.04.3) 4.8.4
  46 ubuntu:14.04.4-x-linaro-arm64 : Ok   aarch64-linux-gnu-gcc (Linaro GCC 5.5-2017.10) 5.5.0
  47 ubuntu:16.04                  : Ok   gcc (Ubuntu 5.4.0-6ubuntu1~16.04.10) 5.4.0 20160609
  48 ubuntu:16.04-x-arm            : Ok   arm-linux-gnueabihf-gcc (Ubuntu/Linaro 5.4.0-6ubuntu1~16.04.9) 5.4.0 20160609
  49 ubuntu:16.04-x-arm64          : Ok   aarch64-linux-gnu-gcc (Ubuntu/Linaro 5.4.0-6ubuntu1~16.04.9) 5.4.0 20160609
  50 ubuntu:16.04-x-powerpc        : Ok   powerpc-linux-gnu-gcc (Ubuntu 5.4.0-6ubuntu1~16.04.9) 5.4.0 20160609
  51 ubuntu:16.04-x-powerpc64      : Ok   powerpc64-linux-gnu-gcc (Ubuntu/IBM 5.4.0-6ubuntu1~16.04.9) 5.4.0 20160609
  52 ubuntu:16.04-x-powerpc64el    : Ok   powerpc64le-linux-gnu-gcc (Ubuntu/IBM 5.4.0-6ubuntu1~16.04.9) 5.4.0 20160609
  53 ubuntu:16.04-x-s390           : Ok   s390x-linux-gnu-gcc (Ubuntu 5.4.0-6ubuntu1~16.04.9) 5.4.0 20160609
  54 ubuntu:16.10                  : Ok   gcc (Ubuntu 6.2.0-5ubuntu12) 6.2.0 20161005
  55 ubuntu:17.10                  : Ok   gcc (Ubuntu 7.2.0-8ubuntu3.2) 7.2.0
  56 ubuntu:18.04                  : Ok   gcc (Ubuntu 7.3.0-16ubuntu3) 7.3.0
  57 ubuntu:18.04-x-arm            : Ok   arm-linux-gnueabihf-gcc (Ubuntu/Linaro 7.3.0-16ubuntu3) 7.3.0
  58 ubuntu:18.04-x-arm64          : Ok   aarch64-linux-gnu-gcc (Ubuntu/Linaro 7.3.0-16ubuntu3) 7.3.0
  59 ubuntu:18.04-x-m68k           : Ok   m68k-linux-gnu-gcc (Ubuntu 7.3.0-16ubuntu3) 7.3.0
  60 ubuntu:18.04-x-powerpc        : Ok   powerpc-linux-gnu-gcc (Ubuntu 7.3.0-16ubuntu3) 7.3.0
  61 ubuntu:18.04-x-powerpc64      : Ok   powerpc64-linux-gnu-gcc (Ubuntu 7.3.0-16ubuntu3) 7.3.0
  62 ubuntu:18.04-x-powerpc64el    : Ok   powerpc64le-linux-gnu-gcc (Ubuntu 7.3.0-16ubuntu3) 7.3.0
  63 ubuntu:18.04-x-riscv64        : Ok   riscv64-linux-gnu-gcc (Ubuntu 7.3.0-16ubuntu3) 7.3.0
  64 ubuntu:18.04-x-s390           : Ok   s390x-linux-gnu-gcc (Ubuntu 7.3.0-16ubuntu3) 7.3.0
  65 ubuntu:18.04-x-sh4            : Ok   sh4-linux-gnu-gcc (Ubuntu 7.3.0-16ubuntu3) 7.3.0
  66 ubuntu:18.04-x-sparc64        : Ok   sparc64-linux-gnu-gcc (Ubuntu 7.3.0-16ubuntu3) 7.3.0
  67 ubuntu:18.10                  : Ok   gcc (Ubuntu 8.2.0-4ubuntu1) 8.2.0
  #

  # uname -a
  Linux jouet 4.19.0-rc4-00022-gad3273d5f1b9 #1 SMP Mon Sep 17 17:18:22 -03 2018 x86_64 x86_64 x86_64 GNU/Linux
  # git log --oneline -1
  bb3dd7e7c4d5 tools lib traceevent, perf tools: Move struct tep_handler definition in a local header file
  # perf version --build-options
  perf version 4.19.rc5.gbb3dd7
                   dwarf: [ on  ]  # HAVE_DWARF_SUPPORT
      dwarf_getlocations: [ on  ]  # HAVE_DWARF_GETLOCATIONS_SUPPORT
                   glibc: [ on  ]  # HAVE_GLIBC_SUPPORT
                    gtk2: [ on  ]  # HAVE_GTK2_SUPPORT
           syscall_table: [ on  ]  # HAVE_SYSCALL_TABLE_SUPPORT
                  libbfd: [ on  ]  # HAVE_LIBBFD_SUPPORT
                  libelf: [ on  ]  # HAVE_LIBELF_SUPPORT
                 libnuma: [ on  ]  # HAVE_LIBNUMA_SUPPORT
  numa_num_possible_cpus: [ on  ]  # HAVE_LIBNUMA_SUPPORT
                 libperl: [ on  ]  # HAVE_LIBPERL_SUPPORT
               libpython: [ on  ]  # HAVE_LIBPYTHON_SUPPORT
                libslang: [ on  ]  # HAVE_SLANG_SUPPORT
               libcrypto: [ on  ]  # HAVE_LIBCRYPTO_SUPPORT
               libunwind: [ on  ]  # HAVE_LIBUNWIND_SUPPORT
      libdw-dwarf-unwind: [ on  ]  # HAVE_DWARF_SUPPORT
                    zlib: [ on  ]  # HAVE_ZLIB_SUPPORT
                    lzma: [ on  ]  # HAVE_LZMA_SUPPORT
               get_cpuid: [ on  ]  # HAVE_AUXTRACE_SUPPORT
                     bpf: [ on  ]  # HAVE_LIBBPF_SUPPORT
  # perf test
   1: vmlinux symtab matches kallsyms                       : Ok
   2: Detect openat syscall event                           : Ok
   3: Detect openat syscall event on all cpus               : Ok
   4: Read samples using the mmap interface                 : Ok
   5: Test data source output                               : Ok
   6: Parse event definition strings                        : Ok
   7: Simple expression parser                              : Ok
   8: PERF_RECORD_* events & perf_sample fields             : Ok
   9: Parse perf pmu format                                 : Ok
  10: DSO data read                                         : Ok
  11: DSO data cache                                        : Ok
  12: DSO data reopen                                       : Ok
  13: Roundtrip evsel->name                                 : Ok
  14: Parse sched tracepoints fields                        : Ok
  15: syscalls:sys_enter_openat event fields                : Ok
  16: Setup struct perf_event_attr                          : Ok
  17: Match and link multiple hists                         : Ok
  18: 'import perf' in python                               : Ok
  19: Breakpoint overflow signal handler                    : Ok
  20: Breakpoint overflow sampling                          : Ok
  21: Breakpoint accounting                                 : Ok
  22: Watchpoint                                            :
  22.1: Read Only Watchpoint                                : Skip
  22.2: Write Only Watchpoint                               : Ok
  22.3: Read / Write Watchpoint                             : Ok
  22.4: Modify Watchpoint                                   : Ok
  23: Number of exit events of a simple workload            : Ok
  24: Software clock events period values                   : Ok
  25: Object code reading                                   : Ok
  26: Sample parsing                                        : Ok
  27: Use a dummy software event to keep tracking           : Ok
  28: Parse with no sample_id_all bit set                   : Ok
  29: Filter hist entries                                   : Ok
  30: Lookup mmap thread                                    : Ok
  31: Share thread mg                                       : Ok
  32: Sort output of hist entries                           : Ok
  33: Cumulate child hist entries                           : Ok
  34: Track with sched_switch                               : Ok
  35: Filter fds with revents mask in a fdarray             : Ok
  36: Add fd to a fdarray, making it autogrow               : Ok
  37: kmod_path__parse                                      : Ok
  38: Thread map                                            : Ok
  39: LLVM search and compile                               :
  39.1: Basic BPF llvm compile                              : Ok
  39.2: kbuild searching                                    : Ok
  39.3: Compile source for BPF prologue generation          : Ok
  39.4: Compile source for BPF relocation                   : Ok
  40: Session topology                                      : Ok
  41: BPF filter                                            :
  41.1: Basic BPF filtering                                 : Ok
  41.2: BPF pinning                                         : Ok
  41.3: BPF prologue generation                             : Ok
  41.4: BPF relocation checker                              : Ok
  42: Synthesize thread map                                 : Ok
  43: Remove thread map                                     : Ok
  44: Synthesize cpu map                                    : Ok
  45: Synthesize stat config                                : Ok
  46: Synthesize stat                                       : Ok
  47: Synthesize stat round                                 : Ok
  48: Synthesize attr update                                : Ok
  49: Event times                                           : Ok
  50: Read backward ring buffer                             : Ok
  51: Print cpu map                                         : Ok
  52: Probe SDT events                                      : Ok
  53: is_printable_array                                    : Ok
  54: Print bitmap                                          : Ok
  55: perf hooks                                            : Ok
  56: builtin clang support                                 : Skip (not compiled in)
  57: unit_number__scnprintf                                : Ok
  58: mem2node                                              : Ok
  59: x86 rdpmc                                             : Ok
  60: Convert perf time to TSC                              : Ok
  61: DWARF unwind                                          : Ok
  62: x86 instruction decoder - new instructions            : Ok
  63: x86 bp modify                                         : Ok
  64: Use vfs_getname probe to get syscall args filenames   : Ok
  65: Check open filename arg using perf trace + vfs_getname: Ok
  66: probe libc's inet_pton & backtrace it with ping       : Ok
  67: Add vfs_getname probe to get syscall args filenames   : Ok

  $ make -C tools/perf build-test
  make: Entering directory '/home/acme/git/perf/tools/perf'
  - tarpkg: ./tests/perf-targz-src-pkg .
            make_install_bin_O: make install-bin
                make_minimal_O: make NO_LIBPERL=1 NO_LIBPYTHON=1 NO_NEWT=1 NO_GTK2=1 NO_DEMANGLE=1 NO_LIBELF=1 NO_LIBUNWIND=1 NO_BACKTRACE=1 NO_LIBNUMA=1 NO_LIBAUDIT=1 NO_LIBBIONIC=1 NO_LIBDW_DWARF_UNWIND=1 NO_AUXTRACE=1 NO_LIBBPF=1 NO_LIBCRYPTO=1 NO_SDT=1 NO_JVMTI=1
                make_no_gtk2_O: make NO_GTK2=1
  make_no_libdw_dwarf_unwind_O: make NO_LIBDW_DWARF_UNWIND=1
                make_install_O: make install
           make_no_backtrace_O: make NO_BACKTRACE=1
                make_no_newt_O: make NO_NEWT=1
             make_no_libperl_O: make NO_LIBPERL=1
             make_util_map_o_O: make util/map.o
              make_clean_all_O: make clean all
                 make_static_O: make LDFLAGS=-static
       make_util_pmu_bison_o_O: make util/pmu-bison.o
                  make_no_ui_O: make NO_NEWT=1 NO_SLANG=1 NO_GTK2=1
                    make_doc_O: make doc
              make_no_libelf_O: make NO_LIBELF=1
                   make_pure_O: make
            make_no_auxtrace_O: make NO_AUXTRACE=1
                 make_perf_o_O: make perf.o
                   make_tags_O: make tags
             make_no_scripts_O: make NO_LIBPYTHON=1 NO_LIBPERL=1
              make_no_libbpf_O: make NO_LIBBPF=1
           make_no_libpython_O: make NO_LIBPYTHON=1
            make_no_libaudit_O: make NO_LIBAUDIT=1
        make_with_babeltrace_O: make LIBBABELTRACE=1
   make_install_prefix_slash_O: make install prefix=/tmp/krava/
             make_no_libnuma_O: make NO_LIBNUMA=1
         make_with_clangllvm_O: make LIBCLANGLLVM=1
                  make_debug_O: make DEBUG=1
           make_no_libunwind_O: make NO_LIBUNWIND=1
           make_no_libbionic_O: make NO_LIBBIONIC=1
               make_no_slang_O: make NO_SLANG=1
                   make_help_O: make help
            make_no_demangle_O: make NO_DEMANGLE=1
         make_install_prefix_O: make install prefix=/tmp/krava
  OK
  make: Leaving directory '/home/acme/git/perf/tools/perf'
  $

[PATCH 01/12] tools include: Adopt linux/bits.h

[Arnaldo Carvalho de Melo]

From: Arnaldo Carvalho de Melo <acme@redhat.com>

So that we reduce the difference of tools/include/linux/bitops.h to the
original kernel file, include/linux/bitops.h, trying to remove the need
to define BITS_PER_LONG, to avoid clashes with asm/bitsperlong.h.

And the things removed from tools/include/linux/bitops.h are really in
linux/bits.h, so that we can have a copy and then
tools/perf/check_headers.sh will tell us when new stuff gets added to
linux/bits.h so that we can check if it is useful and if any adjustment
needs to be done to the tools/{include,arch}/ copies.

Cc: Adrian Hunter <adrian.hunter@intel.com>
Cc: Alexander Sverdlin <alexander.sverdlin@nokia.com>
Cc: David Ahern <dsahern@gmail.com>
Cc: Jiri Olsa <jolsa@kernel.org>
Cc: Namhyung Kim <namhyung@kernel.org>
Cc: Wang Nan <wangnan0@huawei.com>
Link: https://lkml.kernel.org/n/tip-y1sqyydvfzo0bjjoj4zsl562@git.kernel.org
Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
---
 tools/include/linux/bitops.h |  7 ++-----
 tools/include/linux/bits.h   | 26 ++++++++++++++++++++++++++
 tools/perf/check-headers.sh  |  1 +
 3 files changed, 29 insertions(+), 5 deletions(-)
 create mode 100644 tools/include/linux/bits.h

diff --git a/tools/include/linux/bitops.h b/tools/include/linux/bitops.h
index acc704bd3998..0b0ef3abc966 100644
--- a/tools/include/linux/bitops.h
+++ b/tools/include/linux/bitops.h
@@ -3,8 +3,6 @@
 #define _TOOLS_LINUX_BITOPS_H_
 
 #include <asm/types.h>
-#include <linux/compiler.h>
-
 #ifndef __WORDSIZE
 #define __WORDSIZE (__SIZEOF_LONG__ * 8)
 #endif
@@ -12,10 +10,9 @@
 #ifndef BITS_PER_LONG
 # define BITS_PER_LONG __WORDSIZE
 #endif
+#include <linux/bits.h>
+#include <linux/compiler.h>
 
-#define BIT_MASK(nr)		(1UL << ((nr) % BITS_PER_LONG))
-#define BIT_WORD(nr)		((nr) / BITS_PER_LONG)
-#define BITS_PER_BYTE		8
 #define BITS_TO_LONGS(nr)	DIV_ROUND_UP(nr, BITS_PER_BYTE * sizeof(long))
 #define BITS_TO_U64(nr)		DIV_ROUND_UP(nr, BITS_PER_BYTE * sizeof(u64))
 #define BITS_TO_U32(nr)		DIV_ROUND_UP(nr, BITS_PER_BYTE * sizeof(u32))
diff --git a/tools/include/linux/bits.h b/tools/include/linux/bits.h
new file mode 100644
index 000000000000..2b7b532c1d51
--- /dev/null
+++ b/tools/include/linux/bits.h
@@ -0,0 +1,26 @@
+/* SPDX-License-Identifier: GPL-2.0 */
+#ifndef __LINUX_BITS_H
+#define __LINUX_BITS_H
+#include <asm/bitsperlong.h>
+
+#define BIT(nr)			(1UL << (nr))
+#define BIT_ULL(nr)		(1ULL << (nr))
+#define BIT_MASK(nr)		(1UL << ((nr) % BITS_PER_LONG))
+#define BIT_WORD(nr)		((nr) / BITS_PER_LONG)
+#define BIT_ULL_MASK(nr)	(1ULL << ((nr) % BITS_PER_LONG_LONG))
+#define BIT_ULL_WORD(nr)	((nr) / BITS_PER_LONG_LONG)
+#define BITS_PER_BYTE		8
+
+/*
+ * Create a contiguous bitmask starting at bit position @l and ending at
+ * position @h. For example
+ * GENMASK_ULL(39, 21) gives us the 64bit vector 0x000000ffffe00000.
+ */
+#define GENMASK(h, l) \
+	(((~0UL) - (1UL << (l)) + 1) & (~0UL >> (BITS_PER_LONG - 1 - (h))))
+
+#define GENMASK_ULL(h, l) \
+	(((~0ULL) - (1ULL << (l)) + 1) & \
+	 (~0ULL >> (BITS_PER_LONG_LONG - 1 - (h))))
+
+#endif	/* __LINUX_BITS_H */
diff --git a/tools/perf/check-headers.sh b/tools/perf/check-headers.sh
index 466540ee8ea7..c72cc73a6b09 100755
--- a/tools/perf/check-headers.sh
+++ b/tools/perf/check-headers.sh
@@ -14,6 +14,7 @@ include/uapi/linux/sched.h
 include/uapi/linux/stat.h
 include/uapi/linux/vhost.h
 include/uapi/sound/asound.h
+include/linux/bits.h
 include/linux/hash.h
 include/uapi/linux/hw_breakpoint.h
 arch/x86/include/asm/disabled-features.h
-- 
2.14.4

[PATCH 02/12] perf auxtrace: Include missing asm/bitsperlong.h to get BITS_PER_LONG

[Arnaldo Carvalho de Melo]

From: Arnaldo Carvalho de Melo <acme@redhat.com>

The auxtrace.h header references BITS_PER_LONG without including the
header where it is defined, getting it by luck from some other header,
fix it.

Cc: Adrian Hunter <adrian.hunter@intel.com>
Cc: Alexander Sverdlin <alexander.sverdlin@nokia.com>
Cc: David Ahern <dsahern@gmail.com>
Cc: Jiri Olsa <jolsa@kernel.org>
Cc: Namhyung Kim <namhyung@kernel.org>
Cc: Wang Nan <wangnan0@huawei.com>
Link: https://lkml.kernel.org/n/tip-v04ydmbh7tvpcctf3zld9j9s@git.kernel.org
Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
---
 tools/perf/util/auxtrace.h | 1 +
 1 file changed, 1 insertion(+)

diff --git a/tools/perf/util/auxtrace.h b/tools/perf/util/auxtrace.h
index 0a6ce9c4fc11..d88f6e9eb461 100644
--- a/tools/perf/util/auxtrace.h
+++ b/tools/perf/util/auxtrace.h
@@ -23,6 +23,7 @@
 #include <linux/list.h>
 #include <linux/perf_event.h>
 #include <linux/types.h>
+#include <asm/bitsperlong.h>
 
 #include "../perf.h"
 #include "event.h"
-- 
2.14.4

[PATCH 03/12] perf test: S390 does not support watchpoints in test 22

[Arnaldo Carvalho de Melo]

From: Thomas Richter <tmricht@linux.ibm.com>

S390 does not support the perf_event_open system call for
attribute type PERF_TYPE_BREAKPOINT. This results in test
failure for test 22:

  [root@s8360046 perf]# ./perf test 22
  22: Watchpoint                                :
  22.1: Read Only Watchpoint                    : FAILED!
  22.2: Write Only Watchpoint                   : FAILED!
  22.3: Read / Write Watchpoint                 : FAILED!
  22.4: Modify Watchpoint                       : FAILED!
  [root@s8360046 perf]#

Add s390 support to avoid these tests being executed on
s390 platform:

  [root@s8360046 perf]# ./perf test 22
  [root@s8360046 perf]# ./perf test -v 22
  22: Watchpoint                                : Disabled
  [root@s8360046 perf]#

Signed-off-by: Thomas Richter <tmricht@linux.ibm.com>
Reviewed-by: Ravi Bangoria <ravi.bangoria@linux.ibm.com>
Cc: Heiko Carstens <heiko.carstens@de.ibm.com>
Cc: Hendrik Brueckner <brueckner@linux.vnet.ibm.com>
Cc: Martin Schwidefsky <schwidefsky@de.ibm.com>
Link: http://lkml.kernel.org/r/20180928105335.67179-1-tmricht@linux.ibm.com
Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
---
 tools/perf/tests/builtin-test.c |  1 +
 tools/perf/tests/tests.h        |  1 +
 tools/perf/tests/wp.c           | 12 ++++++++++++
 3 files changed, 14 insertions(+)

diff --git a/tools/perf/tests/builtin-test.c b/tools/perf/tests/builtin-test.c
index 54ca7d87236f..12c09e0ece71 100644
--- a/tools/perf/tests/builtin-test.c
+++ b/tools/perf/tests/builtin-test.c
@@ -123,6 +123,7 @@ static struct test generic_tests[] = {
 	{
 		.desc = "Watchpoint",
 		.func = test__wp,
+		.is_supported = test__wp_is_supported,
 		.subtest = {
 			.skip_if_fail	= false,
 			.get_nr		= test__wp_subtest_get_nr,
diff --git a/tools/perf/tests/tests.h b/tools/perf/tests/tests.h
index 8e26a4148f30..b82f55fcc294 100644
--- a/tools/perf/tests/tests.h
+++ b/tools/perf/tests/tests.h
@@ -109,6 +109,7 @@ int test__unit_number__scnprint(struct test *test, int subtest);
 int test__mem2node(struct test *t, int subtest);
 
 bool test__bp_signal_is_supported(void);
+bool test__wp_is_supported(void);
 
 #if defined(__arm__) || defined(__aarch64__)
 #ifdef HAVE_DWARF_UNWIND_SUPPORT
diff --git a/tools/perf/tests/wp.c b/tools/perf/tests/wp.c
index 017a99317f94..f89e6806557b 100644
--- a/tools/perf/tests/wp.c
+++ b/tools/perf/tests/wp.c
@@ -227,3 +227,15 @@ int test__wp(struct test *test __maybe_unused, int i)
 
 	return !wp_testcase_table[i].target_func() ? TEST_OK : TEST_FAIL;
 }
+
+/* The s390 so far does not have support for
+ * instruction breakpoint using the perf_event_open() system call.
+ */
+bool test__wp_is_supported(void)
+{
+#if defined(__s390x__)
+	return false;
+#else
+	return true;
+#endif
+}
-- 
2.14.4

[PATCH 04/12] perf strbuf: Match va_{add,copy} with va_end

[Arnaldo Carvalho de Melo]

From: Sanskriti Sharma <sansharm@redhat.com>

Ensure that all code paths in strbuf_addv() call va_end() on the
ap_saved copy that was made.

Fixes the following coverity complaint:

  Error: VARARGS (CWE-237): [#def683]
  tools/perf/util/strbuf.c:106: missing_va_end: va_end was not called
  for "ap_saved".

Signed-off-by: Sanskriti Sharma <sansharm@redhat.com>
Reviewed-by: Jiri Olsa <jolsa@kernel.org>
Cc: Joe Lawrence <joe.lawrence@redhat.com>
Link: http://lkml.kernel.org/r/1538490554-8161-2-git-send-email-sansharm@redhat.com
Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
---
 tools/perf/util/strbuf.c | 10 ++++++++--
 1 file changed, 8 insertions(+), 2 deletions(-)

diff --git a/tools/perf/util/strbuf.c b/tools/perf/util/strbuf.c
index 3d1cf5bf7f18..9005fbe0780e 100644
--- a/tools/perf/util/strbuf.c
+++ b/tools/perf/util/strbuf.c
@@ -98,19 +98,25 @@ static int strbuf_addv(struct strbuf *sb, const char *fmt, va_list ap)
 
 	va_copy(ap_saved, ap);
 	len = vsnprintf(sb->buf + sb->len, sb->alloc - sb->len, fmt, ap);
-	if (len < 0)
+	if (len < 0) {
+		va_end(ap_saved);
 		return len;
+	}
 	if (len > strbuf_avail(sb)) {
 		ret = strbuf_grow(sb, len);
-		if (ret)
+		if (ret) {
+			va_end(ap_saved);
 			return ret;
+		}
 		len = vsnprintf(sb->buf + sb->len, sb->alloc - sb->len, fmt, ap_saved);
 		va_end(ap_saved);
 		if (len > strbuf_avail(sb)) {
 			pr_debug("this should not happen, your vsnprintf is broken");
+			va_end(ap_saved);
 			return -EINVAL;
 		}
 	}
+	va_end(ap_saved);
 	return strbuf_setlen(sb, sb->len + len);
 }
 
-- 
2.14.4

[PATCH 05/12] perf tools: Cleanup trace-event-info 'tdata' leak

[Arnaldo Carvalho de Melo]

From: Sanskriti Sharma <sansharm@redhat.com>

Free tracing_data structure in tracing_data_get() error paths.

Fixes the following coverity complaint:

  Error: RESOURCE_LEAK (CWE-772):
  leaked_storage: Variable "tdata" going out of scope leaks the storage

Signed-off-by: Sanskriti Sharma <sansharm@redhat.com>
Reviewed-by: Jiri Olsa <jolsa@kernel.org>
Cc: Joe Lawrence <joe.lawrence@redhat.com>
Link: http://lkml.kernel.org/r/1538490554-8161-3-git-send-email-sansharm@redhat.com
Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
---
 tools/perf/util/trace-event-info.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/tools/perf/util/trace-event-info.c b/tools/perf/util/trace-event-info.c
index 7b0ca7cbb7de..8ad8e755127b 100644
--- a/tools/perf/util/trace-event-info.c
+++ b/tools/perf/util/trace-event-info.c
@@ -531,12 +531,14 @@ struct tracing_data *tracing_data_get(struct list_head *pattrs,
 			 "/tmp/perf-XXXXXX");
 		if (!mkstemp(tdata->temp_file)) {
 			pr_debug("Can't make temp file");
+			free(tdata);
 			return NULL;
 		}
 
 		temp_fd = open(tdata->temp_file, O_RDWR);
 		if (temp_fd < 0) {
 			pr_debug("Can't read '%s'", tdata->temp_file);
+			free(tdata);
 			return NULL;
 		}
 
-- 
2.14.4

[PATCH 06/12] perf tools: Free 'printk' string in parse_ftrace_printk()

[Arnaldo Carvalho de Melo]

From: Sanskriti Sharma <sansharm@redhat.com>

parse_ftrace_printk() tokenizes and parses a line, calling strdup() each
iteration.  Add code to free this temporary format string duplicate.

Fixes the following coverity complaints:

  Error: RESOURCE_LEAK (CWE-772):
  tools/perf/util/trace-event-parse.c:158: overwrite_var: Overwriting
  "printk" in "printk = strdup(fmt + 1)" leaks the storage that "printk"
  points to.

  tools/perf/util/trace-event-parse.c:162: leaked_storage: Variable
  "printk" going out of scope leaks the storage it points to.

Signed-off-by: Sanskriti Sharma <sansharm@redhat.com>
Reviewed-by: Jiri Olsa <jolsa@kernel.org>
Cc: Joe Lawrence <joe.lawrence@redhat.com>
Link: http://lkml.kernel.org/r/1538490554-8161-4-git-send-email-sansharm@redhat.com
Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
---
 tools/perf/util/trace-event-parse.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/tools/perf/util/trace-event-parse.c b/tools/perf/util/trace-event-parse.c
index a4d7de1c96d1..02f97f5dd588 100644
--- a/tools/perf/util/trace-event-parse.c
+++ b/tools/perf/util/trace-event-parse.c
@@ -158,6 +158,7 @@ void parse_ftrace_printk(struct tep_handle *pevent,
 		printk = strdup(fmt+1);
 		line = strtok_r(NULL, "\n", &next);
 		tep_register_print_string(pevent, printk, addr);
+		free(printk);
 	}
 }
 
-- 
2.14.4

[PATCH 07/12] perf tools: Avoid double free in read_event_file()

[Arnaldo Carvalho de Melo]

From: Sanskriti Sharma <sansharm@redhat.com>

The temporary 'buf' buffer allocated in read_event_file() may be freed
twice.  Move the free() call to the common function exit point.

Fixes the following coverity complaints:

  Error: USE_AFTER_FREE (CWE-825):
  tools/perf/util/trace-event-read.c:309: double_free: Calling "free"
  frees pointer "buf" which has already been freed.

Signed-off-by: Sanskriti Sharma <sansharm@redhat.com>
Reviewed-by: Jiri Olsa <jolsa@kernel.org>
Cc: Joe Lawrence <joe.lawrence@redhat.com>
Link: http://lkml.kernel.org/r/1538490554-8161-5-git-send-email-sansharm@redhat.com
Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
---
 tools/perf/util/trace-event-read.c | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)

diff --git a/tools/perf/util/trace-event-read.c b/tools/perf/util/trace-event-read.c
index b98ee2a2eb44..a278e1eee5f5 100644
--- a/tools/perf/util/trace-event-read.c
+++ b/tools/perf/util/trace-event-read.c
@@ -297,10 +297,8 @@ static int read_event_file(struct tep_handle *pevent, char *sys,
 	}
 
 	ret = do_read(buf, size);
-	if (ret < 0) {
-		free(buf);
+	if (ret < 0)
 		goto out;
-	}
 
 	ret = parse_event_file(pevent, buf, size, sys);
 	if (ret < 0)
-- 
2.14.4

[PATCH 08/12] perf tools: Free temporary 'sys' string in read_event_files()

[Arnaldo Carvalho de Melo]

From: Sanskriti Sharma <sansharm@redhat.com>

For each system in a given pevent, read_event_files() reads in a
temporary 'sys' string.  Be sure to free this string before moving onto
to the next system and/or leaving read_event_files().

Fixes the following coverity complaints:

  Error: RESOURCE_LEAK (CWE-772):

  tools/perf/util/trace-event-read.c:343: overwrite_var: Overwriting
  "sys" in "sys = read_string()" leaks the storage that "sys" points to.

  tools/perf/util/trace-event-read.c:353: leaked_storage: Variable "sys"
  going out of scope leaks the storage it points to.

Signed-off-by: Sanskriti Sharma <sansharm@redhat.com>
Reviewed-by: Jiri Olsa <jolsa@kernel.org>
Cc: Joe Lawrence <joe.lawrence@redhat.com>
Link: http://lkml.kernel.org/r/1538490554-8161-6-git-send-email-sansharm@redhat.com
Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
---
 tools/perf/util/trace-event-read.c | 5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)

diff --git a/tools/perf/util/trace-event-read.c b/tools/perf/util/trace-event-read.c
index a278e1eee5f5..add8441de579 100644
--- a/tools/perf/util/trace-event-read.c
+++ b/tools/perf/util/trace-event-read.c
@@ -347,9 +347,12 @@ static int read_event_files(struct tep_handle *pevent)
 		for (x=0; x < count; x++) {
 			size = read8(pevent);
 			ret = read_event_file(pevent, sys, size);
-			if (ret)
+			if (ret) {
+				free(sys);
 				return ret;
+			}
 		}
+		free(sys);
 	}
 	return 0;
 }
-- 
2.14.4

[PATCH 09/12] perf python: Make clang_has_option() work on Python 3

[Arnaldo Carvalho de Melo]

From: Eduardo Habkost <ehabkost@redhat.com>

Use a bytes literal so it works with Python 3's version of Popen().
Note that the b"..." syntax requires Python 2.6+.

Signed-off-by: Eduardo Habkost <ehabkost@redhat.com>
Cc: Adrian Hunter <adrian.hunter@intel.com>
Cc: David Ahern <dsahern@gmail.com>
Cc: Jiri Olsa <jolsa@kernel.org>
Cc: Namhyung Kim <namhyung@kernel.org>
Cc: Wang Nan <wangnan0@huawei.com>
Link: http://lkml.kernel.org/r/20181005204058.7966-2-ehabkost@redhat.com
Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
---
 tools/perf/util/setup.py | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/tools/perf/util/setup.py b/tools/perf/util/setup.py
index 1942f6dd24f6..261a55e7e1b2 100644
--- a/tools/perf/util/setup.py
+++ b/tools/perf/util/setup.py
@@ -5,7 +5,7 @@ from subprocess import Popen, PIPE
 from re import sub
 
 def clang_has_option(option):
-    return [o for o in Popen(['clang', option], stderr=PIPE).stderr.readlines() if "unknown argument" in o] == [ ]
+    return [o for o in Popen(['clang', option], stderr=PIPE).stderr.readlines() if b"unknown argument" in o] == [ ]
 
 cc = getenv("CC")
 if cc == "clang":
-- 
2.14.4

[PATCH 10/12] perf python: More portable way to make CFLAGS work with clang

[Arnaldo Carvalho de Melo]

From: Eduardo Habkost <ehabkost@redhat.com>

The existing code that tries to make CFLAGS compatible with clang
doesn't work with Python 3.

Instead of trying to touch _sysconfigdata.build_time_vars directly,
change the dictionary returned by disutils.sysconfig.get_config_vars().
This works on both Python 2 and Python 3.

Signed-off-by: Eduardo Habkost <ehabkost@redhat.com>
Reported-by: Arnaldo Carvalho de Melo <acme@redhat.com>
Tested-by: Arnaldo Carvalho de Melo <acme@redhat.com>
Cc: Adrian Hunter <adrian.hunter@intel.com>
Cc: David Ahern <dsahern@gmail.com>
Cc: Jiri Olsa <jolsa@kernel.org>
Cc: Namhyung Kim <namhyung@kernel.org>
Cc: Wang Nan <wangnan0@huawei.com>
Link: http://lkml.kernel.org/r/20181005204058.7966-3-ehabkost@redhat.com
Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
---
 tools/perf/util/setup.py | 14 ++++++++------
 1 file changed, 8 insertions(+), 6 deletions(-)

diff --git a/tools/perf/util/setup.py b/tools/perf/util/setup.py
index 261a55e7e1b2..63f758c655d5 100644
--- a/tools/perf/util/setup.py
+++ b/tools/perf/util/setup.py
@@ -9,12 +9,14 @@ def clang_has_option(option):
 
 cc = getenv("CC")
 if cc == "clang":
-    from _sysconfigdata import build_time_vars
-    build_time_vars["CFLAGS"] = sub("-specs=[^ ]+", "", build_time_vars["CFLAGS"])
-    if not clang_has_option("-mcet"):
-        build_time_vars["CFLAGS"] = sub("-mcet", "", build_time_vars["CFLAGS"])
-    if not clang_has_option("-fcf-protection"):
-        build_time_vars["CFLAGS"] = sub("-fcf-protection", "", build_time_vars["CFLAGS"])
+    from distutils.sysconfig import get_config_vars
+    vars = get_config_vars()
+    for var in ('CFLAGS', 'OPT'):
+        vars[var] = sub("-specs=[^ ]+", "", vars[var])
+        if not clang_has_option("-mcet"):
+            vars[var] = sub("-mcet", "", vars[var])
+        if not clang_has_option("-fcf-protection"):
+            vars[var] = sub("-fcf-protection", "", vars[var])
 
 from distutils.core import setup, Extension
 
-- 
2.14.4

[PATCH 11/12] tools lib traceevent: Separate out tep_strerror() for strerror_r() issues

[Arnaldo Carvalho de Melo]

From: "Steven Rostedt (VMware)" <rostedt@goodmis.org>

While working on having PowerTop use libtracevent as a shared object
library, Tzvetomir hit "str_error_r not defined". This was added by commit
c3cec9e68f12d ("tools lib traceevent: Use str_error_r()") because
strerror_r() has two definitions, where one is GNU specific, and the other
is XSI complient. The strerror_r() is in a wrapper str_error_r() to keep the
code from having to worry about which compiler is being used.

The problem is that str_error_r() is external to libtraceevent, and not part
of the library. If it is used as a shared object then the tools using it
will need to define that function. I do not want that function defined in
libtraceevent itself, as it is out of scope for that library.

As there's only a single instance of this call, and its in the traceevent
library's own tep_strerror() function, we can copy what was done in perf,
and create yet another external file that undefs _GNU_SOURCE to use the more
portable version of the function. We don't need to worry about the errors
that strerror_r() returns. If the buffer isn't big enough, we simply
truncate it.

Reported-by: Tzvetomir Stoyanov <tstoyanov@vmware.com>
Signed-off-by: Steven Rostedt (VMware) <rostedt@goodmis.org>
Cc: Jiri Olsa <jolsa@redhat.com>
Cc: Namhyung Kim <namhyung@kernel.org>
Cc: Tzvetomir Stoyanov (VMware) <tz.stoyanov@gmail.com>
Cc: linux trace devel <linux-trace-devel@vger.kernel.org>
Link: http://lkml.kernel.org/r/20181005121816.484e654f@gandalf.local.home
Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
---
 tools/lib/traceevent/Build          |  1 +
 tools/lib/traceevent/event-parse.c  | 30 ---------------------
 tools/lib/traceevent/tep_strerror.c | 53 +++++++++++++++++++++++++++++++++++++
 3 files changed, 54 insertions(+), 30 deletions(-)
 create mode 100644 tools/lib/traceevent/tep_strerror.c

diff --git a/tools/lib/traceevent/Build b/tools/lib/traceevent/Build
index c681d0575d16..0050c145d806 100644
--- a/tools/lib/traceevent/Build
+++ b/tools/lib/traceevent/Build
@@ -4,6 +4,7 @@ libtraceevent-y += trace-seq.o
 libtraceevent-y += parse-filter.o
 libtraceevent-y += parse-utils.o
 libtraceevent-y += kbuffer-parse.o
+libtraceevent-y += tep_strerror.o
 
 plugin_jbd2-y         += plugin_jbd2.o
 plugin_hrtimer-y      += plugin_hrtimer.o
diff --git a/tools/lib/traceevent/event-parse.c b/tools/lib/traceevent/event-parse.c
index 7980fc6c3bac..233179a712d6 100644
--- a/tools/lib/traceevent/event-parse.c
+++ b/tools/lib/traceevent/event-parse.c
@@ -18,7 +18,6 @@
 #include <errno.h>
 #include <stdint.h>
 #include <limits.h>
-#include <linux/string.h>
 #include <linux/time64.h>
 
 #include <netinet/in.h>
@@ -6201,35 +6200,6 @@ enum tep_errno tep_parse_event(struct tep_handle *pevent, const char *buf,
 	return __parse_event(pevent, &event, buf, size, sys);
 }
 
-#undef _PE
-#define _PE(code, str) str
-static const char * const tep_error_str[] = {
-	TEP_ERRORS
-};
-#undef _PE
-
-int tep_strerror(struct tep_handle *pevent __maybe_unused,
-		 enum tep_errno errnum, char *buf, size_t buflen)
-{
-	int idx;
-	const char *msg;
-
-	if (errnum >= 0) {
-		str_error_r(errnum, buf, buflen);
-		return 0;
-	}
-
-	if (errnum <= __TEP_ERRNO__START ||
-	    errnum >= __TEP_ERRNO__END)
-		return -1;
-
-	idx = errnum - __TEP_ERRNO__START - 1;
-	msg = tep_error_str[idx];
-	snprintf(buf, buflen, "%s", msg);
-
-	return 0;
-}
-
 int get_field_val(struct trace_seq *s, struct tep_format_field *field,
 		  const char *name, struct tep_record *record,
 		  unsigned long long *val, int err)
diff --git a/tools/lib/traceevent/tep_strerror.c b/tools/lib/traceevent/tep_strerror.c
new file mode 100644
index 000000000000..4ac26445b2f6
--- /dev/null
+++ b/tools/lib/traceevent/tep_strerror.c
@@ -0,0 +1,53 @@
+// SPDX-License-Identifier: LGPL-2.1
+#undef _GNU_SOURCE
+#include <string.h>
+#include <stdio.h>
+
+#include "event-parse.h"
+
+#undef _PE
+#define _PE(code, str) str
+static const char * const tep_error_str[] = {
+	TEP_ERRORS
+};
+#undef _PE
+
+/*
+ * The tools so far have been using the strerror_r() GNU variant, that returns
+ * a string, be it the buffer passed or something else.
+ *
+ * But that, besides being tricky in cases where we expect that the function
+ * using strerror_r() returns the error formatted in a provided buffer (we have
+ * to check if it returned something else and copy that instead), breaks the
+ * build on systems not using glibc, like Alpine Linux, where musl libc is
+ * used.
+ *
+ * So, introduce yet another wrapper, str_error_r(), that has the GNU
+ * interface, but uses the portable XSI variant of strerror_r(), so that users
+ * rest asured that the provided buffer is used and it is what is returned.
+ */
+int tep_strerror(struct tep_handle *tep __maybe_unused,
+		 enum tep_errno errnum, char *buf, size_t buflen)
+{
+	const char *msg;
+	int idx;
+
+	if (!buflen)
+		return 0;
+
+	if (errnum >= 0) {
+		int err = strerror_r(errnum, buf, buflen);
+		buf[buflen - 1] = 0;
+		return err;
+	}
+
+	if (errnum <= __TEP_ERRNO__START ||
+	    errnum >= __TEP_ERRNO__END)
+		return -1;
+
+	idx = errnum - __TEP_ERRNO__START - 1;
+	msg = tep_error_str[idx];
+	snprintf(buf, buflen, "%s", msg);
+
+	return 0;
+}
-- 
2.14.4

[PATCH 12/12] tools lib traceevent, perf tools: Move struct tep_handler definition in a local header file

[Arnaldo Carvalho de Melo]

From: Tzvetomir Stoyanov <tstoyanov@vmware.com>

As traceevent is going to be transferred into a proper library,
its local data should be protected from the library users.
This patch encapsulates struct tep_handler into a local header,
not visible outside of the library. It implements also a bunch
of new APIs, which library users can use to access tep_handler members.

Signed-off-by: Tzvetomir Stoyanov <tstoyanov@vmware.com>
Cc: Jiri Olsa <jolsa@redhat.com>
Cc: Namhyung Kim <namhyung@kernel.org>
Cc: linux trace devel <linux-trace-devel@vger.kernel.org>
Cc: tzvetomir stoyanov <tstoyanov@vmware.com>
Link: http://lkml.kernel.org/r/20181005122225.522155df@gandalf.local.home
Signed-off-by: Steven Rostedt (VMware) <rostedt@goodmis.org>
Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
---
 tools/lib/traceevent/Build               |   1 +
 tools/lib/traceevent/event-parse-api.c   | 275 +++++++++++++++++++++++++++++++
 tools/lib/traceevent/event-parse-local.h |  92 +++++++++++
 tools/lib/traceevent/event-parse.c       |   2 +
 tools/lib/traceevent/event-parse.h       | 228 ++++---------------------
 tools/lib/traceevent/event-plugin.c      |   1 +
 tools/lib/traceevent/parse-filter.c      |   1 +
 tools/perf/util/trace-event-parse.c      |  25 +--
 tools/perf/util/trace-event-read.c       |   2 +-
 9 files changed, 416 insertions(+), 211 deletions(-)
 create mode 100644 tools/lib/traceevent/event-parse-api.c
 create mode 100644 tools/lib/traceevent/event-parse-local.h

diff --git a/tools/lib/traceevent/Build b/tools/lib/traceevent/Build
index 0050c145d806..ba54bfce0b0b 100644
--- a/tools/lib/traceevent/Build
+++ b/tools/lib/traceevent/Build
@@ -5,6 +5,7 @@ libtraceevent-y += parse-filter.o
 libtraceevent-y += parse-utils.o
 libtraceevent-y += kbuffer-parse.o
 libtraceevent-y += tep_strerror.o
+libtraceevent-y += event-parse-api.o
 
 plugin_jbd2-y         += plugin_jbd2.o
 plugin_hrtimer-y      += plugin_hrtimer.o
diff --git a/tools/lib/traceevent/event-parse-api.c b/tools/lib/traceevent/event-parse-api.c
new file mode 100644
index 000000000000..61f7149085ee
--- /dev/null
+++ b/tools/lib/traceevent/event-parse-api.c
@@ -0,0 +1,275 @@
+// SPDX-License-Identifier: LGPL-2.1
+/*
+ * Copyright (C) 2009, 2010 Red Hat Inc, Steven Rostedt <srostedt@redhat.com>
+ *
+ */
+
+#include "event-parse.h"
+#include "event-parse-local.h"
+#include "event-utils.h"
+
+/**
+ * tep_get_first_event - returns the first event in the events array
+ * @tep: a handle to the tep_handle
+ *
+ * This returns pointer to the first element of the events array
+ * If @tep is NULL, NULL is returned.
+ */
+struct tep_event_format *tep_get_first_event(struct tep_handle *tep)
+{
+	if (tep && tep->events)
+		return tep->events[0];
+
+	return NULL;
+}
+
+/**
+ * tep_get_events_count - get the number of defined events
+ * @tep: a handle to the tep_handle
+ *
+ * This returns number of elements in event array
+ * If @tep is NULL, 0 is returned.
+ */
+int tep_get_events_count(struct tep_handle *tep)
+{
+	if(tep)
+		return tep->nr_events;
+	return 0;
+}
+
+/**
+ * tep_set_flag - set event parser flag
+ * @tep: a handle to the tep_handle
+ * @flag: flag, or combination of flags to be set
+ * can be any combination from enum tep_flag
+ *
+ * This sets a flag or mbination of flags  from enum tep_flag
+  */
+void tep_set_flag(struct tep_handle *tep, int flag)
+{
+	if(tep)
+		tep->flags |= flag;
+}
+
+unsigned short __tep_data2host2(struct tep_handle *pevent, unsigned short data)
+{
+	unsigned short swap;
+
+	if (!pevent || pevent->host_bigendian == pevent->file_bigendian)
+		return data;
+
+	swap = ((data & 0xffULL) << 8) |
+		((data & (0xffULL << 8)) >> 8);
+
+	return swap;
+}
+
+unsigned int __tep_data2host4(struct tep_handle *pevent, unsigned int data)
+{
+	unsigned int swap;
+
+	if (!pevent || pevent->host_bigendian == pevent->file_bigendian)
+		return data;
+
+	swap = ((data & 0xffULL) << 24) |
+		((data & (0xffULL << 8)) << 8) |
+		((data & (0xffULL << 16)) >> 8) |
+		((data & (0xffULL << 24)) >> 24);
+
+	return swap;
+}
+
+unsigned long long
+__tep_data2host8(struct tep_handle *pevent, unsigned long long data)
+{
+	unsigned long long swap;
+
+	if (!pevent || pevent->host_bigendian == pevent->file_bigendian)
+		return data;
+
+	swap = ((data & 0xffULL) << 56) |
+		((data & (0xffULL << 8)) << 40) |
+		((data & (0xffULL << 16)) << 24) |
+		((data & (0xffULL << 24)) << 8) |
+		((data & (0xffULL << 32)) >> 8) |
+		((data & (0xffULL << 40)) >> 24) |
+		((data & (0xffULL << 48)) >> 40) |
+		((data & (0xffULL << 56)) >> 56);
+
+	return swap;
+}
+
+/**
+ * tep_get_header_page_size - get size of the header page
+ * @pevent: a handle to the tep_handle
+ *
+ * This returns size of the header page
+ * If @pevent is NULL, 0 is returned.
+ */
+int tep_get_header_page_size(struct tep_handle *pevent)
+{
+	if(pevent)
+		return pevent->header_page_size_size;
+	return 0;
+}
+
+/**
+ * tep_get_cpus - get the number of CPUs
+ * @pevent: a handle to the tep_handle
+ *
+ * This returns the number of CPUs
+ * If @pevent is NULL, 0 is returned.
+ */
+int tep_get_cpus(struct tep_handle *pevent)
+{
+	if(pevent)
+		return pevent->cpus;
+	return 0;
+}
+
+/**
+ * tep_set_cpus - set the number of CPUs
+ * @pevent: a handle to the tep_handle
+ *
+ * This sets the number of CPUs
+ */
+void tep_set_cpus(struct tep_handle *pevent, int cpus)
+{
+	if(pevent)
+		pevent->cpus = cpus;
+}
+
+/**
+ * tep_get_long_size - get the size of a long integer on the current machine
+ * @pevent: a handle to the tep_handle
+ *
+ * This returns the size of a long integer on the current machine
+ * If @pevent is NULL, 0 is returned.
+ */
+int tep_get_long_size(struct tep_handle *pevent)
+{
+	if(pevent)
+		return pevent->long_size;
+	return 0;
+}
+
+/**
+ * tep_set_long_size - set the size of a long integer on the current machine
+ * @pevent: a handle to the tep_handle
+ * @size: size, in bytes, of a long integer
+ *
+ * This sets the size of a long integer on the current machine
+ */
+void tep_set_long_size(struct tep_handle *pevent, int long_size)
+{
+	if(pevent)
+		pevent->long_size = long_size;
+}
+
+/**
+ * tep_get_page_size - get the size of a memory page on the current machine
+ * @pevent: a handle to the tep_handle
+ *
+ * This returns the size of a memory page on the current machine
+ * If @pevent is NULL, 0 is returned.
+ */
+int tep_get_page_size(struct tep_handle *pevent)
+{
+	if(pevent)
+		return pevent->page_size;
+	return 0;
+}
+
+/**
+ * tep_set_page_size - set the size of a memory page on the current machine
+ * @pevent: a handle to the tep_handle
+ * @_page_size: size of a memory page, in bytes
+ *
+ * This sets the size of a memory page on the current machine
+ */
+void tep_set_page_size(struct tep_handle *pevent, int _page_size)
+{
+	if(pevent)
+		pevent->page_size = _page_size;
+}
+
+/**
+ * tep_is_file_bigendian - get if the file is in big endian order
+ * @pevent: a handle to the tep_handle
+ *
+ * This returns if the file is in big endian order
+ * If @pevent is NULL, 0 is returned.
+ */
+int tep_is_file_bigendian(struct tep_handle *pevent)
+{
+	if(pevent)
+		return pevent->file_bigendian;
+	return 0;
+}
+
+/**
+ * tep_set_file_bigendian - set if the file is in big endian order
+ * @pevent: a handle to the tep_handle
+ * @endian: non zero, if the file is in big endian order
+ *
+ * This sets if the file is in big endian order
+ */
+void tep_set_file_bigendian(struct tep_handle *pevent, enum tep_endian endian)
+{
+	if(pevent)
+		pevent->file_bigendian = endian;
+}
+
+/**
+ * tep_is_host_bigendian - get if the order of the current host is big endian
+ * @pevent: a handle to the tep_handle
+ *
+ * This gets if the order of the current host is big endian
+ * If @pevent is NULL, 0 is returned.
+ */
+int tep_is_host_bigendian(struct tep_handle *pevent)
+{
+	if(pevent)
+		return pevent->host_bigendian;
+	return 0;
+}
+
+/**
+ * tep_set_host_bigendian - set the order of the local host
+ * @pevent: a handle to the tep_handle
+ * @endian: non zero, if the local host has big endian order
+ *
+ * This sets the order of the local host
+ */
+void tep_set_host_bigendian(struct tep_handle *pevent, enum tep_endian endian)
+{
+	if(pevent)
+		pevent->host_bigendian = endian;
+}
+
+/**
+ * tep_is_latency_format - get if the latency output format is configured
+ * @pevent: a handle to the tep_handle
+ *
+ * This gets if the latency output format is configured
+ * If @pevent is NULL, 0 is returned.
+ */
+int tep_is_latency_format(struct tep_handle *pevent)
+{
+	if(pevent)
+		return pevent->latency_format;
+	return 0;
+}
+
+/**
+ * tep_set_latency_format - set the latency output format
+ * @pevent: a handle to the tep_handle
+ * @lat: non zero for latency output format
+ *
+ * This sets the latency output format
+  */
+void tep_set_latency_format(struct tep_handle *pevent, int lat)
+{
+	if(pevent)
+		pevent->latency_format = lat;
+}
diff --git a/tools/lib/traceevent/event-parse-local.h b/tools/lib/traceevent/event-parse-local.h
new file mode 100644
index 000000000000..b9bddde577f8
--- /dev/null
+++ b/tools/lib/traceevent/event-parse-local.h
@@ -0,0 +1,92 @@
+// SPDX-License-Identifier: LGPL-2.1
+/*
+ * Copyright (C) 2009, 2010 Red Hat Inc, Steven Rostedt <srostedt@redhat.com>
+ *
+ */
+
+#ifndef _PARSE_EVENTS_INT_H
+#define _PARSE_EVENTS_INT_H
+
+struct cmdline;
+struct cmdline_list;
+struct func_map;
+struct func_list;
+struct event_handler;
+struct func_resolver;
+
+struct tep_handle {
+	int ref_count;
+
+	int header_page_ts_offset;
+	int header_page_ts_size;
+	int header_page_size_offset;
+	int header_page_size_size;
+	int header_page_data_offset;
+	int header_page_data_size;
+	int header_page_overwrite;
+
+	enum tep_endian file_bigendian;
+	enum tep_endian host_bigendian;
+
+	int latency_format;
+
+	int old_format;
+
+	int cpus;
+	int long_size;
+	int page_size;
+
+	struct cmdline *cmdlines;
+	struct cmdline_list *cmdlist;
+	int cmdline_count;
+
+	struct func_map *func_map;
+	struct func_resolver *func_resolver;
+	struct func_list *funclist;
+	unsigned int func_count;
+
+	struct printk_map *printk_map;
+	struct printk_list *printklist;
+	unsigned int printk_count;
+
+
+	struct tep_event_format **events;
+	int nr_events;
+	struct tep_event_format **sort_events;
+	enum tep_event_sort_type last_type;
+
+	int type_offset;
+	int type_size;
+
+	int pid_offset;
+	int pid_size;
+
+	int pc_offset;
+	int pc_size;
+
+	int flags_offset;
+	int flags_size;
+
+	int ld_offset;
+	int ld_size;
+
+	int print_raw;
+
+	int test_filters;
+
+	int flags;
+
+	struct tep_format_field *bprint_ip_field;
+	struct tep_format_field *bprint_fmt_field;
+	struct tep_format_field *bprint_buf_field;
+
+	struct event_handler *handlers;
+	struct tep_function_handler *func_handlers;
+
+	/* cache */
+	struct tep_event_format *last_event;
+
+	char *trace_clock;
+};
+
+#endif /* _PARSE_EVENTS_INT_H */
diff --git a/tools/lib/traceevent/event-parse.c b/tools/lib/traceevent/event-parse.c
index 233179a712d6..3692f29fee46 100644
--- a/tools/lib/traceevent/event-parse.c
+++ b/tools/lib/traceevent/event-parse.c
@@ -22,6 +22,8 @@
 
 #include <netinet/in.h>
 #include "event-parse.h"
+
+#include "event-parse-local.h"
 #include "event-utils.h"
 #include "trace-seq.h"
 
diff --git a/tools/lib/traceevent/event-parse.h b/tools/lib/traceevent/event-parse.h
index 9c29a5f7aa39..16bf4c890b6f 100644
--- a/tools/lib/traceevent/event-parse.h
+++ b/tools/lib/traceevent/event-parse.h
@@ -405,149 +405,18 @@ void tep_print_plugins(struct trace_seq *s,
 			const char *prefix, const char *suffix,
 			const struct tep_plugin_list *list);
 
-struct cmdline;
-struct cmdline_list;
-struct func_map;
-struct func_list;
-struct event_handler;
-struct func_resolver;
-
+/* tep_handle */
 typedef char *(tep_func_resolver_t)(void *priv,
 				    unsigned long long *addrp, char **modp);
+void tep_set_flag(struct tep_handle *tep, int flag);
+unsigned short __tep_data2host2(struct tep_handle *pevent, unsigned short data);
+unsigned int __tep_data2host4(struct tep_handle *pevent, unsigned int data);
+unsigned long long
+__tep_data2host8(struct tep_handle *pevent, unsigned long long data);
 
-struct tep_handle {
-	int ref_count;
-
-	int header_page_ts_offset;
-	int header_page_ts_size;
-	int header_page_size_offset;
-	int header_page_size_size;
-	int header_page_data_offset;
-	int header_page_data_size;
-	int header_page_overwrite;
-
-	int file_bigendian;
-	int host_bigendian;
-
-	int latency_format;
-
-	int old_format;
-
-	int cpus;
-	int long_size;
-	int page_size;
-
-	struct cmdline *cmdlines;
-	struct cmdline_list *cmdlist;
-	int cmdline_count;
-
-	struct func_map *func_map;
-	struct func_resolver *func_resolver;
-	struct func_list *funclist;
-	unsigned int func_count;
-
-	struct printk_map *printk_map;
-	struct printk_list *printklist;
-	unsigned int printk_count;
-
-
-	struct tep_event_format **events;
-	int nr_events;
-	struct tep_event_format **sort_events;
-	enum tep_event_sort_type last_type;
-
-	int type_offset;
-	int type_size;
-
-	int pid_offset;
-	int pid_size;
-
- 	int pc_offset;
-	int pc_size;
-
-	int flags_offset;
-	int flags_size;
-
-	int ld_offset;
-	int ld_size;
-
-	int print_raw;
-
-	int test_filters;
-
-	int flags;
-
-	struct tep_format_field *bprint_ip_field;
-	struct tep_format_field *bprint_fmt_field;
-	struct tep_format_field *bprint_buf_field;
-
-	struct event_handler *handlers;
-	struct tep_function_handler *func_handlers;
-
-	/* cache */
-	struct tep_event_format *last_event;
-
-	char *trace_clock;
-};
-
-static inline void tep_set_flag(struct tep_handle *pevent, int flag)
-{
-	pevent->flags |= flag;
-}
-
-static inline unsigned short
-__tep_data2host2(struct tep_handle *pevent, unsigned short data)
-{
-	unsigned short swap;
-
-	if (pevent->host_bigendian == pevent->file_bigendian)
-		return data;
-
-	swap = ((data & 0xffULL) << 8) |
-		((data & (0xffULL << 8)) >> 8);
-
-	return swap;
-}
-
-static inline unsigned int
-__tep_data2host4(struct tep_handle *pevent, unsigned int data)
-{
-	unsigned int swap;
-
-	if (pevent->host_bigendian == pevent->file_bigendian)
-		return data;
-
-	swap = ((data & 0xffULL) << 24) |
-		((data & (0xffULL << 8)) << 8) |
-		((data & (0xffULL << 16)) >> 8) |
-		((data & (0xffULL << 24)) >> 24);
-
-	return swap;
-}
-
-static inline unsigned long long
-__tep_data2host8(struct tep_handle *pevent, unsigned long long data)
-{
-	unsigned long long swap;
-
-	if (pevent->host_bigendian == pevent->file_bigendian)
-		return data;
-
-	swap = ((data & 0xffULL) << 56) |
-		((data & (0xffULL << 8)) << 40) |
-		((data & (0xffULL << 16)) << 24) |
-		((data & (0xffULL << 24)) << 8) |
-		((data & (0xffULL << 32)) >> 8) |
-		((data & (0xffULL << 40)) >> 24) |
-		((data & (0xffULL << 48)) >> 40) |
-		((data & (0xffULL << 56)) >> 56);
-
-	return swap;
-}
-
-#define tep_data2host2(pevent, ptr)		__tep_data2host2(pevent, *(unsigned short *)(ptr))
-#define tep_data2host4(pevent, ptr)		__tep_data2host4(pevent, *(unsigned int *)(ptr))
-#define tep_data2host8(pevent, ptr)					\
+#define tep_data2host2(pevent, ptr)	__tep_data2host2(pevent, *(unsigned short *)(ptr))
+#define tep_data2host4(pevent, ptr)	__tep_data2host4(pevent, *(unsigned int *)(ptr))
+#define tep_data2host8(pevent, ptr)	\
 ({								\
 	unsigned long long __val;				\
 								\
@@ -655,11 +524,12 @@ unsigned long long tep_read_number(struct tep_handle *pevent, const void *ptr, i
 int tep_read_number_field(struct tep_format_field *field, const void *data,
 			  unsigned long long *value);
 
+struct tep_event_format *tep_get_first_event(struct tep_handle *tep);
+int tep_get_events_count(struct tep_handle *tep);
 struct tep_event_format *tep_find_event(struct tep_handle *pevent, int id);
 
 struct tep_event_format *
 tep_find_event_by_name(struct tep_handle *pevent, const char *sys, const char *name);
-
 struct tep_event_format *
 tep_find_event_by_record(struct tep_handle *pevent, struct tep_record *record);
 
@@ -689,65 +559,23 @@ struct tep_event_format **tep_list_events(struct tep_handle *pevent, enum tep_ev
 struct tep_format_field **tep_event_common_fields(struct tep_event_format *event);
 struct tep_format_field **tep_event_fields(struct tep_event_format *event);
 
-static inline int tep_get_cpus(struct tep_handle *pevent)
-{
-	return pevent->cpus;
-}
-
-static inline void tep_set_cpus(struct tep_handle *pevent, int cpus)
-{
-	pevent->cpus = cpus;
-}
-
-static inline int tep_get_long_size(struct tep_handle *pevent)
-{
-	return pevent->long_size;
-}
-
-static inline void tep_set_long_size(struct tep_handle *pevent, int long_size)
-{
-	pevent->long_size = long_size;
-}
-
-static inline int tep_get_page_size(struct tep_handle *pevent)
-{
-	return pevent->page_size;
-}
-
-static inline void tep_set_page_size(struct tep_handle *pevent, int _page_size)
-{
-	pevent->page_size = _page_size;
-}
-
-static inline int tep_is_file_bigendian(struct tep_handle *pevent)
-{
-	return pevent->file_bigendian;
-}
-
-static inline void tep_set_file_bigendian(struct tep_handle *pevent, int endian)
-{
-	pevent->file_bigendian = endian;
-}
-
-static inline int tep_is_host_bigendian(struct tep_handle *pevent)
-{
-	return pevent->host_bigendian;
-}
-
-static inline void tep_set_host_bigendian(struct tep_handle *pevent, int endian)
-{
-	pevent->host_bigendian = endian;
-}
-
-static inline int tep_is_latency_format(struct tep_handle *pevent)
-{
-	return pevent->latency_format;
-}
-
-static inline void tep_set_latency_format(struct tep_handle *pevent, int lat)
-{
-	pevent->latency_format = lat;
-}
+enum tep_endian {
+        TEP_LITTLE_ENDIAN = 0,
+        TEP_BIG_ENDIAN
+};
+int tep_get_cpus(struct tep_handle *pevent);
+void tep_set_cpus(struct tep_handle *pevent, int cpus);
+int tep_get_long_size(struct tep_handle *pevent);
+void tep_set_long_size(struct tep_handle *pevent, int long_size);
+int tep_get_page_size(struct tep_handle *pevent);
+void tep_set_page_size(struct tep_handle *pevent, int _page_size);
+int tep_is_file_bigendian(struct tep_handle *pevent);
+void tep_set_file_bigendian(struct tep_handle *pevent, enum tep_endian endian);
+int tep_is_host_bigendian(struct tep_handle *pevent);
+void tep_set_host_bigendian(struct tep_handle *pevent, enum tep_endian endian);
+int tep_is_latency_format(struct tep_handle *pevent);
+void tep_set_latency_format(struct tep_handle *pevent, int lat);
+int tep_get_header_page_size(struct tep_handle *pevent);
 
 struct tep_handle *tep_alloc(void);
 void tep_free(struct tep_handle *pevent);
diff --git a/tools/lib/traceevent/event-plugin.c b/tools/lib/traceevent/event-plugin.c
index 46eb64eb0c2e..e74f16c88398 100644
--- a/tools/lib/traceevent/event-plugin.c
+++ b/tools/lib/traceevent/event-plugin.c
@@ -14,6 +14,7 @@
 #include <unistd.h>
 #include <dirent.h>
 #include "event-parse.h"
+#include "event-parse-local.h"
 #include "event-utils.h"
 #include "trace-seq.h"
 
diff --git a/tools/lib/traceevent/parse-filter.c b/tools/lib/traceevent/parse-filter.c
index d64b6128fa7d..ed87cb56713d 100644
--- a/tools/lib/traceevent/parse-filter.c
+++ b/tools/lib/traceevent/parse-filter.c
@@ -11,6 +11,7 @@
 #include <sys/types.h>
 
 #include "event-parse.h"
+#include "event-parse-local.h"
 #include "event-utils.h"
 
 #define COMM "COMM"
diff --git a/tools/perf/util/trace-event-parse.c b/tools/perf/util/trace-event-parse.c
index 02f97f5dd588..32e558a65af3 100644
--- a/tools/perf/util/trace-event-parse.c
+++ b/tools/perf/util/trace-event-parse.c
@@ -37,10 +37,11 @@ static int get_common_field(struct scripting_context *context,
 	struct tep_format_field *field;
 
 	if (!*size) {
-		if (!pevent->events)
+
+		event = tep_get_first_event(pevent);
+		if (!event)
 			return 0;
 
-		event = pevent->events[0];
 		field = tep_find_common_field(event, type);
 		if (!field)
 			return 0;
@@ -193,25 +194,29 @@ struct tep_event_format *trace_find_next_event(struct tep_handle *pevent,
 					       struct tep_event_format *event)
 {
 	static int idx;
+	int events_count;
+	struct tep_event_format *all_events;
 
-	if (!pevent || !pevent->events)
+	all_events = tep_get_first_event(pevent);
+	events_count = tep_get_events_count(pevent);
+	if (!pevent || !all_events || events_count < 1)
 		return NULL;
 
 	if (!event) {
 		idx = 0;
-		return pevent->events[0];
+		return all_events;
 	}
 
-	if (idx < pevent->nr_events && event == pevent->events[idx]) {
+	if (idx < events_count && event == (all_events + idx)) {
 		idx++;
-		if (idx == pevent->nr_events)
+		if (idx == events_count)
 			return NULL;
-		return pevent->events[idx];
+		return (all_events + idx);
 	}
 
-	for (idx = 1; idx < pevent->nr_events; idx++) {
-		if (event == pevent->events[idx - 1])
-			return pevent->events[idx];
+	for (idx = 1; idx < events_count; idx++) {
+		if (event == (all_events + (idx - 1)))
+			return (all_events + idx);
 	}
 	return NULL;
 }
diff --git a/tools/perf/util/trace-event-read.c b/tools/perf/util/trace-event-read.c
index add8441de579..76f12c705ef9 100644
--- a/tools/perf/util/trace-event-read.c
+++ b/tools/perf/util/trace-event-read.c
@@ -241,7 +241,7 @@ static int read_header_files(struct tep_handle *pevent)
 		 * The commit field in the page is of type long,
 		 * use that instead, since it represents the kernel.
 		 */
-		tep_set_long_size(pevent, pevent->header_page_size_size);
+		tep_set_long_size(pevent, tep_get_header_page_size(pevent));
 	}
 	free(header_page);
 
-- 
2.14.4

Re: [GIT PULL 00/12] perf/core improvements and fixes

[Ingo Molnar]

* Arnaldo Carvalho de Melo <acme@kernel.org> wrote:

> Hi Ingo,
> 
> 	Please consider pulling,
> 
> - Arnaldo
> 
> Test results at the end of this message, as usual.
> 
> The following changes since commit 7c5314b88da6d5af98239786772a1c44cc5eb67d:
> 
>   perf/x86/intel: Add quirk for Goldmont Plus (2018-10-02 10:14:33 +0200)
> 
> are available in the Git repository at:
> 
>   git://git.kernel.org/pub/scm/linux/kernel/git/acme/linux.git tags/perf-core-for-mingo-4.20-20181008
> 
> for you to fetch changes up to bb3dd7e7c4d5e024d607c0ec06c2a2fb9408cc99:
> 
>   tools lib traceevent, perf tools: Move struct tep_handler definition in a local header file (2018-10-08 15:05:37 -0300)
> 
> ----------------------------------------------------------------
> perf/core improvements and fixes:
> 
> . Fix building the python bindings with python3, which fixes some
>   problems with building with clang on Clear Linux (Eduardo Habkost)
> 
> . Fix coverity warnings, fixing up some error paths and plugging
>   some temporary small buffer leaks (Sanskriti Sharma)
> 
> . Adopt a wrapper for strerror_r() for the same reasons as recently
>   for libbpf (Steven Rostedt)
> 
> . S390 does not support watchpoints in 'perf test 22', check if
>   that test is supported by the arch. (Thomas Richter)
> 
> Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
> 
> ----------------------------------------------------------------
> Arnaldo Carvalho de Melo (2):
>       tools include: Adopt linux/bits.h
>       perf auxtrace: Include missing asm/bitsperlong.h to get BITS_PER_LONG
> 
> Eduardo Habkost (2):
>       perf python: Make clang_has_option() work on Python 3
>       perf python: More portable way to make CFLAGS work with clang
> 
> Sanskriti Sharma (5):
>       perf strbuf: Match va_{add,copy} with va_end
>       perf tools: Cleanup trace-event-info 'tdata' leak
>       perf tools: Free 'printk' string in parse_ftrace_printk()
>       perf tools: Avoid double free in read_event_file()
>       perf tools: Free temporary 'sys' string in read_event_files()
> 
> Steven Rostedt (VMware) (1):
>       tools lib traceevent: Separate out tep_strerror() for strerror_r() issues
> 
> Thomas Richter (1):
>       perf test: S390 does not support watchpoints in test 22
> 
> Tzvetomir Stoyanov (1):
>       tools lib traceevent, perf tools: Move struct tep_handler definition in a local header file
> 
>  tools/include/linux/bitops.h             |   7 +-
>  tools/include/linux/bits.h               |  26 +++
>  tools/lib/traceevent/Build               |   2 +
>  tools/lib/traceevent/event-parse-api.c   | 275 +++++++++++++++++++++++++++++++
>  tools/lib/traceevent/event-parse-local.h |  92 +++++++++++
>  tools/lib/traceevent/event-parse.c       |  32 +---
>  tools/lib/traceevent/event-parse.h       | 228 ++++---------------------
>  tools/lib/traceevent/event-plugin.c      |   1 +
>  tools/lib/traceevent/parse-filter.c      |   1 +
>  tools/lib/traceevent/tep_strerror.c      |  53 ++++++
>  tools/perf/check-headers.sh              |   1 +
>  tools/perf/tests/builtin-test.c          |   1 +
>  tools/perf/tests/tests.h                 |   1 +
>  tools/perf/tests/wp.c                    |  12 ++
>  tools/perf/util/auxtrace.h               |   1 +
>  tools/perf/util/setup.py                 |  16 +-
>  tools/perf/util/strbuf.c                 |  10 +-
>  tools/perf/util/trace-event-info.c       |   2 +
>  tools/perf/util/trace-event-parse.c      |  26 +--
>  tools/perf/util/trace-event-read.c       |  11 +-
>  20 files changed, 539 insertions(+), 259 deletions(-)
>  create mode 100644 tools/include/linux/bits.h
>  create mode 100644 tools/lib/traceevent/event-parse-api.c
>  create mode 100644 tools/lib/traceevent/event-parse-local.h
>  create mode 100644 tools/lib/traceevent/tep_strerror.c

Pulled, thanks a lot Arnaldo!

	Ingo

Re: [PATCH 02/12] perf auxtrace: Include missing asm/bitsperlong.h to get BITS_PER_LONG

[Alexander Sverdlin]

Hi!

On 09/10/2018 02:54, Arnaldo Carvalho de Melo wrote:
> From: Arnaldo Carvalho de Melo <acme@redhat.com>
> 
> The auxtrace.h header references BITS_PER_LONG without including the
> header where it is defined, getting it by luck from some other header,
> fix it.
> 
> Cc: Adrian Hunter <adrian.hunter@intel.com>
> Cc: Alexander Sverdlin <alexander.sverdlin@nokia.com>
> Cc: David Ahern <dsahern@gmail.com>
> Cc: Jiri Olsa <jolsa@kernel.org>
> Cc: Namhyung Kim <namhyung@kernel.org>
> Cc: Wang Nan <wangnan0@huawei.com>
> Link: https://lkml.kernel.org/n/tip-v04ydmbh7tvpcctf3zld9j9s@git.kernel.org

Reviewed-by: Alexander Sverdlin <alexander.sverdlin@nokia.com>

> Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
> ---
>  tools/perf/util/auxtrace.h | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/tools/perf/util/auxtrace.h b/tools/perf/util/auxtrace.h
> index 0a6ce9c4fc11..d88f6e9eb461 100644
> --- a/tools/perf/util/auxtrace.h
> +++ b/tools/perf/util/auxtrace.h
> @@ -23,6 +23,7 @@
>  #include <linux/list.h>
>  #include <linux/perf_event.h>
>  #include <linux/types.h>
> +#include <asm/bitsperlong.h>
>  
>  #include "../perf.h"
>  #include "event.h"
> 

-- 
Best regards,
Alexander Sverdlin.

Re: [PATCH 01/12] tools include: Adopt linux/bits.h

[Alexander Sverdlin]

Hello Arnaldo,

On 09/10/2018 02:54, Arnaldo Carvalho de Melo wrote:
> From: Arnaldo Carvalho de Melo <acme@redhat.com>
> 
> So that we reduce the difference of tools/include/linux/bitops.h to the
> original kernel file, include/linux/bitops.h, trying to remove the need
> to define BITS_PER_LONG, to avoid clashes with asm/bitsperlong.h.

thanks for looking into this, but I don't quite get your plan here,
you neither remove redefinition of BITS_PER_LONG in this patch, nor
in any following patch in the series.
Have you forgot to include another patch or shall I try to come up with
a patch removing BITS_PER_LONG from bitops.h? 

> And the things removed from tools/include/linux/bitops.h are really in
> linux/bits.h, so that we can have a copy and then
> tools/perf/check_headers.sh will tell us when new stuff gets added to
> linux/bits.h so that we can check if it is useful and if any adjustment
> needs to be done to the tools/{include,arch}/ copies.
> 
> Cc: Adrian Hunter <adrian.hunter@intel.com>
> Cc: Alexander Sverdlin <alexander.sverdlin@nokia.com>
> Cc: David Ahern <dsahern@gmail.com>
> Cc: Jiri Olsa <jolsa@kernel.org>
> Cc: Namhyung Kim <namhyung@kernel.org>
> Cc: Wang Nan <wangnan0@huawei.com>
> Link: https://lkml.kernel.org/n/tip-y1sqyydvfzo0bjjoj4zsl562@git.kernel.org
> Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
> ---
>  tools/include/linux/bitops.h |  7 ++-----
>  tools/include/linux/bits.h   | 26 ++++++++++++++++++++++++++
>  tools/perf/check-headers.sh  |  1 +
>  3 files changed, 29 insertions(+), 5 deletions(-)
>  create mode 100644 tools/include/linux/bits.h
> 
> diff --git a/tools/include/linux/bitops.h b/tools/include/linux/bitops.h
> index acc704bd3998..0b0ef3abc966 100644
> --- a/tools/include/linux/bitops.h
> +++ b/tools/include/linux/bitops.h
> @@ -3,8 +3,6 @@
>  #define _TOOLS_LINUX_BITOPS_H_
>  
>  #include <asm/types.h>
> -#include <linux/compiler.h>
> -
>  #ifndef __WORDSIZE
>  #define __WORDSIZE (__SIZEOF_LONG__ * 8)
>  #endif
> @@ -12,10 +10,9 @@
>  #ifndef BITS_PER_LONG
>  # define BITS_PER_LONG __WORDSIZE
>  #endif
> +#include <linux/bits.h>
> +#include <linux/compiler.h>
>  
> -#define BIT_MASK(nr)		(1UL << ((nr) % BITS_PER_LONG))
> -#define BIT_WORD(nr)		((nr) / BITS_PER_LONG)
> -#define BITS_PER_BYTE		8
>  #define BITS_TO_LONGS(nr)	DIV_ROUND_UP(nr, BITS_PER_BYTE * sizeof(long))
>  #define BITS_TO_U64(nr)		DIV_ROUND_UP(nr, BITS_PER_BYTE * sizeof(u64))
>  #define BITS_TO_U32(nr)		DIV_ROUND_UP(nr, BITS_PER_BYTE * sizeof(u32))
> diff --git a/tools/include/linux/bits.h b/tools/include/linux/bits.h
> new file mode 100644
> index 000000000000..2b7b532c1d51
> --- /dev/null
> +++ b/tools/include/linux/bits.h
> @@ -0,0 +1,26 @@
> +/* SPDX-License-Identifier: GPL-2.0 */
> +#ifndef __LINUX_BITS_H
> +#define __LINUX_BITS_H
> +#include <asm/bitsperlong.h>
> +
> +#define BIT(nr)			(1UL << (nr))
> +#define BIT_ULL(nr)		(1ULL << (nr))
> +#define BIT_MASK(nr)		(1UL << ((nr) % BITS_PER_LONG))
> +#define BIT_WORD(nr)		((nr) / BITS_PER_LONG)
> +#define BIT_ULL_MASK(nr)	(1ULL << ((nr) % BITS_PER_LONG_LONG))
> +#define BIT_ULL_WORD(nr)	((nr) / BITS_PER_LONG_LONG)
> +#define BITS_PER_BYTE		8
> +
> +/*
> + * Create a contiguous bitmask starting at bit position @l and ending at
> + * position @h. For example
> + * GENMASK_ULL(39, 21) gives us the 64bit vector 0x000000ffffe00000.
> + */
> +#define GENMASK(h, l) \
> +	(((~0UL) - (1UL << (l)) + 1) & (~0UL >> (BITS_PER_LONG - 1 - (h))))
> +
> +#define GENMASK_ULL(h, l) \
> +	(((~0ULL) - (1ULL << (l)) + 1) & \
> +	 (~0ULL >> (BITS_PER_LONG_LONG - 1 - (h))))
> +
> +#endif	/* __LINUX_BITS_H */
> diff --git a/tools/perf/check-headers.sh b/tools/perf/check-headers.sh
> index 466540ee8ea7..c72cc73a6b09 100755
> --- a/tools/perf/check-headers.sh
> +++ b/tools/perf/check-headers.sh
> @@ -14,6 +14,7 @@ include/uapi/linux/sched.h
>  include/uapi/linux/stat.h
>  include/uapi/linux/vhost.h
>  include/uapi/sound/asound.h
> +include/linux/bits.h
>  include/linux/hash.h
>  include/uapi/linux/hw_breakpoint.h
>  arch/x86/include/asm/disabled-features.h
> 

-- 
Best regards,
Alexander Sverdlin.

Re: [PATCH 01/12] tools include: Adopt linux/bits.h

[Arnaldo Carvalho de Melo]

Em Tue, Oct 09, 2018 at 10:47:35AM +0200, Alexander Sverdlin escreveu:
> Hello Arnaldo,
> 
> On 09/10/2018 02:54, Arnaldo Carvalho de Melo wrote:
> > From: Arnaldo Carvalho de Melo <acme@redhat.com>
> > 
> > So that we reduce the difference of tools/include/linux/bitops.h to the
> > original kernel file, include/linux/bitops.h, trying to remove the need
> > to define BITS_PER_LONG, to avoid clashes with asm/bitsperlong.h.
> 
> thanks for looking into this, but I don't quite get your plan here,
> you neither remove redefinition of BITS_PER_LONG in this patch, nor
> in any following patch in the series.

I tried looking into this, got these patches as preparatory, but then
got sidetracked, pushed what I had, have to continue working on it. But
I'm busy with other stuff right now, again.

- Arnaldo

> Have you forgot to include another patch or shall I try to come up with
> a patch removing BITS_PER_LONG from bitops.h? 
> 
> > And the things removed from tools/include/linux/bitops.h are really in
> > linux/bits.h, so that we can have a copy and then
> > tools/perf/check_headers.sh will tell us when new stuff gets added to
> > linux/bits.h so that we can check if it is useful and if any adjustment
> > needs to be done to the tools/{include,arch}/ copies.
> > 
> > Cc: Adrian Hunter <adrian.hunter@intel.com>
> > Cc: Alexander Sverdlin <alexander.sverdlin@nokia.com>
> > Cc: David Ahern <dsahern@gmail.com>
> > Cc: Jiri Olsa <jolsa@kernel.org>
> > Cc: Namhyung Kim <namhyung@kernel.org>
> > Cc: Wang Nan <wangnan0@huawei.com>
> > Link: https://lkml.kernel.org/n/tip-y1sqyydvfzo0bjjoj4zsl562@git.kernel.org
> > Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
> > ---
> >  tools/include/linux/bitops.h |  7 ++-----
> >  tools/include/linux/bits.h   | 26 ++++++++++++++++++++++++++
> >  tools/perf/check-headers.sh  |  1 +
> >  3 files changed, 29 insertions(+), 5 deletions(-)
> >  create mode 100644 tools/include/linux/bits.h
> > 
> > diff --git a/tools/include/linux/bitops.h b/tools/include/linux/bitops.h
> > index acc704bd3998..0b0ef3abc966 100644
> > --- a/tools/include/linux/bitops.h
> > +++ b/tools/include/linux/bitops.h
> > @@ -3,8 +3,6 @@
> >  #define _TOOLS_LINUX_BITOPS_H_
> >  
> >  #include <asm/types.h>
> > -#include <linux/compiler.h>
> > -
> >  #ifndef __WORDSIZE
> >  #define __WORDSIZE (__SIZEOF_LONG__ * 8)
> >  #endif
> > @@ -12,10 +10,9 @@
> >  #ifndef BITS_PER_LONG
> >  # define BITS_PER_LONG __WORDSIZE
> >  #endif
> > +#include <linux/bits.h>
> > +#include <linux/compiler.h>
> >  
> > -#define BIT_MASK(nr)		(1UL << ((nr) % BITS_PER_LONG))
> > -#define BIT_WORD(nr)		((nr) / BITS_PER_LONG)
> > -#define BITS_PER_BYTE		8
> >  #define BITS_TO_LONGS(nr)	DIV_ROUND_UP(nr, BITS_PER_BYTE * sizeof(long))
> >  #define BITS_TO_U64(nr)		DIV_ROUND_UP(nr, BITS_PER_BYTE * sizeof(u64))
> >  #define BITS_TO_U32(nr)		DIV_ROUND_UP(nr, BITS_PER_BYTE * sizeof(u32))
> > diff --git a/tools/include/linux/bits.h b/tools/include/linux/bits.h
> > new file mode 100644
> > index 000000000000..2b7b532c1d51
> > --- /dev/null
> > +++ b/tools/include/linux/bits.h
> > @@ -0,0 +1,26 @@
> > +/* SPDX-License-Identifier: GPL-2.0 */
> > +#ifndef __LINUX_BITS_H
> > +#define __LINUX_BITS_H
> > +#include <asm/bitsperlong.h>
> > +
> > +#define BIT(nr)			(1UL << (nr))
> > +#define BIT_ULL(nr)		(1ULL << (nr))
> > +#define BIT_MASK(nr)		(1UL << ((nr) % BITS_PER_LONG))
> > +#define BIT_WORD(nr)		((nr) / BITS_PER_LONG)
> > +#define BIT_ULL_MASK(nr)	(1ULL << ((nr) % BITS_PER_LONG_LONG))
> > +#define BIT_ULL_WORD(nr)	((nr) / BITS_PER_LONG_LONG)
> > +#define BITS_PER_BYTE		8
> > +
> > +/*
> > + * Create a contiguous bitmask starting at bit position @l and ending at
> > + * position @h. For example
> > + * GENMASK_ULL(39, 21) gives us the 64bit vector 0x000000ffffe00000.
> > + */
> > +#define GENMASK(h, l) \
> > +	(((~0UL) - (1UL << (l)) + 1) & (~0UL >> (BITS_PER_LONG - 1 - (h))))
> > +
> > +#define GENMASK_ULL(h, l) \
> > +	(((~0ULL) - (1ULL << (l)) + 1) & \
> > +	 (~0ULL >> (BITS_PER_LONG_LONG - 1 - (h))))
> > +
> > +#endif	/* __LINUX_BITS_H */
> > diff --git a/tools/perf/check-headers.sh b/tools/perf/check-headers.sh
> > index 466540ee8ea7..c72cc73a6b09 100755
> > --- a/tools/perf/check-headers.sh
> > +++ b/tools/perf/check-headers.sh
> > @@ -14,6 +14,7 @@ include/uapi/linux/sched.h
> >  include/uapi/linux/stat.h
> >  include/uapi/linux/vhost.h
> >  include/uapi/sound/asound.h
> > +include/linux/bits.h
> >  include/linux/hash.h
> >  include/uapi/linux/hw_breakpoint.h
> >  arch/x86/include/asm/disabled-features.h
> > 
> 
> -- 
> Best regards,
> Alexander Sverdlin.