From: Lee Jones <lee.jones@linaro.org>
To: Jia-Ju Bai <baijiaju1990@gmail.com>
Cc: Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [BUG] mfd: ezx-pcap: Possible sleep-in-atomic-context bugs in pcap_adc_irq()
Date: Tue, 9 Oct 2018 02:07:15 -0700 [thread overview]
Message-ID: <20181009090715.GE4939@dell> (raw)
In-Reply-To: <e371a365-7dac-8e20-4823-f5395602211d@gmail.com>
On Mon, 17 Sep 2018, Jia-Ju Bai wrote:
>
>
> On 2018/9/17 9:03, Lee Jones wrote:
> > On Sat, 15 Sep 2018, Jia-Ju Bai wrote:
> >
> > > The driver may sleep in an interrupt handler.
> > > The function call paths (from bottom to top) in Linux-4.17 are:
> > >
> > > [FUNC] mutex_lock_nested
> > > drivers/mfd/ezx-pcap.c, 272:
> > > mutex_lock_nested in pcap_adc_irq (interrupt handler)
> > >
> > > [FUNC] mutex_lock_nested
> > > drivers/mfd/ezx-pcap.c, 100:
> > > mutex_lock_nested in ezx_pcap_read
> > > drivers/mfd/ezx-pcap.c, 281:
> > > ezx_pcap_read in pcap_adc_irq (interrupt handler)
> > >
> > > [FUNC] mutex_lock_nested
> > > drivers/mfd/ezx-pcap.c, 85:
> > > mutex_lock_nested in ezx_pcap_write
> > > drivers/mfd/ezx-pcap.c, 285:
> > > ezx_pcap_write in pcap_adc_irq (interrupt handler)
> > >
> > > [FUNC] mutex_lock_nested
> > > drivers/mfd/ezx-pcap.c, 244:
> > > mutex_lock_nested in pcap_adc_trigger
> > > drivers/mfd/ezx-pcap.c, 299:
> > > pcap_adc_trigger in pcap_adc_irq (interrupt handler)
> > >
> > > These bugs are found by my static analysis tool DSAC.
> > Not sure what you want me to do with this.
> >
> > Do you have something in mind?
> >
>
> I find some possible bugs in this driver, but I do not know how to correctly
> fix them...
> Could you find a good solution?
If you have found bugs and do not intend on fixing them, please report
them via the 'File a Bug' option here:
https://bugzilla.kernel.org/
--
Lee Jones [李琼斯]
Linaro Services Technical Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
next prev parent reply other threads:[~2018-10-09 9:07 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-09-15 8:50 [BUG] mfd: ezx-pcap: Possible sleep-in-atomic-context bugs in pcap_adc_irq() Jia-Ju Bai
2018-09-17 1:03 ` Lee Jones
2018-09-17 2:46 ` Jia-Ju Bai
2018-10-09 9:07 ` Lee Jones [this message]
2018-10-10 7:31 ` Jia-Ju Bai
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181009090715.GE4939@dell \
--to=lee.jones@linaro.org \
--cc=baijiaju1990@gmail.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox