Re: [PATCH v4 3/3] x86/acpi: take rsdp address for boot params if available

Juergen Gross
2018-10-09T13:25:49Z

On 09/10/2018 15:22, Boris Ostrovsky wrote:
> On 10/9/18 6:54 AM, Juergen Gross wrote:
>> +
>> +u64 x86_default_get_root_pointer(void)
>> +{
>> + return boot_params.hdr.acpi_rsdp_addr;
>> +}
>
>
> Should we then update init_pvh_bootparams() with
>
>     pvh_bootparams.hdr.acpi_rsdp_addr = pvh_start_info.rsdp_paddr;
>
> (and drop x86_init.acpi.get_root_pointer = pvh_get_root_pointer;) ?

I was planning to do this as a follow on patch.

Juergen

>
> -boris
>
>> diff --git a/arch/x86/kernel/x86_init.c b/arch/x86/kernel/x86_init.c
>> index 2792b5573818..50a2b492fdd6 100644
>> --- a/arch/x86/kernel/x86_init.c
>> +++ b/arch/x86/kernel/x86_init.c
>> @@ -31,7 +31,6 @@ static int __init iommu_init_noop(void) { return 0; }
>> static void iommu_shutdown_noop(void) { }
>> static bool __init bool_x86_init_noop(void) { return false; }
>> static void x86_op_int_noop(int cpu) { }
>> -static u64 u64_x86_init_noop(void) { return 0; }
>>
>> /*
>> * The platform setup functions are preset with the default functions
>> @@ -96,7 +95,7 @@ struct x86_init_ops x86_init __initdata = {
>> },
>>
>> .acpi = {
>> - .get_root_pointer = u64_x86_init_noop,
>> + .get_root_pointer = x86_default_get_root_pointer,
>> .reduced_hw_early_init = acpi_generic_reduced_hw_init,
>> },
>> };
>
>