From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.6 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_PASS, URIBL_BLOCKED,USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 12395C64EB8 for ; Tue, 9 Oct 2018 15:15:44 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id C7BCB214C5 for ; Tue, 9 Oct 2018 15:15:43 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=kernel.org header.i=@kernel.org header.b="dPWipFoR" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org C7BCB214C5 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=linuxfoundation.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726722AbeJIWdF (ORCPT ); Tue, 9 Oct 2018 18:33:05 -0400 Received: from mail.kernel.org ([198.145.29.99]:46820 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726418AbeJIWdF (ORCPT ); Tue, 9 Oct 2018 18:33:05 -0400 Received: from localhost (ip-213-127-77-176.ip.prioritytelecom.net [213.127.77.176]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 2E494214C5; Tue, 9 Oct 2018 15:15:40 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1539098140; bh=rTVVzimHPT5zjErwjAVplaGZk6TZZJfnsRMtwUmNrMM=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=dPWipFoRyyUliTYmT7uzuUAkpfeVDn6XmdkQnwFe9tXiAsAev0Cn5nXvDORxFySEc NBeqkg8zjdFDUfktjrcU996CsOj8rhl9ib+HiWh0XxuvpJMhQkZTfR168Uxwannp15 0Qn9MTGj39nStZto0gD7VYPSz4edLD5etyvDLOxg= Date: Tue, 9 Oct 2018 17:15:38 +0200 From: Greg Kroah-Hartman To: "Deucher, Alexander" Cc: "linux-kernel@vger.kernel.org" , "stable@vger.kernel.org" , "Wentland, Harry" , "Zhu, Rex" , Sasha Levin Subject: Re: [PATCH 4.18 222/235] drm/amd/pp: Send khz clock values to DC for smu7/8 Message-ID: <20181009151538.GA23783@kroah.com> References: <20180924113103.999624566@linuxfoundation.org> <20180924113125.488862921@linuxfoundation.org> <20181008144421.GB15968@kroah.com> <20181008171115.GB29418@kroah.com> <20181009124520.GA1633@kroah.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Oct 09, 2018 at 01:55:06PM +0000, Deucher, Alexander wrote: > > -----Original Message----- > > From: Greg Kroah-Hartman > > Sent: Tuesday, October 9, 2018 8:45 AM > > To: Deucher, Alexander > > Cc: linux-kernel@vger.kernel.org; stable@vger.kernel.org; Wentland, Harry > > ; Zhu, Rex ; Sasha Levin > > > > Subject: Re: [PATCH 4.18 222/235] drm/amd/pp: Send khz clock values to DC > > for smu7/8 > > > > On Mon, Oct 08, 2018 at 06:01:50PM +0000, Deucher, Alexander wrote: > > > > -----Original Message----- > > > > From: Greg Kroah-Hartman > > > > Sent: Monday, October 8, 2018 1:11 PM > > > > To: Deucher, Alexander > > > > Cc: linux-kernel@vger.kernel.org; stable@vger.kernel.org; Wentland, > > > > Harry ; Zhu, Rex ; > > Sasha > > > > Levin > > > > Subject: Re: [PATCH 4.18 222/235] drm/amd/pp: Send khz clock values > > > > to DC for smu7/8 > > > > > > > > On Mon, Oct 08, 2018 at 04:02:19PM +0000, Deucher, Alexander wrote: > > > > > > -----Original Message----- > > > > > > From: Greg Kroah-Hartman > > > > > > Sent: Monday, October 8, 2018 10:44 AM > > > > > > To: Deucher, Alexander > > > > > > Cc: linux-kernel@vger.kernel.org; stable@vger.kernel.org; > > > > > > Wentland, Harry ; Zhu, Rex > > > > > > ; > > > > Sasha > > > > > > Levin > > > > > > Subject: Re: [PATCH 4.18 222/235] drm/amd/pp: Send khz clock > > > > > > values to DC for smu7/8 > > > > > > > > > > > > On Mon, Oct 08, 2018 at 02:33:56PM +0000, Deucher, Alexander > > wrote: > > > > > > > > -----Original Message----- > > > > > > > > From: Greg Kroah-Hartman > > > > > > > > Sent: Monday, September 24, 2018 7:53 AM > > > > > > > > To: linux-kernel@vger.kernel.org > > > > > > > > Cc: Greg Kroah-Hartman ; > > > > > > > > stable@vger.kernel.org; Wentland, Harry > > > > > > > > ; Deucher, Alexander > > > > > > > > ; Zhu, Rex > > ; > > > > Sasha > > > > > > > > Levin > > > > > > > > Subject: [PATCH 4.18 222/235] drm/amd/pp: Send khz clock > > > > > > > > values to DC for > > > > > > > > smu7/8 > > > > > > > > > > > > > > > > 4.18-stable review patch. If anyone has any objections, > > > > > > > > please let me > > > > > > know. > > > > > > > > > > > > > > > > > > > > > > This regresses power usage on 4.18. Please revert. > > > > > > > https://bugzilla.kernel.org/show_bug.cgi?id=201275 > > > > > > > > > > > > Is it reverted in "upstream" as well? If not, please get the > > > > > > fix in there and then I will be glad to backport it here. > > > > > > > > > > > > > > > > There's no breakage in upstream. This patch addressed breakages > > > > > in > > > > > 4.19 specifically due to some other refactoring we did in the driver. > > > > > I'll try and dig out the exact series of patches this addressed. > > > > > > > > So there is no problem in 4.19-rc7? That contridicts the statement > > > > of looking in drm-next for the fixes. > > > > > > Sorry, what statement about drm-next? This patch was for 4.19 and was > > not intended for 4.18. It was picked up by Sasha's auto select system for > > stable. > > > > I thought this thread said that. > > > > Ok, so I should just revert it? > > Yes, please. Now reverted, thanks. greg k-h