Re: [PATCH v4 2/2] locking/pvqspinlock, hv: Enable PV qspinlock for Hyper-V

Yi Sun
2018-10-10T02:28:27Z

On 18-10-09 12:54:27, Ingo Molnar wrote:
>
> * Yi Sun <yi.y.sun@linux.intel.com> wrote:
>
> > Follow PV spinlock mechanism to implement the callback functions
> > to allow the CPU idling and kicking operations on Hyper-V.
>
> > +#if defined(CONFIG_SMP)
> > + smp_ops.smp_prepare_boot_cpu = hv_smp_prepare_boot_cpu;
> > +#endif
>
> What's wrong with using the common pattern of:
>
> #ifdef CONFIG_SMP
>
> ?

There is no difference between "#ifdef" and "#if defined". I just copied
it from "hv_smp_prepare_boot_cpu()". Do you need me submit a fix patch
after this set is merged?

>
> Thanks,
>
> Ingo