Re: [RCF PATCH v2 1/2] dt-bindings: pwm: imx: Allow switching PWM output between PWM and GPIO

Thierry Reding
2018-10-10T13:39:11Z

[-- Attachment #1: Type: text/plain, Size: 3360 bytes --]

On Wed, Oct 10, 2018 at 09:33:25AM +0000, Vokáč Michal wrote:
> Output of the PWM block on i.MX SoCs is always low when the block is
> disabled. This can cause issues when inverted PWM polarity is needed.
> With inverted polarity a duty cycle = 0% corresponds to high level on
> the output. Now, when PWM is disabled its output instantly goes low
> which corresponds to duty cycle = 100%.
>
> To get a truly inverted PWM output two pinctrl states of the PWM pin
> can be used. Configure the pin to GPIO function when PWM is disabled
> and switch back to PWM function whenever non-zero duty cycle is needed.
>
> Signed-off-by: Michal Vokáč <michal.vokac@ysoft.com>
> ---
> Changes in v2:
> - Do not use the "default" pinctrl state for GPIO.
> - Use two new "pwm" and "gpio" pinctrl states.
> - Add a new pwm-gpios signal.
>
> Documentation/devicetree/bindings/pwm/imx-pwm.txt | 51 +++++++++++++++++++++++
> 1 file changed, 51 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/pwm/imx-pwm.txt b/Documentation/devicetree/bindings/pwm/imx-pwm.txt
> index c61bdf8..bd5b6bd 100644
> --- a/Documentation/devicetree/bindings/pwm/imx-pwm.txt
> +++ b/Documentation/devicetree/bindings/pwm/imx-pwm.txt
> @@ -14,6 +14,17 @@ See the clock consumer binding,
> Documentation/devicetree/bindings/clock/clock-bindings.txt
> - interrupts: The interrupt for the pwm controller
>
> +Optional properties:
> +- pinctrl: For i.MX27 and newer SoCs. Use "pwm" and "gpio" specific pinctrls
> + instead of the "default" to configure the PWM pin to GPIO and PWM function.
> + It allows control over the pin output level when the PWM block is disabled.
> + This is useful if you use the PWM for single purpose and you need inverted
> + polarity of the PWM signal. See "Inverted PWM output" section bellow.
> +- pwm-gpios: Specify the GPIO pin that will act as the PWM output. This should
> + be the same pin as is used for normal PWM output. Define the pin as
> + GPIO_ACTIVE_LOW to get HIGH level on the output when PWM is disabled. See
> + "Inverted PWM output" section bellow.

It's somewhat unfortunate that we have to specify this in DT. For one
thing, we don't really want to use the pin as GPIO, we really only care
about whether it is "active" or "inactive". We also already specify the
GPIO in the pinctrl nodes, albeit via a different name. So we're
effectively duplicating information here. It'd be nice to avoid that.
Two possibilities that I could think about are:

1) Do not explicitly rely on driving the GPIO as output: I know this
was discussed before and it sounds like this is not an option for
PWM because the GPIO may be configured as output by the firmware,
and hence switching to GPIO mode may not give the expected result.
I suppose one way to solve this is by using a gpio-hog entry for
the PWM GPIO so that it will automatically get configured as an
input and at the same time marked as busy so that nobody can go
and just request it again (via sysfs for example).

2) Derive the GPIO from the pin. I'm not sure there's anything in the
pinctrl framework to do that. The reverse (GPIO -> pin) can be
done, so perhaps this is something that could be added?

Other than than I think this looks very nice.

Thierry

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]