From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_PASS,URIBL_BLOCKED,USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E85A9C43441 for ; Wed, 10 Oct 2018 22:44:11 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 8BACD2086E for ; Wed, 10 Oct 2018 22:44:11 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 8BACD2086E Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=intel.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726050AbeJKGIY (ORCPT ); Thu, 11 Oct 2018 02:08:24 -0400 Received: from mga12.intel.com ([192.55.52.136]:65173 "EHLO mga12.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725968AbeJKGIY (ORCPT ); Thu, 11 Oct 2018 02:08:24 -0400 X-Amp-Result: UNKNOWN X-Amp-Original-Verdict: FILE UNKNOWN X-Amp-File-Uploaded: False Received: from orsmga005.jf.intel.com ([10.7.209.41]) by fmsmga106.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 10 Oct 2018 15:44:09 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.54,366,1534834800"; d="scan'208";a="264651589" Received: from unknown (HELO localhost.localdomain) ([10.232.112.69]) by orsmga005.jf.intel.com with ESMTP; 10 Oct 2018 15:43:53 -0700 Date: Wed, 10 Oct 2018 16:40:51 -0600 From: Keith Busch To: Andrew Morton Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org, Kirill Shutemov , Dave Hansen , Dan Williams Subject: Re: [PATCH 1/6] mm/gup_benchmark: Time put_page Message-ID: <20181010224051.GB11034@localhost.localdomain> References: <20181010195605.10689-1-keith.busch@intel.com> <20181010152655.8510270e5db753f6666f12d3@linux-foundation.org> <20181010222843.GA11034@localhost.localdomain> <20181010154111.e3b37422f31dcf3d6b73ebe0@linux-foundation.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20181010154111.e3b37422f31dcf3d6b73ebe0@linux-foundation.org> User-Agent: Mutt/1.9.1 (2017-09-22) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Oct 10, 2018 at 03:41:11PM -0700, Andrew Morton wrote: > On Wed, 10 Oct 2018 16:28:43 -0600 Keith Busch wrote: > > > > > struct gup_benchmark { > > > > - __u64 delta_usec; > > > > + __u64 get_delta_usec; > > > > + __u64 put_delta_usec; > > > > __u64 addr; > > > > __u64 size; > > > > __u32 nr_pages_per_call; > > > > > > If we move put_delta_usec to the end of this struct, the ABI remains > > > back-compatible? > > > > If the kernel writes to a new value appended to the end of the struct, > > and the application allocated the older sized struct, wouldn't that > > corrupt the user memory? > > Looks like it. How about we do this while we're breaking it? Yep, that sounds good to me! > --- a/mm/gup_benchmark.c~mm-gup_benchmark-time-put_page-fix > +++ a/mm/gup_benchmark.c > @@ -14,6 +14,7 @@ struct gup_benchmark { > __u64 size; > __u32 nr_pages_per_call; > __u32 flags; > + __u64 expansion[10]; /* For future use */ > }; > > static int __gup_benchmark_ioctl(unsigned int cmd, >