From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.3 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_PASS,USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 00E28C32788 for ; Thu, 11 Oct 2018 08:52:43 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id A2D062085B for ; Thu, 11 Oct 2018 08:52:42 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org A2D062085B Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=alien8.de Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728168AbeJKQTA (ORCPT ); Thu, 11 Oct 2018 12:19:00 -0400 Received: from mail.skyhub.de ([5.9.137.197]:57948 "EHLO mail.skyhub.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726205AbeJKQTA (ORCPT ); Thu, 11 Oct 2018 12:19:00 -0400 X-Virus-Scanned: Nedap ESD1 at mail.skyhub.de Received: from mail.skyhub.de ([127.0.0.1]) by localhost (blast.alien8.de [127.0.0.1]) (amavisd-new, port 10026) with ESMTP id M0LG-zGi6bUA; Thu, 11 Oct 2018 10:52:40 +0200 (CEST) Received: from zn.tnic (p200300EC2BD5D200329C23FFFEA6A903.dip0.t-ipconnect.de [IPv6:2003:ec:2bd5:d200:329c:23ff:fea6:a903]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.skyhub.de (SuperMail on ZX Spectrum 128k) with ESMTPSA id B87671EC02D1; Thu, 11 Oct 2018 10:52:39 +0200 (CEST) Date: Thu, 11 Oct 2018 10:52:34 +0200 From: Borislav Petkov To: Masahiro Yamada Cc: Linux Kernel Mailing List , Michal Marek , Linux Kbuild mailing list Subject: Re: [PATCH] kbuild: Fail the build early when no lz4 present Message-ID: <20181011085234.GA25435@zn.tnic> References: <20181010222333.17794-1-bp@alien8.de> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Oct 11, 2018 at 01:26:23PM +0900, Masahiro Yamada wrote: > So, the cause of the failure is clear enough > from the build log. Sure but it wasts unnecessary build cycles and appears only after all the compilation units have been produced. > It is weird to check only lz4c. > If CONFIG_KERNEL_LZO is enabled, but lzop is not installed, > I see this log > > LZO arch/x86/boot/compressed/vmlinux.bin.lzo > /bin/sh: 1: lzop: not found > > It is still clear what to do, though. Right, we should test for that too. Unless distros start installing it by default. It is not installed by default on a debian guest here, at least. SLES15 either: $ lzop If 'lzop' is not a typo you can use command-not-found to lookup the package that contains it, like this: cnf lzop > Is it necessary to check this earlier? Yes, see above. > If you get this error, you just need to install the tool. > Then, you can re-run the incremental build. Actually, I'd prefer the build to fail early so that machine can continue with the next build. > BTW, this patch has a drawback. > > [1] Enable CONFIG_KERNEL_LZ4 on the system > without lz4c installed > > [2] Run 'make' and you will get the error > "lz4 tool not found on this system but CONFIG_KERNEL_LZ4 enabled" > > [3] Run 'make menuconfig' and > switch from CONFIG_KERNEL_LZ4 to CONFIG_KERNEL_GZIP > > [4] Run 'make' and you will still get the same error > even after you have chosen to use GZIP instead of LZ4. Well, there's code in Makefile to refresh include/config/auto.conf but for whatever reason that make in step 4 doesn't run it. And *that* looks like a bug - if a user runs "make menuconfig" and .config gets updated, then include/config/auto.conf better get updated too. Right? Thx. -- Regards/Gruss, Boris. Good mailing practices for 400: avoid top-posting and trim the reply.